Re: [PATCHv2] ib_srp: Remove WARN_ON in srp_terminate_io()

2018-10-17 Thread Doug Ledford
On Wed, 2018-10-17 at 11:30 -0400, Doug Ledford wrote: > On Wed, 2018-10-17 at 07:43 -0700, Bart Van Assche wrote: > > On 10/17/18 12:20 AM, Hannes Reinecke wrote: > > > The WARN_ON() is pointless as the rport is placed in > > > SDEV_TRANSPORT_OFFLINE > > > at that time, so no new commands can be

Re: [PATCHv2] ib_srp: Remove WARN_ON in srp_terminate_io()

2018-10-17 Thread Doug Ledford
On Wed, 2018-10-17 at 07:43 -0700, Bart Van Assche wrote: > On 10/17/18 12:20 AM, Hannes Reinecke wrote: > > The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE > > at that time, so no new commands can be submitted via srp_queuecommand() > > > > Signed-off-by: Hannes Reinec

Re: [PATCHv2] ib_srp: Remove WARN_ON in srp_terminate_io()

2018-10-17 Thread Bart Van Assche
On 10/17/18 12:20 AM, Hannes Reinecke wrote: The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE at that time, so no new commands can be submitted via srp_queuecommand() Signed-off-by: Hannes Reinecke Reviewed-by: Jens Axboe Reviewed-by: Johannes Thumshirn --- driver

[PATCHv2] ib_srp: Remove WARN_ON in srp_terminate_io()

2018-10-17 Thread Hannes Reinecke
The WARN_ON() is pointless as the rport is placed in SDEV_TRANSPORT_OFFLINE at that time, so no new commands can be submitted via srp_queuecommand() Signed-off-by: Hannes Reinecke Reviewed-by: Jens Axboe Reviewed-by: Johannes Thumshirn --- drivers/infiniband/ulp/srp/ib_srp.c | 7 --- 1 fil