[PATCH] usb: core: hub: Removed some warnings generated by checkpatch.pl

2015-08-11 Thread Chase Metzger
Removed some checkpatch.pl warnings saying there was an unwanted space between function names and their arguments. Signed-off-by: Chase Metzger --- drivers/usb/core/hub.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/usb/core/hub.c b/drive

[PATCH] usbtest: Use boottime

2015-08-11 Thread Abhilash Jindal
Wall time obtained from do_gettimeofday is susceptible to sudden jumps due to user setting the time or due to NTP. Boot time is constantly increasing time better suited for comparing two timestamps. Signed-off-by: Abhilash Jindal --- drivers/usb/misc/usbtest.c | 14 -- 1 file chan

Re: usb: gadget: mv: Add USB 3.0 device driver for Marvell PXA2128 chip.

2015-08-11 Thread Felipe Balbi
On Tue, Aug 11, 2015 at 02:16:59PM -0500, Felipe Balbi wrote: > On Tue, Aug 11, 2015 at 10:13:40PM +0300, Dan Carpenter wrote: > > Hello Yu Xu, > > > > The patch 3d4eb9dfa3e8: "usb: gadget: mv: Add USB 3.0 device driver > > for Marvell PXA2128 chip." from Jun 15, 2012, leads to the following > > s

Re: usb: gadget: mv: Add USB 3.0 device driver for Marvell PXA2128 chip.

2015-08-11 Thread Felipe Balbi
On Tue, Aug 11, 2015 at 10:13:40PM +0300, Dan Carpenter wrote: > Hello Yu Xu, > > The patch 3d4eb9dfa3e8: "usb: gadget: mv: Add USB 3.0 device driver > for Marvell PXA2128 chip." from Jun 15, 2012, leads to the following > static checker warning: > > drivers/usb/gadget/udc/mv_u3d_core.c:166

re: usb: gadget: mv: Add USB 3.0 device driver for Marvell PXA2128 chip.

2015-08-11 Thread Dan Carpenter
Hello Yu Xu, The patch 3d4eb9dfa3e8: "usb: gadget: mv: Add USB 3.0 device driver for Marvell PXA2128 chip." from Jun 15, 2012, leads to the following static checker warning: drivers/usb/gadget/udc/mv_u3d_core.c:1668 mv_u3d_irq_process_tr_complete() warn: 'status' can be either ne

Re: [PATCH] usbtest: Use boottime

2015-08-11 Thread Felipe Balbi
On Tue, Aug 11, 2015 at 11:57:15AM -0400, Abhilash Jindal wrote: > Wall time obtained from do_gettimeofday is susceptible to sudden jumps due to > user setting the time or due to NTP. Boot time is constantly increasing time > better suited for comparing two timestamps. > > Signed-off-by: Abhilash

Re: [PATCH] usbtest: Use boottime

2015-08-11 Thread Sergei Shtylyov
Hello. On 08/11/2015 06:57 PM, Abhilash Jindal wrote: Wall time obtained from do_gettimeofday is susceptible to sudden jumps due to user setting the time or due to NTP. Boot time is constantly increasing time better suited for comparing two timestamps. Signed-off-by: Abhilash Jindal ---

[PATCH] usbtest: Use boottime

2015-08-11 Thread Abhilash Jindal
Wall time obtained from do_gettimeofday is susceptible to sudden jumps due to user setting the time or due to NTP. Boot time is constantly increasing time better suited for comparing two timestamps. Signed-off-by: Abhilash Jindal --- drivers/usb/misc/usbtest.c | 15 +-- 1 file cha

[PATCH] usb: hub: remove assignment from if condition

2015-08-11 Thread Kris Borer
Fix one occurrence of the checkpatch.pl error: ERROR: do not use assignment in if condition The semantic patch that makes this change is: // @@ identifier i; expression E, E2, E3; statement S1, S2; binary operator b; @@ + i = E; if ( - (i = E) + i b ... && E2 && E3 ) S1 else S2 // Sign

USB 3.0 LPM Certification issues

2015-08-11 Thread Joao Pinto
Hi! When testing our USB 3.0 Device IP solution we typically run the Compliance Tests for USB 3.0 and also for USB 2.0. We find an issue regarding the USB 2.0 CV Chapter 9 test: LPM L1 Suspend Resume Test. For it to be successful we have to edit the gadget driver in order to configure the baseline

Re: option driver crashes on modem removal

2015-08-11 Thread Alan Stern
On Tue, 11 Aug 2015, Alan Stern wrote: > On Tue, 11 Aug 2015, Bjørn Mork wrote: > > > Oliver Neukum writes: > > > > >> I hope some of the USB experts can tell us what the correct behaviour > > >> is > > >> here. Should the driver treat EPROTO like ESHUTDOWN? Or should the > > >> host controll

Re: option driver crashes on modem removal

2015-08-11 Thread Alan Stern
On Tue, 11 Aug 2015, Bjørn Mork wrote: > Oliver Neukum writes: > > >> I hope some of the USB experts can tell us what the correct behaviour > >> is > >> here. Should the driver treat EPROTO like ESHUTDOWN? Or should the > >> host controller use some ESHUTDOWN instead? > > > > No. ESHUTDOWN is

Re: option driver crashes on modem removal

2015-08-11 Thread Alan Stern
On Tue, 11 Aug 2015, Oliver Neukum wrote: > On Tue, 2015-08-11 at 13:48 +0200, Bjørn Mork wrote: > > I wonder if this is related to different platforms using different > > errors for this event? As you can see, I get ESHUTDOWN where you got > > EPROTO. The driver resubmits the URB in the EPROTO c

Re: option driver crashes on modem removal

2015-08-11 Thread Alan Stern
On Tue, 11 Aug 2015, Bjørn Mork wrote: > Yegor Yefremov writes: > > > On Tue, Aug 11, 2015 at 11:58 AM, Bjørn Mork wrote: > >> [replaced 'netdev' with 'linux-usb' as this concerns a USB serial driver > >> only] > >> > >> Yegor Yefremov writes: > >> > >>> I have following problem. When removin

Re: [PATCH v1] usb: dwc2: reset AHB hclk domain before init

2015-08-11 Thread Felipe Balbi
Hi, On Tue, Aug 11, 2015 at 10:27:42AM +0800, Yunzhi Li wrote: > We initiate dwc2 usb controller in BIOS, when kernel driver > start-up we should reset AHB hclk domain to reset all AHB > interface registers to default. Without this the FIFO value > setting might be incorrect because calculating FI

Re: option driver crashes on modem removal

2015-08-11 Thread Bjørn Mork
Oliver Neukum writes: >> I hope some of the USB experts can tell us what the correct behaviour >> is >> here. Should the driver treat EPROTO like ESHUTDOWN? Or should the >> host controller use some ESHUTDOWN instead? > > No. ESHUTDOWN is reserved for the removal of the HC. Then I have to ask:

Re: option driver crashes on modem removal

2015-08-11 Thread Yegor Yefremov
[adding musb maintainer Felipe Balbi to this discussion] On Tue, Aug 11, 2015 at 2:25 PM, Oliver Neukum wrote: > On Tue, 2015-08-11 at 13:48 +0200, Bjørn Mork wrote: >> I wonder if this is related to different platforms using different >> errors for this event? As you can see, I get ESHUTDOWN wh

Re: option driver crashes on modem removal

2015-08-11 Thread Oliver Neukum
On Tue, 2015-08-11 at 13:48 +0200, Bjørn Mork wrote: > I wonder if this is related to different platforms using different > errors for this event? As you can see, I get ESHUTDOWN where you got > EPROTO. The driver resubmits the URB in the EPROTO case. And that's > probably why you end up with a de

Re: option driver crashes on modem removal

2015-08-11 Thread Bjørn Mork
Yegor Yefremov writes: > On Tue, Aug 11, 2015 at 11:58 AM, Bjørn Mork wrote: >> [replaced 'netdev' with 'linux-usb' as this concerns a USB serial driver >> only] >> >> Yegor Yefremov writes: >> >>> I have following problem. When removing USB dongle 07d1:3e01 or >>> SierraWireless MC7304 I get

Re: option driver crashes on modem removal

2015-08-11 Thread Yegor Yefremov
On Tue, Aug 11, 2015 at 11:58 AM, Bjørn Mork wrote: > [replaced 'netdev' with 'linux-usb' as this concerns a USB serial driver only] > > Yegor Yefremov writes: > >> I have following problem. When removing USB dongle 07d1:3e01 or >> SierraWireless MC7304 I get following messages: >> >> option1 tty

Re: option driver crashes on modem removal

2015-08-11 Thread Bjørn Mork
[replaced 'netdev' with 'linux-usb' as this concerns a USB serial driver only] Yegor Yefremov writes: > I have following problem. When removing USB dongle 07d1:3e01 or > SierraWireless MC7304 I get following messages: > > option1 ttyUSB10: option_instat_callback: error -71 > option1 ttyUSB9: opt

[PATCH] usb: chipidea: reuse the platform_data to store the ci info

2015-08-11 Thread Barry Song
From: Rong Wang Chipidea puts ci information to drvdata, but this overwrites the drvdata placed by EHCI core. EHCI core thinks drvdata is ehci_hcd. We can find this from codes like ehci-sysfs.c: static ssize_t show_companion(struct device *dev, struct device_attribut

Re: [PATCH 2/2] drivers/usb: Delete XHCI command timer if necessary

2015-08-11 Thread Oliver Neukum
On Mon, 2015-08-03 at 16:07 +0300, Mathias Nyman wrote: > From: Gavin Shan > > When xhci_mem_cleanup() is called, it's possible that the command > timer isn't initialized and scheduled. For those cases, to delete > the command timer causes soft-lockup as below stack dump shows. > > The patch avo

[PATCH v1 1/3] usb: dwc2: reset AHB hclk domain before init

2015-08-11 Thread Yunzhi Li
We initiate dwc2 usb controller in BIOS, when kernel driver start-up we should reset AHB hclk domain to reset all AHB interface registers to default. Without this the FIFO value setting might be incorrect because calculating FIFO size need the power-on value of GRXFSIZ/GNPTXFSIZ/HPTXFSIZ registers.