On Thu, May 03, 2007 at 08:11:43PM +0200, Mondrian Nuessle wrote:
> Ok, I looked over everything again. I was blind!
I acked your code, and i didn't really bother to look what you actually
were doing. The old register accesses don't invite one to look over
them. You were no blinder than i was.
Ok, I looked over everything again. I was blind!
Luc, you are absolutely right.
And we do not need a dk8_htx enable function. Just use the ARUMA one.
The code I posted was based on reverse engineering registers, it worked
for us very well for months. So I never bothered checking the other
boards.
There are some serious problems with this code. And things only become
transparent when you introduce those helper functions.
This is what your function is reduced to:
/*
* Disable the flash write protect (which is connected to the
* Winbond W83627HF GPIOs).
*
* There are some severe discrep
On Thu, May 03, 2007 at 03:46:43AM +0200, Stefan Reinauer wrote:
> * Uwe Hermann <[EMAIL PROTECTED]> [070428 01:59]:
> > Signed-off-by: Mondrian Nuessle <[EMAIL PROTECTED]>
> > Signed-off-by: Uwe Hermann <[EMAIL PROTECTED]>
> Acked-by: Stefan Reinauer <[EMAIL PROTECTED]>
Committed in r2624.
Uwe.
>> Well, as soon as this code is in, i'll put up a patch for the functions,
>> and you'll see that it really makes a lot of difference, even on such a
>> small file. 3 out of 4 board enables make use of it though.
>
> Yep, thanks! It sounded like overkill when I read about it the first
> time, b
* Uwe Hermann <[EMAIL PROTECTED]> [070428 01:59]:
> Signed-off-by: Mondrian Nuessle <[EMAIL PROTECTED]>
> Signed-off-by: Uwe Hermann <[EMAIL PROTECTED]>
Acked-by: Stefan Reinauer <[EMAIL PROTECTED]>
--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax:
On Wed, May 02, 2007 at 10:14:00PM +0200, Luc Verhaegen wrote:
> On Wed, May 02, 2007 at 06:45:42PM +0200, Mondrian Nuessle wrote:
> > While I think that a clean function interface is nice, I can live
> > without it...
> > So I could go with the patch, as Uwe provided it.
> >
> > Mondrian
>
> Wel
On Wed, May 02, 2007 at 06:45:42PM +0200, Mondrian Nuessle wrote:
> While I think that a clean function interface is nice, I can live
> without it...
> So I could go with the patch, as Uwe provided it.
>
> Mondrian
Well, as soon as this code is in, i'll put up a patch for the functions,
and you'
While I think that a clean function interface is nice, I can live
without it...
So I could go with the patch, as Uwe provided it.
Mondrian
Luc Verhaegen wrote:
> On Sat, Apr 28, 2007 at 02:00:42AM +0200, Uwe Hermann wrote:
>> On Fri, Apr 27, 2007 at 10:33:53PM +0200, Luc Verhaegen wrote:
>>> On F
On Sat, Apr 28, 2007 at 02:00:42AM +0200, Uwe Hermann wrote:
> On Fri, Apr 27, 2007 at 10:33:53PM +0200, Luc Verhaegen wrote:
> > On Fri, Apr 27, 2007 at 04:44:10PM +0200, Mondrian Nuessle wrote:
> > > Actually you do not need to set the index reg twice. I just used the
> > > code pattern from the
On Fri, Apr 27, 2007 at 10:33:53PM +0200, Luc Verhaegen wrote:
> On Fri, Apr 27, 2007 at 04:44:10PM +0200, Mondrian Nuessle wrote:
> > Actually you do not need to set the index reg twice. I just used the
> > code pattern from the Agami Aruma board, which does the same thing...
>
> In that case, we
On Fri, Apr 27, 2007 at 01:25:11PM +0200, Luc Verhaegen wrote:
> Acked-by: Luc Verhaegen <[EMAIL PROTECTED]>
One more revision, please :)
I fixed some more cosmetic issues and reduced the patch to just the
relevant code. Let's fix the random other coding style changes in an
extra patch.
(patch u
On Fri, Apr 27, 2007 at 04:44:10PM +0200, Mondrian Nuessle wrote:
> Actually you do not need to set the index reg twice. I just used the
> code pattern from the Agami Aruma board, which does the same thing...
In that case, we should introduce functions like:
void w83xxx_ext_enter(void);
void w83x
Actually you do not need to set the index reg twice. I just used the
code pattern from the Agami Aruma board, which does the same thing...
Mondrian
Luc Verhaegen wrote:
> On Fri, Apr 27, 2007 at 01:01:19PM +0200, Mondrian Nuessle wrote:
>> The attached patch enables flashing on the Iwill DK8-HTX
On Fri, Apr 27, 2007 at 01:17:27PM +0200, Luc Verhaegen wrote:
> On Fri, Apr 27, 2007 at 01:01:19PM +0200, Mondrian Nuessle wrote:
> > The attached patch enables flashing on the Iwill DK8-HTX board.
> > Basically, it configures the SuperIO to set the right GPIO pins, so
> > write protection is disa
On Fri, Apr 27, 2007 at 01:01:19PM +0200, Mondrian Nuessle wrote:
> The attached patch enables flashing on the Iwill DK8-HTX board.
> Basically, it configures the SuperIO to set the right GPIO pins, so
> write protection is disabled.
>
> Signed-off-by: Mondrian Nuessle <[EMAIL PROTECTED]>
> ---
>
The attached patch enables flashing on the Iwill DK8-HTX board.
Basically, it configures the SuperIO to set the right GPIO pins, so
write protection is disabled.
Signed-off-by: Mondrian Nuessle <[EMAIL PROTECTED]>
---
Ok, this is the third try :-)
* I changed the name argument to "const char*" (
I just want to thank the author for the patch, and the folks who
chimed in for the helpful corrections :-)
we've needed this patch for a long time. Thanks again
ron
--
linuxbios mailing list
linuxbios@linuxbios.org
http://www.linuxbios.org/mailman/listinfo/linuxbios
On Thu, Apr 26, 2007 at 10:12:33PM +0200, Luc Verhaegen wrote:
> Also:
> > +{ 0x1022, 0x7468, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
> > + "iwill", "dk8_htx", "IWILL DK8-HTX", board_iwill_dk8htx },
>
> There is a hard strcmp in the linuxbios name matching. For the agami
> aruma, the lin
On Thu, Apr 26, 2007 at 06:24:06PM +0200, Mondrian Nuessle wrote:
> The attached patch enables flashing on the Iwill DK8-HTX board.
> Basically, it configures the SuperIO to set the right GPIO pins, so
> write protection is disabled.
>
> Signed-off-by: Mondrian Nuessle <[EMAIL PROTECTED]>
> ---
>
On Thu, Apr 26, 2007 at 06:24:06PM +0200, Mondrian Nuessle wrote:
> The attached patch enables flashing on the Iwill DK8-HTX board.
> Basically, it configures the SuperIO to set the right GPIO pins, so
> write protection is disabled.
>
> Signed-off-by: Mondrian Nuessle <[EMAIL PROTECTED]>
> ---
>
The attached patch enables flashing on the Iwill DK8-HTX board.
Basically, it configures the SuperIO to set the right GPIO pins, so
write protection is disabled.
Signed-off-by: Mondrian Nuessle <[EMAIL PROTECTED]>
---
So, this is the second try :-)
Only pci vendor id/device id is given, no subsys
Hi, All,
Sorry about that I made a mistake. These two devices (USB from NEC and
VGA from ATI) are not embedded in the mainboard. They are add-on card
plugged by us. Sorry about this confusing :)
01:05.0 USB Controller: NEC Corporation USB (rev 43) (prog-if 10 [OHCI])
Subsystem: NEC Corporat
On Thu, Apr 26, 2007 at 12:29:11AM +0200, Peter Stuge wrote:
>
> Do you have any experience from reading factory BIOS data structures
> found in RAM somewhere while working with the VIA boards?
Nope, no experience there. At the time people were telling me to read in
dmi from the driver. DMI is j
On Thu, Apr 26, 2007 at 12:17:27AM +0200, Luc Verhaegen wrote:
> On Thu, Apr 26, 2007 at 12:03:19AM +0200, Peter Stuge wrote:
> >
> > Unfortunately none of the subsystem devices on this board seem like
> > excellent picks for a unique board match (2b80 is listed as "AMD-8111
> > IDE [Quartet]" in
On Wed, Apr 25, 2007 at 06:09:08PM -0400, Ning (Michael) Qu wrote:
> Hi,
>
> It's a bad news :) The following is the result of lspci -vn, hope it
> could still help
>
> 00:07.0 0601: 1022:7468 (rev 05)
> Subsystem: 1022:2b80
>
> 00:07.1 0101: 1022:7469 (rev 03) (prog-if 8a)
> Sub
On Thu, Apr 26, 2007 at 12:03:19AM +0200, Peter Stuge wrote:
>
> Unfortunately none of the subsystem devices on this board seem like
> excellent picks for a unique board match (2b80 is listed as "AMD-8111
> IDE [Quartet]" in my pci.ids, but if forced I would pick LPC and USB:
>
> 0x1022, 0x7468,
Hi,
It's a bad news :) The following is the result of lspci -vn, hope it
could still help
00:07.0 0601: 1022:7468 (rev 05)
Subsystem: 1022:2b80
Flags: bus master, 66MHz, medium devsel, latency 0
00:07.1 0101: 1022:7469 (rev 03) (prog-if 8a)
Subsystem: 1022:2b80
Fl
Hi Ning,
On Wed, Apr 25, 2007 at 05:48:14PM -0400, Ning (Michael) Qu wrote:
> Hi, Peter,
>
> The following is the result from my machine, could you help me
> identify this machine, thanks very much!
Maybe. I should have remembered to ask for lspci -nv instead of just
-v, but let's see anyway. :)
On Wed, Apr 25, 2007 at 05:40:08PM -0400, Ning (Michael) Qu wrote:
> Hi,
>
> You are right, I just take a quick look at the source code of
> LinuxBIOS and I agree that name should not be needed. But I am just
> not sure about what subsystem id is? Is it the one in PCI
> configuration registers?
>
Hi, Peter,
The following is the result from my machine, could you help me
identify this machine, thanks very much!
00:06.0 PCI bridge: Advanced Micro Devices [AMD] AMD-8111 PCI (rev 07)
(prog-if 00 [Normal decode])
Flags: bus master, 66MHz, medium devsel, latency 64
Bus: primary=0
On Wed, Apr 25, 2007 at 05:40:08PM -0400, Ning (Michael) Qu wrote:
> You are right, I just take a quick look at the source code of
> LinuxBIOS and I agree that name should not be needed. But I am just
> not sure about what subsystem id is? Is it the one in PCI
> configuration registers?
Yep, it sh
Hi,
You are right, I just take a quick look at the source code of
LinuxBIOS and I agree that name should not be needed. But I am just
not sure about what subsystem id is? Is it the one in PCI
configuration registers?
Best,
Ning
On 4/25/07, Luc Verhaegen <[EMAIL PROTECTED]> wrote:
> On Wed, Apr 2
On Wed, Apr 25, 2007 at 11:27:21PM +0200, Luc Verhaegen wrote:
> There are two full sets of pci ids possible in that structure.
If all this talk about PCI IDs is too much please send lspci -v
output and we'll try to cobble something together. :)
Thanks!
//Peter
--
linuxbios mailing list
linux
On Wed, Apr 25, 2007 at 05:02:11PM -0400, Ning (Michael) Qu wrote:
> Hi, Peter,
>
> These are two things I did when I use this patch (however it works on my
> board):
>
> 1 add a option to the flashrom command line, such as:
> -m iwill:dk8_htx
> It seems that flashrom rely on some informatio
Hi, Peter,
These are two things I did when I use this patch (however it works on my board):
1 add a option to the flashrom command line, such as:
-m iwill:dk8_htx
It seems that flashrom rely on some information of LinuxBIOS in
CMOS, so before the first running of LinuxBIOS, there's nothing in
On Wed, Apr 25, 2007 at 04:33:25PM +0200, Mondrian Nuessle wrote:
> This patch should help those people that try to use flashrom on an
> iwill dk8_htx board, with or without biossavior, on factory BIOS or
> Linuxbios.
Cool, could one more person test it so we can commit it?
//Peter
--
linuxbio
The attached patch enables flashing on the Iwill DK8-HTX board.
Basically, it configures the SuperIO to set the right GPIO pins, so
write protection is disabled.
Signed-off-by: Mondrian Nuessle <[EMAIL PROTECTED]>
---
This patch should help those people that try to use flashrom on an iwill
dk8_ht
38 matches
Mail list logo
