Re: [LinuxBIOS] [PATCH] v3: Print a message before resetting the processor

2008-01-11 Thread Torsten Duwe
On Saturday 12 January 2008, Carl-Daniel Hailfinger wrote: > BIOS_EMERG is a bit strong because every cold boot will > trigger that code path by design. OTOH after the new PLL values the machine _is_ unusable unless reset, right? As I replied to Ron, this message should be prioritised as high as

Re: [LinuxBIOS] [PATCH] v3: Print a message before resetting the processor

2008-01-11 Thread Carl-Daniel Hailfinger
On 12.01.2008 01:58, Torsten Duwe wrote: > On Saturday 12 January 2008, Carl-Daniel Hailfinger wrote: > >> After configuring the PLL registers on Geode LX, we have to reset the >> processor. However, nothing in the log tells the user why the processor >> is being reset. >> > > >> +

Re: [LinuxBIOS] [PATCH] v3: Print a message before resetting the processor

2008-01-11 Thread Torsten Duwe
On Saturday 12 January 2008, ron minnich wrote: > Acked-by: Ronald G. Minnich <[EMAIL PROTECTED]> [BIOS_INFO vs. BIOS_EMERG] Think about it this way: whichever log level is set, the information that a repeating log is intentional should be there. Torsten -- linuxbios mailing list linu

Re: [LinuxBIOS] [PATCH] v3: Print a message before resetting the processor

2008-01-11 Thread Carl-Daniel Hailfinger
On 12.01.2008 01:53, ron minnich wrote: > Acked-by: Ronald G. Minnich <[EMAIL PROTECTED]> > Thanks, r553. Regards, Carl-Daniel -- linuxbios mailing list linuxbios@linuxbios.org http://www.linuxbios.org/mailman/listinfo/linuxbios

Re: [LinuxBIOS] [PATCH] v3: Print a message before resetting the processor

2008-01-11 Thread Torsten Duwe
On Saturday 12 January 2008, Carl-Daniel Hailfinger wrote: > After configuring the PLL registers on Geode LX, we have to reset the > processor. However, nothing in the log tells the user why the processor > is being reset. > + printk(BIOS_INFO, "Resetting the processor after PLL " > +

Re: [LinuxBIOS] [PATCH] v3: Print a message before resetting the processor

2008-01-11 Thread ron minnich
Acked-by: Ronald G. Minnich <[EMAIL PROTECTED]> -- linuxbios mailing list linuxbios@linuxbios.org http://www.linuxbios.org/mailman/listinfo/linuxbios

[LinuxBIOS] [PATCH] v3: Print a message before resetting the processor

2008-01-11 Thread Carl-Daniel Hailfinger
After configuring the PLL registers on Geode LX, we have to reset the processor. However, nothing in the log tells the user why the processor is being reset. Example log follows: LinuxBIOS-3.0.0 Fri Jan 11 15:53:52 MST 2008 starting... Choosing fallback boot. [...] Fallback failed. Try normal boot