Uwe Hermann wrote:
> On Fri, Nov 02, 2007 at 01:30:25PM -0400, Corey Osgood wrote:
>
>> Signed-off-by: Corey Osgood <[EMAIL PROTECTED]>
>>
>
>
>> according to micron), just in case. I've left the function in vt8237r
>> because there's no file that it would really fit into right now. If
>
On Fri, Nov 02, 2007 at 01:30:25PM -0400, Corey Osgood wrote:
> Signed-off-by: Corey Osgood <[EMAIL PROTECTED]>
> according to micron), just in case. I've left the function in vt8237r
> because there's no file that it would really fit into right now. If
> someone else wants/needs to use it in the
Russell Whitaker wrote:
>
>
> On Fri, 2 Nov 2007, Corey Osgood wrote:
>
>> Peter Stuge wrote:
>>> On Fri, Nov 02, 2007 at 01:30:25PM -0400, Corey Osgood wrote:
>>
+++ src/include/spd.h(working copy)
@@ -105,6 +105,7 @@
#define SPD_MEMORY_TYPE_SGRAM_DDR6
#define SPD
On Fri, 2 Nov 2007, Corey Osgood wrote:
> Peter Stuge wrote:
>> On Fri, Nov 02, 2007 at 01:30:25PM -0400, Corey Osgood wrote:
>
>>> +++ src/include/spd.h (working copy)
>>> @@ -105,6 +105,7 @@
>>> #define SPD_MEMORY_TYPE_SGRAM_DDR6
>>> #define SPD_MEMORY_TYPE_SDRAM_DDR7
>
Peter Stuge wrote:
> On Fri, Nov 02, 2007 at 01:30:25PM -0400, Corey Osgood wrote:
>
>> +void smbus_fixup(const struct mem_controller *ctrl)
>> +{
>> +int i, ram_slots, current_slot = 0;
>> +u8 result = 0;
>> +
>> +ram_slots = ARRAY_SIZE(ctrl->channel0);
>> +if (!ram_slots) {
>>
On Fri, Nov 02, 2007 at 01:30:25PM -0400, Corey Osgood wrote:
> +void smbus_fixup(const struct mem_controller *ctrl)
> +{
> + int i, ram_slots, current_slot = 0;
> + u8 result = 0;
> +
> + ram_slots = ARRAY_SIZE(ctrl->channel0);
> + if (!ram_slots) {
> + print_err("smbus
Updated patch attached.
Signed-off-by: Corey Osgood <[EMAIL PROTECTED]>
Comments inline below.
Uwe Hermann wrote:
> On Fri, Nov 02, 2007 at 12:39:16PM -0400, Corey Osgood wrote:
>
>>> Please explain the SPD_MEMORY_TYPE_SDRAM/SPD_MEMORY_TYPE_SDRAM_DDR2
>>> check in the comment here.
>>>
>>> If
* Uwe Hermann <[EMAIL PROTECTED]> [071102 18:08]:
> > That's fine. The i2c has 8 (actually 7) bits address space. spd might
> > not necessarily be behind the i2c bus. Or it might have a number of
> > switches. So you might have an address of 0xaabbccdd saying that aa, bb,
> > cc, dd are the setting
On Fri, Nov 02, 2007 at 12:39:16PM -0400, Corey Osgood wrote:
> >>/* Yes, this is a mess, but it's the easiest way to do it. */
> >> - while ((inb(SMBHSTSTAT) & 1) == 1 && loops <= SMBUS_TIMEOUT)
> >> + while ((inb(SMBHSTSTAT) & 1) == 1 && loops < SMBUS_TIMEOUT)
> >>
> >
> > Rationale? D
On Fri, Nov 02, 2007 at 05:44:03PM +0100, Stefan Reinauer wrote:
> > > -u8 smbus_read_byte(u32 dimm, u32 offset)
> > > +/**
> > > + * Read a byte from the smbus
> > > + *
> > > + * @param dimm The address location of the dimm on the smbus
> > > + * @param offset The offset the data is located at
>
* Corey Osgood <[EMAIL PROTECTED]> [071102 17:39]:
> >> +/**
> >> + * This is provided for compatibility, should it be needed
> >> + */
> >> +inline u8 spd_read_byte(u32 address, u8 offset)
> >> +{
> >> + return smbus_read_byte(address, offset);
> >> +}
>
> > Also, address is 32bit here but 8
* Uwe Hermann <[EMAIL PROTECTED]> [071102 16:56]:
> > loops = 0;
> > /* Yes, this is a mess, but it's the easiest way to do it. */
> > - while ((inb(SMBHSTSTAT) & 1) == 1 && loops <= SMBUS_TIMEOUT)
> > + while ((inb(SMBHSTSTAT) & 1) == 1 && loops < SMBUS_TIMEOUT)
>
> Rationale? Does it
Uwe Hermann wrote:
> On Fri, Nov 02, 2007 at 02:03:18AM -0400, Corey Osgood wrote:
>
>> @@ -79,11 +62,14 @@
>>
>> loops = 0;
>> /* Yes, this is a mess, but it's the easiest way to do it. */
>> -while ((inb(SMBHSTSTAT) & 1) == 1 && loops <= SMBUS_TIMEOUT)
>> +while ((inb(SMBHS
On Fri, Nov 02, 2007 at 02:03:18AM -0400, Corey Osgood wrote:
> @@ -79,11 +62,14 @@
>
> loops = 0;
> /* Yes, this is a mess, but it's the easiest way to do it. */
> - while ((inb(SMBHSTSTAT) & 1) == 1 && loops <= SMBUS_TIMEOUT)
> + while ((inb(SMBHSTSTAT) & 1) == 1 && loops <
Hi just a quick question,
Did you check with SVN version that it still needs warming up?
Thanks,
R.
--
linuxbios mailing list
linuxbios@linuxbios.org
http://www.linuxbios.org/mailman/listinfo/linuxbios
Corey Osgood wrote:
> This patch is some small changes to the vt8237r to prepare it for
> the Jetway J7F2 patch that should be coming soon, and also moves most
> defines into vt8237r.h. I've changed some of the values from u32 to u8,
> because that's all they should ever need to be. Also includes
>
This patch is some small changes to the vt8237r to prepare it for
the Jetway J7F2 patch that should be coming soon, and also moves most
defines into vt8237r.h. I've changed some of the values from u32 to u8,
because that's all they should ever need to be. Also includes
doxygenized comments!
Signed
17 matches
Mail list logo
