Re: [LinuxBIOS] [PATCH v3] v2, v3: Bug in CAR setup with CacheSize!={4k, 8k, 16k}

2007-11-30 Thread Carl-Daniel Hailfinger
On 30.11.2007 18:36, Marc Jones wrote: > > > Marc Jones wrote: >> >> yhlu wrote: >>> my own tree have >>> >>> #if CacheSize < 0x8000 >>> /* enable caching for 16K/8K/4K using fixed mtrr */ >>> movl$0x269, %ecx /* fix4k_cc000*/ >>> #if CacheSize == 0x4000 >>> movl

Re: [LinuxBIOS] [PATCH v3] v2, v3: Bug in CAR setup with CacheSize!={4k, 8k, 16k}

2007-11-30 Thread Marc Jones
Marc Jones wrote: > > yhlu wrote: >> my own tree have >> >> #if CacheSize < 0x8000 >> /* enable caching for 16K/8K/4K using fixed mtrr */ >> movl$0x269, %ecx /* fix4k_cc000*/ >> #if CacheSize == 0x4000 >> movl$0x06060606, %edx /* WB IO type */ >> #endif >

Re: [LinuxBIOS] [PATCH v3] v2, v3: Bug in CAR setup with CacheSize!={4k, 8k, 16k}

2007-11-30 Thread Marc Jones
yhlu wrote: > my own tree have > > #if CacheSize < 0x8000 > /* enable caching for 16K/8K/4K using fixed mtrr */ > movl$0x269, %ecx /* fix4k_cc000*/ > #if CacheSize == 0x4000 > movl$0x06060606, %edx /* WB IO type */ > #endif > #if CacheSize == 0x2000 >

Re: [LinuxBIOS] [PATCH v3] v2, v3: Bug in CAR setup with CacheSize!={4k, 8k, 16k}

2007-11-29 Thread yhlu
my own tree have #if CacheSize < 0x8000 /* enable caching for 16K/8K/4K using fixed mtrr */ movl$0x269, %ecx /* fix4k_cc000*/ #if CacheSize == 0x4000 movl$0x06060606, %edx /* WB IO type */ #endif #if CacheSize == 0x2000 movl$0x0606, %edx

Re: [LinuxBIOS] [PATCH v3] v2, v3: Bug in CAR setup with CacheSize!={4k, 8k, 16k}

2007-11-29 Thread Carl-Daniel Hailfinger
On 30.11.2007 01:19, Marc Jones wrote: > Carl-Daniel Hailfinger wrote: > >> On 29.11.2007 23:58, Marc Jones wrote: >> >>> Carl-Daniel Hailfinger wrote: >>> Everything is set up correctly until now. >>> /* enable caching for 16K/8K/4K using fixed mt

Re: [LinuxBIOS] [PATCH v3] v2, v3: Bug in CAR setup with CacheSize!={4k, 8k, 16k}

2007-11-29 Thread Carl-Daniel Hailfinger
On 30.11.2007 01:12, ron minnich wrote: > Has this been tested on hardware? CAR is black magic ;-) > I have no hardware capable of running LinuxBIOS (except a few OLPC machines with Geode GX, but they use a different CAR setup). Besides that, testing this code in v3 is rather difficult because

Re: [LinuxBIOS] [PATCH v3] v2, v3: Bug in CAR setup with CacheSize!={4k, 8k, 16k}

2007-11-29 Thread Marc Jones
Carl-Daniel Hailfinger wrote: > On 29.11.2007 23:58, Marc Jones wrote: >> Carl-Daniel Hailfinger wrote: >>> Everything is set up correctly until now. >>> >> /* enable caching for 16K/8K/4K using fixed mtrr */ >> movl$0x269, %ecx /* fix4k_cc000*/ >> #if CacheSize =

Re: [LinuxBIOS] [PATCH v3] v2, v3: Bug in CAR setup with CacheSize!={4k, 8k, 16k}

2007-11-29 Thread ron minnich
Has this been tested on hardware? CAR is black magic ;-) ron -- linuxbios mailing list linuxbios@linuxbios.org http://www.linuxbios.org/mailman/listinfo/linuxbios

[LinuxBIOS] [PATCH v3] v2, v3: Bug in CAR setup with CacheSize!={4k, 8k, 16k}

2007-11-29 Thread Carl-Daniel Hailfinger
On 29.11.2007 23:58, Marc Jones wrote: > Carl-Daniel Hailfinger wrote: >> Everything is set up correctly until now. >> > /* enable caching for 16K/8K/4K using fixed mtrr */ > movl$0x269, %ecx /* fix4k_cc000*/ > #if CacheSize == 0x4000 > movl$0x060606

Re: [LinuxBIOS] [PATCH v3] v2, v3: Bug? in CAR setup with CacheSize!={4k, 8k, 16k}

2007-11-29 Thread Marc Jones
Carl-Daniel Hailfinger wrote: > Everything is set up correctly until now. > /* enable caching for 16K/8K/4K using fixed mtrr */ movl$0x269, %ecx /* fix4k_cc000*/ #if CacheSize == 0x4000 movl$0x06060606, %edx /* WB IO type */ #endif

Re: [LinuxBIOS] [PATCH v3] v2, v3: Bug? in CAR setup with CacheSize!={4k, 8k, 16k}

2007-11-29 Thread Carl-Daniel Hailfinger
On 29.11.2007 00:50, Marc Jones wrote: > > Carl-Daniel Hailfinger wrote: >> On 28.11.2007 23:52, Marc Jones wrote: >>> >>> Carl-Daniel Hailfinger wrote: Marc? This has been sitting in my tree for a while now. On 16.11.2007 16:00, Carl-Daniel Hailfinger wrote: > Hi, > >>>

Re: [LinuxBIOS] [PATCH v3] v2, v3: Bug? in CAR setup with CacheSize!={4k, 8k, 16k}

2007-11-28 Thread Marc Jones
Carl-Daniel Hailfinger wrote: > On 28.11.2007 23:52, Marc Jones wrote: >> >> Carl-Daniel Hailfinger wrote: >>> Marc? >>> This has been sitting in my tree for a while now. >>> >>> On 16.11.2007 16:00, Carl-Daniel Hailfinger wrote: Hi, v2 and v3 have almost identical CAR setup code w

Re: [LinuxBIOS] [PATCH v3] v2, v3: Bug? in CAR setup with CacheSize!={4k, 8k, 16k}

2007-11-28 Thread Carl-Daniel Hailfinger
On 28.11.2007 23:52, Marc Jones wrote: > > > Carl-Daniel Hailfinger wrote: >> Marc? >> This has been sitting in my tree for a while now. >> >> On 16.11.2007 16:00, Carl-Daniel Hailfinger wrote: >>> Hi, >>> >>> v2 and v3 have almost identical CAR setup code with identical bugs for >>> CAR sizes != {

Re: [LinuxBIOS] [PATCH v3] v2, v3: Bug? in CAR setup with CacheSize!={4k, 8k, 16k}

2007-11-28 Thread Marc Jones
Carl-Daniel Hailfinger wrote: > Marc? > This has been sitting in my tree for a while now. > > On 16.11.2007 16:00, Carl-Daniel Hailfinger wrote: >> Hi, >> >> v2 and v3 have almost identical CAR setup code with identical bugs for >> CAR sizes != {4k,8k,16k}. In v3, the erroneous code paths are no

Re: [LinuxBIOS] [PATCH v3] v2, v3: Bug? in CAR setup with CacheSize!={4k, 8k, 16k}

2007-11-28 Thread Carl-Daniel Hailfinger
Marc? This has been sitting in my tree for a while now. On 16.11.2007 16:00, Carl-Daniel Hailfinger wrote: > Hi, > > v2 and v3 have almost identical CAR setup code with identical bugs for > CAR sizes != {4k,8k,16k}. In v3, the erroneous code paths are not > triggered and the bug is latent, but we

[LinuxBIOS] [PATCH v3] v2, v3: Bug? in CAR setup with CacheSize!={4k, 8k, 16k}

2007-11-17 Thread Carl-Daniel Hailfinger
Hi, v2 and v3 have almost identical CAR setup code with identical bugs for CAR sizes != {4k,8k,16k}. In v3, the erroneous code paths are not triggered and the bug is latent, but we have at a few boards in v2 which trigger these bugs, resulting in holes and/or smaller size of the CAR area. Let's l