Re: [PATCH] concat_dir_and_file() needs fixes

2005-12-02 Thread Leonard den Ottolander
Hi Jindrich, On Fri, 2005-12-02 at 19:11 +0100, Jindrich Novy wrote: > I thought that it would be less PITA to make concat_dir_and_file less > stupid than fixing the strings in edit.h: As Roland points out one should not concatenate 2 absolute paths. > /* File names */ > #define EDIT_DIR

Re: [PATCH] concat_dir_and_file() needs fixes

2005-12-02 Thread Jindrich Novy
Hello Roland, On Fri, 2005-12-02 at 15:58 +0100, Roland Illig wrote: > Jindrich Novy wrote: > > --- mc-4.6.1a/src/util.c.jn 2005-12-02 11:08:26.0 +0100 > > +++ mc-4.6.1a/src/util.c2005-12-02 13:11:19.0 +0100 > > @@ -1515,9 +1515,16 @@ > > > > /* If filename is NULL, then we

Re: [PATCH] PHP syntax highlighting broken

2005-12-02 Thread Leonard den Ottolander
Hello Roland, Jindrich, On Fri, 2005-12-02 at 15:38 +0100, Roland Illig wrote: > > Error in file /usr/share/mc//syntax/php.syntax on line 4367 > > and file is edited without any highlighting. Patch is attached. > > Committed, Thanks. Thanks for committing. I should actually have tested that file

Re: [PATCH] concat_dir_and_file() needs fixes

2005-12-02 Thread Roland Illig
Jindrich Novy wrote: --- mc-4.6.1a/src/util.c.jn 2005-12-02 11:08:26.0 +0100 +++ mc-4.6.1a/src/util.c2005-12-02 13:11:19.0 +0100 @@ -1515,9 +1515,16 @@ /* If filename is NULL, then we just append PATH_SEP to the dir */ char * -concat_dir_and_file (const char *dir,

Re: [PATCH] PHP syntax highlighting broken

2005-12-02 Thread Roland Illig
Jindrich Novy wrote: Hello mc-devel, the php.syntax file is broken due to bad highlighting definition of LOG_LOCAL[0-7] symbols. To reproduce: F4 on any .php file. Results: Error in file /usr/share/mc//syntax/php.syntax on line 4367 and file is edited without any highlighting. Patch is atta

[PATCH] concat_dir_and_file() needs fixes

2005-12-02 Thread Jindrich Novy
Hello mc-devel, 1) There's a bug in concat_dir_and_file(). If you try to reproduce the PHP syntax highlighting problem in: http://mail.gnome.org/archives/mc-devel/2005-December/msg0.html then you'll get this message in the "Load syntax file" error dialog: Error in file /usr/share/mc//syntax/

[PATCH] PHP syntax highlighting broken

2005-12-02 Thread Jindrich Novy
Hello mc-devel, the php.syntax file is broken due to bad highlighting definition of LOG_LOCAL[0-7] symbols. To reproduce: F4 on any .php file. Results: Error in file /usr/share/mc//syntax/php.syntax on line 4367 and file is edited without any highlighting. Patch is attached. Jindrich -- Jind