Re: [PATCH] Manpage fixes

2016-02-10 Thread Denys Vlasenko
On Wed, Feb 10, 2016 at 9:01 PM, Yury V. Zaytsev wrote: > On Wed, 2016-02-10 at 17:29 +0100, Denys Vlasenko wrote: >> >> Fixed a number of places with bad English. > > Hi Denys, > > Could you please re-send the patch as an attachment? Your mail client > has corrupted

[PATCH] Manpage fixes

2016-02-10 Thread Denys Vlasenko
sentitive -> sensitive cusor -> cursor toglle-> toggle "the the" -> the Fixed a number of places with bad English. Signed-off-by: Denys Vlasenko --- doc/man/mc.1.in | 9 +++--- doc/man/mcedit.1.in | 93 +---

Re: [PATCH] isofs fix: do not skip all .dotfiles

2015-10-15 Thread Denys Vlasenko
On Thu, Oct 15, 2015 at 7:23 PM, Yury V. Zaytsev wrote: > On Thu, 2015-10-15 at 18:56 +0200, Denys Vlasenko wrote: >> There appears to be an easy bug in iso9660 helper: > > Hi Denys, > > Could you please be so kind as to make a ticket and attach the patches > for both cha

[PATCH] isofs fix: do not skip all .dotfiles

2015-10-15 Thread Denys Vlasenko
There appears to be an easy bug in iso9660 helper: if (name ~ /^\.\.?/) next means "skip all lines which start with one or two dots". Author probably meant: if (name ~ /^\.\.?$/) next I propose to not be cryptic and just check both possibilities separately. The below trivial patch was tested to

"(smbfs_fake_share_stat): don't access to free'd memory" wasn't needed

2013-07-10 Thread Denys Vlasenko
-vfs_path_t *vpath = vfs_path_from_str (path); +vfs_path_t *vpath; +vpath = vfs_path_from_str (path); p = smbfs_get_path (&sc, vpath); vfs_path_free (vpath); -g_free (p); -if (p) +if (p != NULL) { memset (buf,

Re: inconvinient things in midnight commander.

2013-03-28 Thread Denys Vlasenko
On Sat, Mar 9, 2013 at 10:11 PM, 5l0|Z wrote: > > I started using mc recently, and I'm already in love with it, as a > programmer. > But there's just a couple of thnings, that kinda slowing me down, mainly: > > 1- How can I run something in the background, (say an flv) by a-highlighting > it b-F2

Re: [PATCH 5/5 v2] keyboard input: when an unknown sequence is seen, purge all buffered input

2013-03-28 Thread Denys Vlasenko
On Wed, Feb 20, 2013 at 12:20 PM, Denys Vlasenko wrote: > On Mon, Feb 4, 2013 at 12:54 PM, Slava Zanko wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> 31.01.2013 19:27, Oswald Buddenhagen wrote: >>> the mc devs are rather insistent on their

Re: [PATCH 5/5 v2] keyboard input: when an unknown sequence is seen, purge all buffered input

2013-02-20 Thread Denys Vlasenko
On Mon, Feb 4, 2013 at 12:54 PM, Slava Zanko wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > 31.01.2013 19:27, Oswald Buddenhagen wrote: > >> the mc devs are rather insistent on their process and often simply >> ignore contributions on the list, so you may get a better response >> whe

[PATCH] Fix code which depends on signed overflow in C (which isn't defined in C)

2013-02-19 Thread Denys Vlasenko
This is the fix for https://github.com/MidnightCommander/mc/issues/11 signed_overflow_fix.patch Description: Binary data ___ mc-devel mailing list https://mail.gnome.org/mailman/listinfo/mc-devel

Re: [PATCH 5/5 v2] keyboard input: when an unknown sequence is seen, purge all buffered input

2013-01-31 Thread Denys Vlasenko
Ping... On Thu, Oct 25, 2012 at 4:45 PM, Denys Vlasenko wrote: > When we see an unknown sequence, it is not enough > to drop already received part - there can be more of it > coming over e.g. a serial line. > > To prevent interpreting it as a random garbage, > eat and disc

Re: [PATCH 5/5] keyboard input: when an unknown sequence is seen, purge all buffered input

2012-10-25 Thread Denys Vlasenko
On Wed, Oct 24, 2012 at 9:54 AM, Oswald Buddenhagen wrote: > On Mon, Oct 22, 2012 at 04:49:45PM +0200, Denys Vlasenko wrote: >> 50 milliseconds seem to work well. > > why don't you use the existing timeout? it exists exactly for this > purpose. Good idea, I just sent a

[PATCH 5/5 v2] keyboard input: when an unknown sequence is seen, purge all buffered input

2012-10-25 Thread Denys Vlasenko
up by a serial line. Before this change, Ctrl-Alt-Shift-Right_Arrow generates "1;8C" bogus "input" in MC on my machine; after the change, nothing is generated. Signed-off-by: Denys Vlasenko --- lib/tty/key.c | 21 - 1 files changed, 16 insertions(+),

[PATCH 5/5] keyboard input: when an unknown sequence is seen, purge all buffered input

2012-10-22 Thread Denys Vlasenko
up by a serial line. 50 milliseconds seem to work well. Before this change, Ctrl-Alt-Shift-Right_Arrow generates "1;8C" bogus "input" in MC on my machine; after the change, nothing is generated. Signed-off-by: Denys Vlasenko --- lib/tty/key.c | 22 +-

[PATCH 2/5] keyboard input: add commented-out debugging logging mechanism.

2012-10-22 Thread Denys Vlasenko
, disabled via "#if 0". Signed-off-by: Denys Vlasenko --- lib/tty/key.c | 55 +++ 1 files changed, 55 insertions(+), 0 deletions(-) diff --git a/lib/tty/key.c b/lib/tty/key.c index d2142fa..33732db 100644 --- a/lib/tty/key.c +++ b/lib

[PATCH 3/5] keyboard input: remove unreachable code

2012-10-22 Thread Denys Vlasenko
GET_TIME (esctime); can't be true> if (this == NULL) This patch removes that if(). Signed-off-by: Denys Vlasenko --- lib/tty/key.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/lib/tty/key.c b/lib/tty/key.c index 33732db..77185ce 10064

[PATCH 4/5] keyboard input: treat only ESC or as valid

2012-10-22 Thread Denys Vlasenko
this patch, no bogus "input" is generated. Longer unknown sequences need an additional fix, coming next. Signed-off-by: Denys Vlasenko --- lib/tty/key.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/lib/tty/key.c b/lib/tty/key.c index 77185ce..9b97a

[PATCH 1/5] keyboard input: simplify code, no logic changes

2012-10-22 Thread Denys Vlasenko
This change slightly simplifies and rearranges the code in get_key_code(), reduces indentation levels there, adds a few comments. The logic remains the same. This is a preparatory patch for subsequent changes. Signed-off-by: Denys Vlasenko --- lib/tty/key.c | 126

[PATCH 0/5] keyboard input: stop generating garbage input from unknown ESC sequences

2012-10-22 Thread Denys Vlasenko
I got tired of seeing garbage when I press function key MC doesn't know. This changeset attempts to eradicate this problem. Denys Vlasenko (5): keyboard input: simplify code, no logic changes keyboard input: add commented-out debugging logging mechanism. keyboard input: remove unreac

[PATCH] do not link cons.saver with libglib

2010-06-04 Thread Denys Vlasenko
Hi, Fedora build machinery noticed that cons.saver acquired a new library in ldd listing, libglib. I took a look at it and apparently it is not needed. With the attached trivial patch I successfully built mc where cons.saver no longer uses libglib: # ldd cons.saver linux-vdso.so.1 => (

Re: [PATCH] do not abort on broken .cpio file

2009-11-01 Thread Denys Vlasenko
On Sunday 01 November 2009 11:59, Yury V. Zaytsev wrote: > On Sun, 2009-11-01 at 03:02 +0100, Denys Vlasenko wrote: > > > This wastes your time. Maybe it makes sense to allow > > trivial fixes to be applied without going through > > this process? > > What are you

Home / End in viewer does not work in recent git

2009-10-31 Thread Denys Vlasenko
I did last "git pull". "git log" shows this: commit ae3a0a85f7d3ae36d3beab75743e9ec7c3a3 Merge: c96af78 f3f975e Author: Denys Vlasenko Date: Mon Oct 26 01:01:25 2009 +0100 Merge branch 'master' of git://midnight-commander.org/git/mc commit f3f975ec16a

Re: [PATCH] do not abort on broken .cpio file

2009-10-31 Thread Denys Vlasenko
On Thursday 15 October 2009 16:21, Denys Vlasenko wrote: > For some reason, mc aborts if .cpio magic as wrong. > > This trivial patch makes mc handle it gracefully. > > Please apply. This is now fixed, thanks! I am a bit surprised that for such a trivial fix, you guys went to

[PATCH] do not abort on broken .cpio file

2009-10-15 Thread Denys Vlasenko
For some reason, mc aborts if .cpio magic as wrong. This trivial patch makes mc handle it gracefully. Please apply. -- vda fix_abort_on_cpio.patch Description: Binary data ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel

Re: Flickering appeared in recent git

2009-09-03 Thread Denys Vlasenko
On Wed, Aug 19, 2009 at 8:23 PM, Patrick Winnertz wrote: > Am Wed, 19 Aug 2009 19:37:49 +0200 > schrieb Denys Vlasenko : > >> Hi, >> >> I rebuilt mc from newer git (two days ago) and I see >> a somewhat subtle effect. >> >> On screen updates, mc now &q

Re: [PATCH] trivial: de-inline large functions

2009-08-30 Thread Denys Vlasenko
On Sunday 30 August 2009 20:55, Sergei Trofimovich wrote: > On Sun, 30 Aug 2009 16:40:20 +0200 > Denys Vlasenko wrote: > > > Hi Slava, folks, > > > > The attached patch de-inlines a few functions > > which are large, or not-so-large but nevertheless > &

[PATCH] trivial: de-inline large functions

2009-08-30 Thread Denys Vlasenko
Hi Slava, folks, The attached patch de-inlines a few functions which are large, or not-so-large but nevertheless contain more than one function call, or contain loops, or contain if's and at least one function call, or contain largish objects on stack. In my experience, in those cases the code si

Flickering appeared in recent git

2009-08-19 Thread Denys Vlasenko
Hi, I rebuilt mc from newer git (two days ago) and I see a somewhat subtle effect. On screen updates, mc now "flickers". The simplest way to see it is to open a large xterm window with mc file view (it is less noticeable on text consoles), press and hold Ctrl-R (refresh). In mc built from git a

Re: mc

2009-07-19 Thread Denys Vlasenko
On Wednesday 15 July 2009 21:02, Ilia Maslakov wrote: > > --enable-charset ? ведь ради нее практически все затевалось :) > > > > > Откуда linux-from-scratch пользователь знает, что > > configure --enable-charset есть хорошо? > > > > Он просто скачал .tar.gz и запустил configure. > > Ну давно хотим

Today's git seems to be broken

2009-07-10 Thread Denys Vlasenko
I simply run: ./autogen.sh ./configure make and it ends with gcc -std=gnu99 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I.. -g -O2 -Wall -o mc achown.o background.o boxes.o chmod.o chown.o cmd.o color.o command.o complete.o cons.handler.o dialog.o dir.o execute.o ext.o file.o filegui.

[BUG] memory leak in src/file.c::copy_dir_dir()

2009-07-02 Thread Denys Vlasenko
Hi, Noticed this memory leak while working on another problem. Watch variable d: char *d; /* First get the mode of the source dir */ retry_src_stat: if ((*ctx->stat_func) (s, &cbuf)) { return_status = file_error (_(" Cannot stat source directory \"%s\" \n %s "),

[PATCH] wire up visible_{tabs, tws} in editor's config dialog (fix bug 1384)

2009-07-01 Thread Denys Vlasenko
s it, and also it makes _trailing_ tabs to show up as tabs if visible_tabs = 0 but visible_tws = 1. Please apply. 7.patch is follow-up whitespace and formatting cleanup, no code changes. Apply it if it looks ok to you. It does not relate to the fix per se, just catering to my perfectionist itch. Sig

Re: My experience with current'ish git

2009-06-29 Thread Denys Vlasenko
On Monday 29 June 2009 17:20, Slava Zanko wrote: > Denys Vlasenko wrote: > > Caring for users' bug reports and bugs in bugzilla is not a very > > inspiring work, but if you do it regularly, you are taking > > an "invisible" advantage of the work users already di

My experience with current'ish git

2009-06-29 Thread Denys Vlasenko
Hi Slava, all, I am happy to see that your development efforts on MC did not remain just good intentions. Now you face a har part: how to make your project successful. I will try to help, at least by reporting bugs. Currently, I have 5 bugs reported total. One is already fixed: #411make loo

[PATCH] trivial optimization in file.c::panel_operate()

2009-06-17 Thread Denys Vlasenko
Hi Slava, I noticed an incorrectly indented if() in file.c::panel_operate(). Took a better look, and found out it can be tweaked in several ways. This patch is the result. It contains the following trivial optimizations: * merged two identical "dest_dir_ = g_strdup (dest_dir)" ops. * simplified

Re: Further Midnight Commander development

2009-02-16 Thread Denys Vlasenko
On Monday 16 February 2009 20:17, Pavel Tsekov wrote: > So you want to bitch... I really cannot help you with that. How much did I bitch in these years while the patch was lying around? URL please. In case you did not notice, I want to code. I want to help MC to improve and sligtly more than glac

Re: Re[2]: Further Midnight Commander development

2009-02-16 Thread Denys Vlasenko
On Mon, Feb 16, 2009 at 3:02 PM, Pavel Tsekov wrote: > Hello Denys, > > Monday, February 16, 2009, 3:15:45 PM, you wrote: > >> On Fri, Feb 13, 2009 at 7:20 PM, Pavel Tsekov wrote: >>> You might not be aware but I am (still) one of the two official MC >>> maintainers. > >> De jure, maybe you are.

Re: Further Midnight Commander development

2009-02-16 Thread Denys Vlasenko
On Fri, Feb 13, 2009 at 7:20 PM, Pavel Tsekov wrote: > You might not be aware but I am (still) one of the two official MC > maintainers. De jure, maybe you are. De facto, the project is an orphan. How many more times do I need to submit my patches to get your attention? How many millennia do we

Re: Further Midnight Commander development

2008-12-23 Thread Denys Vlasenko
2008/12/23 Patrick Winnertz : > Am Monday 22 December 2008 21:02:21 schrieben Sie: >> Patrick Winnertz wrote: >> > If yes I'll set up a trac on my private server until I find a better >> > solution. If this repro is ready I'll ping you and we can start to >> > migrate you patches into the git repro

Re: Resolving symlinked dirs when execing command

2007-10-11 Thread Denys Vlasenko
Hi Pavel, On Thursday 11 October 2007 14:40, Pavel Tsekov wrote: > > $ pwd > > /auto/software > > > > It differs from what happens under e.g. shell: > > > > sh-3.1$ cd /software > > sh-3.1$ pwd > > /software > > > > Why mc resolves dir and cd'es into it before it forks a child? > > I am not ab

Re: GNU Midnight Commander 4.6.2-pre1

2007-09-29 Thread Denys Vlasenko
On Thursday 13 September 2007 09:30, Pavel Tsekov wrote: > Hello, > > I've prepared the fist pre-release of GNU Midnight Commander 4.6.2 . Please, > download it and give it a try. I found the following issues: Alt-O behavior changes for the worse: 4.6.1: make inactive panel show the same dir

Re: GNU Midnight Commander 4.6.2-pre1

2007-09-29 Thread Denys Vlasenko
On Saturday 29 September 2007 10:50, Oswald Buddenhagen wrote: > On Sat, Sep 29, 2007 at 01:02:12AM -0500, [EMAIL PROTECTED] wrote: > > Yes, interesting indeed. > > Is this documented anywhere? > > no, as it is more a bug that happens to turn out positive. :) > i guess anybody who uses selection in

Resolving symlinked dirs when execing command

2007-09-28 Thread Denys Vlasenko
Hi Pavel, [I hope to find time and test release candidate this weekend] One thing which may be simple to fix: On my machine I have: $ ls -l /software lrwxrwxrwx1 root root 14 Jun 26 12:23 /software -> /auto/software If I cd into /software while I am in mc, and then I run any

Re: Getting ready for a release

2007-09-14 Thread Denys Vlasenko
On Tuesday 04 September 2007 09:57, Pavel Tsekov wrote: > Hello, > > As it has been discussed on the mailing list a new release of MC is long > overdue. So... I plan to release a new version of MC by mid October. This > gives us about a month (till the end of September) for final testing, bug >

Re: Getting ready for a release

2007-09-04 Thread Denys Vlasenko
On Tuesday 04 September 2007 09:57, Pavel Tsekov wrote: > Hello, > > As it has been discussed on the mailing list a new release of MC is long > overdue. So... I plan to release a new version of MC by mid October. This gives us about a month (till the end of September) for final testing, bug rep

Re: Getting ready for a release

2007-09-04 Thread Denys Vlasenko
On Tuesday 04 September 2007 10:18, Oswald Buddenhagen wrote: > On Tue, Sep 04, 2007 at 10:57:42AM +0200, Pavel Tsekov wrote: > > how are we going to number the new release ? > > > 4.7. no exaggerated humbleness, please. 4.7.0. Fixes can go to stable 4.7.x, big changes to eventual 4.8.0... -- vd