Re: extfs cleanup

2002-12-07 Thread Pavel Roskin
Hello! > Hi. I've spend some more time examining and testing extfs scripts, > because I feel a lot more confortable with simple scripts than with > complicated mc code :) I understand. It's good approach to learn mc by doing simple things first. > My results can be found in the attachment. If y

Re: extfs cleanup

2002-12-07 Thread Adam Byrtek 'alpha'
Hi. I've spend some more time examining and testing extfs scripts, because I feel a lot more confortable with simple scripts than with complicated mc code :) My results can be found in the attachment. If you have any comments, feel free to mail me. I'll try to update this list when something gets

Re: [PATCH] Re: extfs cleanup

2002-12-06 Thread Pavel Roskin
On Sat, 7 Dec 2002, Adam Byrtek 'alpha' wrote: > On Fri, Dec 06, 2002 at 01:11:40AM -0500, Pavel Roskin wrote: > > I believe the reason is because extfs_open() issues "copyout" even > > when the file is opened with O_TRUNC. This should be easy to fix. > > I'm have added a FIXME to the source. > >

[PATCH] Re: extfs cleanup

2002-12-06 Thread Adam Byrtek 'alpha'
On Fri, Dec 06, 2002 at 01:11:40AM -0500, Pavel Roskin wrote: > I believe the reason is because extfs_open() issues "copyout" even when > the file is opened with O_TRUNC. This should be easy to fix. I'm have > added a FIXME to the source. Fixed. Patch attached. -- _.|._ |_ _.: Adam B

Re: extfs cleanup

2002-12-06 Thread Adam Byrtek 'alpha'
First of all I would like to note, that this is my first contribution to mc, so I don't know 'how things work' in mc too much. > release of the next stable version. I believe the redirection of output > should be done in the extfs code, not in the scripts. That's something Of course - this is

Re: extfs cleanup

2002-12-05 Thread Pavel Roskin
Hello! > When using mc I've noticed, that extfs' often clutter the screen a lot > and are generaly not too reliable. Yes, writing garbage to the screen is a big problem and it has delayed the release of the next stable version. I believe the redirection of output should be done in the extfs code

extfs cleanup

2002-12-05 Thread Adam Byrtek 'alpha'
Hello. When using mc I've noticed, that extfs' often clutter the screen a lot and are generaly not too reliable. I decided to look into their shell code, and mostly they are quite messy - they don't detect if binaries they use exist in the system, they don't provide error handling etc. I decided