Re: mod_sflow

2011-01-09 Thread Neil McKee
Great feedback, thanks. I have several questions, if you don't mind... 1. What is the most portable way to make the pipe non-blocking? That way we can just drop any samples that get EWOULDBLOCK or EAGAIN on writing to the pipe (and increment the drops counter).apr_file_pipe_create_ex(..

Re: mod_sflow

2011-01-09 Thread Ben Noordhuis
On Sat, Jan 8, 2011 at 00:06, Neil McKee wrote: > This module is designed to work in both "prefork" and "worker" models.  I > would really > appreciate it if someone could review the design to make sure I made > appropriate choices > about where to use pipes, shared-memory, mutex locking,  and s