Re: Number of worker processes on hyperthreaded processor

2012-11-19 Thread Eric Wong
Andrew Stewart wrote: > Good morning, > > The tuning page says worker_processes should be at least the number of > CPU cores on a dedicated server. In the case of hyper-threading, > should this be the number of cores or the number of threads? > > For example the Intel Core i7-2600 Quadcore[1] h

Re: .manifest file?

2012-11-13 Thread Eric Wong
mike wrote: > Just switched form a zip download to pulling the master branch of git. > The .gemspec file is trying to parse a .manifest. Was this supposed to > be included or generated? I am just poking around about it now. It should be autogenerated with "make gem" (wrongdoc (a dev-dependency)

Re: Testing Unicorn on Rubinius

2012-11-13 Thread Eric Wong
mike wrote: > I was able to (I think) get the test suite running using bundler. It > fails right now with a few different error but I am pushing through. > Thanks a ton for your time and responding so quickly. Also for > pointing out the RUBYOPT thing. Cool, in case you do hit errors, I just push

[PATCH] tests: remove assert_nothing_raised (part 2)

2012-11-13 Thread Eric Wong
pid2(pid) } +pid, status = Process.waitpid2(pid) assert status.success? end diff --git a/test/unit/test_tee_input.rb b/test/unit/test_tee_input.rb index 96eb268..0c2c941 100644 --- a/test/unit/test_tee_input.rb +++ b/test/unit/test_tee_input.rb @@ -40,13 +40,13 @@ class TestTeeInput <

Re: Testing Unicorn on Rubinius

2012-11-12 Thread Eric Wong
mike wrote: > If I run irb, I cannot require 'isolate' without requiring 'rubygems' > even with it in all these places. Maybe using RUBYOPT=-rubygems will help (assuming Rubinius behaves like MRI 1.8 wrt rubygems). ___ Unicorn mailing list - mongrel-uni

Re: Testing Unicorn on Rubinius

2012-11-12 Thread Eric Wong
mike wrote: > Hey Eric, > > I do have the isolate gem installed. In a number of gemsets as it > were. Here is a gem list: > > mike@sm-mike-thinkpad:~/workspace/rubinius_testing/unicorn-4.4.0$ gem list > > *** LOCAL GEMS *** > > bundler (1.2.1) > isolate (3.2.2) > rack (1.4.1) > rake (0.9.2.2)

Re: Testing Unicorn on Rubinius

2012-11-12 Thread Eric Wong
mike wrote: > (or at least trying very valiantly). At them moment I am having > trouble getting my environment set up in such a way, as to run the: > > make -j4 test > > command. I am having issues resolving my environment and load paths > against what the unicorn project is looking for. I was c

Re: select(): Interrupted system call from curb when stopping unicorn

2012-11-07 Thread Eric Wong
Graham Bleach wrote: > Hi, > > We've just migrated one of our rails applications from nginx/passenger > running on REE 1.8.7 Ubuntu 8.04 to unicorn running on MRI 1.9.3 on > Ubuntu 10.04. The app makes a number of calls to internal services > using curb. > > Our deployment script stops unicorn b

Re: Combating nginx 499 HTTP responses during flash traffic scenario

2012-11-06 Thread Eric Wong
Tom Burns wrote: > On Mon, Nov 5, 2012 at 6:48 AM, Eric Wong wrote: > > We can wait until you can report on how this change improves your > > situation before fleshing this out. Real-world results are always > > good to have :> > > Agreed. > > We'r

Re: Combating nginx 499 HTTP responses during flash traffic scenario

2012-11-05 Thread Eric Wong
Tom Burns wrote: > On Fri, Nov 2, 2012 at 3:38 PM, Eric Wong wrote: > > Everything looks good for stock configurations. The ERROR_XXX_RESPONSE > > constants should have "HTTP/1.1 " removed if used with this option, too. > > That requires keeping track of w

Re: Combating nginx 499 HTTP responses during flash traffic scenario

2012-11-02 Thread Eric Wong
Tom Burns wrote: > On Tue, Oct 30, 2012 at 5:37 PM, Eric Wong wrote: > > Tom Burns wrote: > > > We'd prefer to not have to fork unicorn for this change. How do you > > > feel about merging this or a derivative thereof? I can develop this > > > f

Re: Combating nginx 499 HTTP responses during flash traffic scenario

2012-10-30 Thread Eric Wong
Tom Burns wrote: > On Mon, Oct 29, 2012 at 5:53 PM, Eric Wong wrote: > > Maybe this gross hack can work for you guys. It writes the first > > chunk of the HTTP response header out immediately after reading > > the request headers, and sends the rest once it gets the status

Re: Combating nginx 499 HTTP responses during flash traffic scenario

2012-10-29 Thread Eric Wong
Eric Wong wrote: > Tom Burns wrote: > > We're looking at potential solutions to this problem, including: > > - modifying unicorn to select() on the client connection after reading > > the request, to see if it's been closed upstream, and avoid calling > > th

Re: Combating nginx 499 HTTP responses during flash traffic scenario

2012-10-29 Thread Eric Wong
Hongli Lai wrote: > On Mon, Oct 29, 2012 at 7:45 PM, Eric Wong wrote: > >> Any input would be appreciated. > > > > I'd love to hear back on how you eventually solve this, too :> > > Does haproxy support removing clients from the queue like this? I'm n

Re: Combating nginx 499 HTTP responses during flash traffic scenario

2012-10-29 Thread Eric Wong
Tom Burns wrote: > We're looking at potential solutions to this problem, including: > - modifying unicorn to select() on the client connection after reading > the request, to see if it's been closed upstream, and avoid calling > the app. You should be able to get the socket out of Unicorn::TeeInp

Re: Rack env rack.multiprocess true with single worker

2012-10-18 Thread Eric Wong
Petteri Räty wrote: > On 18.10.2012 10.53, Eric Wong wrote: > > > > Since a single process deployment is a corner-case in production > > deployments, I don't think it's worth the effort to jump through hoops > > and set rack.multiprocess=false automaticall

Re: [PATCH] explicitly use escaped minus in man pages

2012-10-18 Thread Eric Wong
Hleb Valoshka <375...@gmail.com> wrote: > On 10/15/12, Eric Wong wrote: > > All the manpages are generated with pandoc. Can you send a patch > > for the Markdown files in Documentation/*.1.txt instead? Thanks > > in advance. > > I'll try but I'm not s

Re: Rack env rack.multiprocess true with single worker

2012-10-18 Thread Eric Wong
Petteri Räty wrote: > Hi, > unicorn unconditionally sets rack.multiprocess to true in the Rack > environment. The Rack spec [0] says the following about the variable: > > "true if an equivalent application object may be simultaneously invoked > by another process, false otherwise." > > When unic

Re: [PATCH] explicitly use escaped minus in man pages

2012-10-15 Thread Eric Wong
Hleb Valoshka <375...@gmail.com> wrote: Hi, the commit message body needs to include the reasoning behind this change. Something along the lines of your second email would be good. ref: mid.gmane.org/caab-kckmf0akgscbcr0y7w7rxwipjw5_v700bec3dtuqnfe...@mail.gmail.com > --- > man/man1/unicorn.1

[ANN] unicorn 4.4.0 - minor updates

2012-10-11 Thread Eric Wong
.org * git://bogomips.org/unicorn.git * http://unicorn.bogomips.org/NEWS.atom.xml -- Eric Wong ___ Unicorn mailing list - mongrel-unicorn@rubyforge.org http://rubyforge.org/mailman/listinfo/mongrel-unicorn Do not quote signatures (like this one) or top

Re: Is a client uploading a file a slow client from unicorn's point of view?

2012-10-09 Thread Eric Wong
Laas Toom wrote: > On 09.10.2012, at 23:03, Eric Wong wrote: > > Laas Toom wrote: > >> Afterwards it will only handle out the file location and Rails can > >> complete it's work a lot faster, freeing up workers. > >> > >> Unicorn won'

Re: Is a client uploading a file a slow client from unicorn's point of view?

2012-10-09 Thread Eric Wong
Laas Toom wrote: > On 09.10.2012, at 4:58, Eric Wong wrote: > > I'm not familiar with the nginx upload module, but stock nginx will > > already do full request buffering for you. It looks like the nginx > > upload module[1] is mostly meant for standalone apps written f

Re: Is a client uploading a file a slow client from unicorn's point of view?

2012-10-08 Thread Eric Wong
Jimmy Soho wrote: > Hi All, > > I was wondering what would happen when large files were uploaded to > our system in parallel to endpoints that don't process file uploads. > In particular I was wondering if we're vulnerable to a simple DoS > attack. nginx will protect you by buffering large reque

Re: [PATCH] chowning /dev/null should be guarded against

2012-10-01 Thread Eric Wong
Joel Meador wrote: > Eric Wong wrote: > >--- a/lib/unicorn/util.rb > >+++ b/lib/unicorn/util.rb > >@@ -7,6 +7,7 @@ def self.is_log?(fp) > > append_flags = File::WRONLY | File::APPEND > > > > ! fp.closed?&& > >+ fp.stat.fi

Re: [PATCH] chowning /dev/null should be guarded against

2012-10-01 Thread Eric Wong
Joel Meador wrote: > We've run into this problem several times and it's not really > expected that someone is going to monkey with /dev/null. So here's a > simple patch. > I am not on the mailing list, so please Cc: me. Interesting nobody found this bug earlier (I think pointing logs to /dev/null

Re: after_fork and redis

2012-10-01 Thread Eric Wong
bradford wrote: > I'm using unicorn w/ a rails app. I have the following in my > environment.rb $redis = MyApplication::Application.config.redis and in > production.rb I have config.redis = Redis.new(host: "localhost"). > > I've read I'm supposed to $redis = Redis.new(host: "localhost") in > aft

Re: executing code when unicorn worker is SIGKILLed

2012-09-26 Thread Eric Wong
Martin Sarsale wrote: > Dear all: > > I would like to execute some code when the Unicorn worker is killed > with SIGKILL (ie, incrementing a counter in graphite), what's the > "nice" way to do this? > > E, [2012-09-26T17:51:47.776065 #28499] ERROR -- : worker=4 PID:28520 > timeout (61s > 60s), k

Re: after_fork - ActiveRecord::AdapterNotSpecified

2012-08-31 Thread Eric Wong
Frank Rennekamp wrote: > Hi all, > > I'm fighting with the after_fork hook and my sinatra application. The Sinatra > app is using active_record, > In my unciron.rb file I'm using > preload_app true > I get the same error, when using different database adapter. On the > other hand everything

Re: Unused Unicorn processes

2012-08-21 Thread Eric Wong
Konstantin Gredeskoul wrote: > Greetings! > > I have a question on optimal # of unicorn worker processes. > > We are running Unicorn 4.3.1 + Rails 3.2.6 (without threading), on > ruby 1.9.3-p194, hosted on SmartOS/Joyent. > > At the moment, unicorns are configured to start 30 worker processes.

Re: [RFC/PATCH] FreeBSD: do not attempt to set TCP_NOPUSH to false

2012-08-02 Thread Eric Wong
Eric Wong wrote: > Can some FreeBSD users review this? Thank you. > This issue was reported privately by a FreeBSD 8.1-RELEASE user. (Original (private) bug reporter Bcc-ed) ref: http://mid.gmane.org/20120602194148.ga...@dcvr.yhbt.net > This unfortunately means we won't b

Re: [RFC/PATCH] bind listeners after loading for preload_app users

2012-08-02 Thread Eric Wong
Eric Wong wrote: > Eric Wong wrote: > > Hey all, this is probably a sensible change to make for unicorn 4.4.0 > > > > There's a small chance of introducing an incompatibility if an app > > somehow internally depends on having a listen socket ready while it'

Re: [RFC/PATCH] bind listeners after loading for preload_app users

2012-08-01 Thread Eric Wong
Eric Wong wrote: > Hey all, this is probably a sensible change to make for unicorn 4.4.0 > > There's a small chance of introducing an incompatibility if an app > somehow internally depends on having a listen socket ready while it's > loading. A test case to avoid on

[RFC/PATCH] remove Rails-oriented integration tests

2012-07-27 Thread Eric Wong
(This is a large patch which deletes a lot of files, so it's pointless to post in its entirety here. Full diffstat and --diff-filter=M output below. I've pushed this to the "pu" branch of git://bogomips.org/unicorn.git commit 91a3cde091d4ae6ff436681f155b3907daae1c04) It's too much overhead t

Re: Detecting unicorn / defining after_fork after master startup

2012-07-22 Thread Eric Wong
Matt Sanders wrote: > On Thu, Jul 19, 2012 at 6:13 PM, Eric Wong wrote: > > Matt Sanders wrote: > >> 2. Is there an established way for adding an after_fork hook after > >> Unicorn has already started up? > > > > Nothing that I know of. > > >

Re: Detecting unicorn / defining after_fork after master startup

2012-07-19 Thread Eric Wong
Matt Sanders wrote: > 1. What is the best way to determine whether the app is indeed running > inside a unicorn server? Unicorn.listener_names will return a non-empty array of listener addresses. > 2. Is there an established way for adding an after_fork hook after > Unicorn has already started u

Re: Any signal other than -9 causes full CPU utilization by master unicorn process on FreeBSD

2012-07-17 Thread Eric Wong
Mark Mccraw wrote: > On Jul 17, 2012, at 7:56 AM, Mark McCraw wrote: > > We're upgrading now to see what happens. I'm so glad you knew about > > this. There's no telling how long it would have taken me to > > question the ruby interpreter implementation, and since it's > > FreeBSD, I never would

Re: Any signal other than -9 causes full CPU utilization by master unicorn process on FreeBSD

2012-07-16 Thread Eric Wong
Mark Mccraw wrote: > Hi There! > > I'm having a devil of a time figuring out a weird issue I'm running > into. I have unicorn configured to start 4 worker processes, and that > works great. However, when it's time to cycle the app, everything > goes haywire. By trial and error, I have narrowed

Re: [ANN] alicorn 0.3.1

2012-07-10 Thread Eric Wong
Ben Somers wrote: > Hi all, > > I wrote to this list wy back in January discussing auto-scaling > for Unicorn, in situations where dedicated servers aren't practical. > I've now written a separate autoscaler, under the name of alicorn > (https://github.com/bensomers/alicorn). My current team'

[RFC/PATCH] bind listeners after loading for preload_app users

2012-06-29 Thread Eric Wong
s included. (original bug reporter Bcc-ed) >From 0146ae19c22361d5f383cc0f8b962bd9c709d200 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 29 Jun 2012 16:22:17 -0700 Subject: [PATCH] bind listeners after loading for preload_app users In the case where preload_app is true, delay binding new li

Re: Unicorn workers under Monit

2012-06-27 Thread Eric Wong
Manuel Palenciano Guerrero wrote: > Hi there, > > I would like to config Monit to monitor our production-unicorn-workers > > What memory size would you recommend to be the maximum reachable for a > worker? so Monit can restart it. It depends :) Memory size varies widely between applications/de

Re: Address already in use

2012-06-25 Thread Eric Wong
Manuel Palenciano Guerrero wrote: > Hi, > > First, thanks Eric, Jérémy and Aaron for replying. I really appreciate it. > > Yes Eric, I can see the line... "inherited addr=/tmp/unicorn.app.sock fd=..." > > here is the full log > > - > I, [2012-06-

Re: Address already in use

2012-06-25 Thread Eric Wong
Aaron Suggs wrote: > I've run in to this problem using the included example init.sh script. > The `sleep 2` on line 48 is too short in some cases. > (http://bogomips.org/unicorn.git/tree/examples/init.sh#n48) > > I use a patched example init script that uses `ps` to monitor the > upgrade process

Re: Address already in use

2012-06-25 Thread Eric Wong
Manuel Palenciano Guerrero wrote: > Hello there, > > I seem to have a problem with unix-sockets, and cannot see many people with > the same situation when googling. > > The problem is when upgrading (USR2 + QUIT) our applications. I get the > following error very frequently but not always. >

Re: Address already in use

2012-06-25 Thread Eric Wong
Aaron Suggs wrote: > P.S. I've tried to contribute the patch upstream via this list, but it > keeps getting rejected for having the wrong content type. Then I gave > up. I'm fine chalking it up to my own stupidity/laziness…just wanted > to put it out there that contributing could be easier. :-) I

Re: [PATCH] `kill -SIGTRAP `

2012-06-24 Thread Eric Wong
Cedric Maion wrote: > Eric Wong wrote: > > SIGKILL timeout is only a last line of defense when the Ruby VM itself > > is completely broken. Handling SIGTRAP implies the worker can still > > respond (and /can/ be rescued), so your SIGTRAP handler is worthless if > > SI

Re: [PATCH] `kill -SIGTRAP `

2012-06-23 Thread Eric Wong
Subject: [PATCH] `kill -SIGTRAP ` to get a live ruby backtrace + generate backtrace when murdered worker due to timeout Please keep Subject lines a reasonable length (git recommends the commit message subject wrap at ~50 columns or so) and wrap code at <= 80 columns Cedric Maion wrote: > --- >

Re: Sinatra app fails to perform at scale

2012-06-15 Thread Eric Wong
Eliot Shepard wrote: > Hello, > > We're attempting to move our set of Rails and Sinatra apps from > Passenger/REE to Unicorn/1.9.3. We've started with one of the Sinatra > apps, which typically sees about 50 req/s. It happens to talk to both > Redis (Resque) and MongoDB GridFS. Are you having pr

Re: File creation mode in Rails + Unicorn

2012-06-08 Thread Eric Wong
Jérémy Lecour wrote: > When I first hit such a page, the static cache file is not present, so > the Rails app is reached and the file is created. > The next hit is a 403 error. > > The file is created with the right user/group but in 0600 mode instead > of 0660 or 0640, that's why I have this err

Re: Triggering OobGC when heap is nearly full

2012-06-03 Thread Eric Wong
Tony wrote: > We've started using OobGC at my workplace and it's definitely helping, > however the amount of garbage various requests in our app can generate > is quite the chunky stew. Cool! (though I can't say I've ever /liked/ OobGC :x) > It seems like OobGC configuration is all predicated ar

[RFC/PATCH] FreeBSD: do not attempt to set TCP_NOPUSH to false

2012-06-02 Thread Eric Wong
Can some FreeBSD users review this? Thank you. This issue was reported privately by a FreeBSD 8.1-RELEASE user. >From a837437b4ca7903b3fcb90af1f257d841c9bd22f Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Sat, 2 Jun 2012 19:29:58 + Subject: [PATCH] FreeBSD: do not attempt to set TCP_NOP

Re: [Suggestion] Add upstream param to listen statement

2012-05-23 Thread Eric Wong
Manuel Valente wrote: > Hi, > > It would be nice to be able to reject all incoming requests to > unicorn if they do not originate from our upstream http server. > > An additional parameter to the listen statement is perhaps the best > way to achieve this : > > server.listen(addr, :tries => -1,

Re: [raindrops] testers on 32-bit FreeBSD wanted

2012-05-11 Thread Eric Wong
Eric Wong wrote: > Since unicorn users are raindrops users, I'd appreciate it if > 32-bit FreeBSD users can give this a try. Thanks! I've tested on a i386 FreeBSD 9.0 install I made and seems fine. Not sure about FreeBSD 7.0, though, but that's pretty ancient... Anyways, r

[raindrops] testers on 32-bit FreeBSD wanted

2012-05-10 Thread Eric Wong
Since unicorn users are raindrops users, I'd appreciate it if 32-bit FreeBSD users can give this a try. Thanks! ref: http://mid.gmane.org/20120510215457.ga11...@dcvr.yhbt.net Eric Wong wrote: > I've just pushed this out to master on git://bogomips.org/raindrops > > The

Re: Unicorn doesn't play nice with Capistrano deployment?

2012-05-09 Thread Eric Wong
Luis Fernando Urrea wrote: > I am having issues when using unicorn with a Capistrano deployment. > >From what I have been able to understand Capistrano uses a scheme in > wich every release is deployed inside the releases directory under a > unique name and if the transaction was successful, creat

Re: unicorn 4 does not compile on Joyent (SmartOS/Solaris) due to raindrops dependency

2012-05-09 Thread Eric Wong
Konstantin Gredeskoul wrote: > However, the raindrops dependency introduced in 4.0 breaks raindrops > (and therefore unicorn 4) on SmartOS. > > The fact that the compilation breaks in the file named > "linux_inet_diag.c" makes me believe that perhaps the authors may not > have anticipated usage b

Re: An Issue with max request uri length

2012-05-08 Thread Eric Wong
Vladislav Shub wrote: > Hi, > I have a unicorn server that receives a long http GET request and i > got 414 Request-URI Too Long. > After looking around I have found that it's hard coded to 15k ( > global_variables.h:65 DEF_MAX_LENGTH(REQUEST_URI, 1024 * 15);) the > question is what is the main

Re: Socket errors and nginx 502 gateway errors

2012-04-29 Thread Eric Wong
Pico Aeterna wrote: > reaped # worker=9 > /var/www/domain/releases/20120427011507/app/controllers/application_controller.rb:172: > [BUG] Segmentation fault OK, something (most likely your app) is causing Ruby to segfault. This is completely unrelated to nginx, so it'll be easier to hit unicorn di

[ANN] unicorn 4.3.1 - shutdown() fixes

2012-04-29 Thread Eric Wong
Changes: * Call shutdown(2) if a client EOFs on us during upload. We can avoid holding a socket open if the Rack app forked a process during uploads. * ignore potential Errno::ENOTCONN errors (from shutdown(2)). Even on LANs, connections can occasionally be accept()-ed but be unusable aft

Re: Socket errors and nginx 502 gateway errors

2012-04-28 Thread Eric Wong
Pico Aeterna wrote: > Hi, > > We've been getting reports that our users have been getting random 502 > Errors. After investigating I noticed 'upstream prematurely closed > connection while reading response header from upstream' in my nginx > error logs. From using strace it appears that there's

Re: Fwd: Rack::Lint::LintError

2012-04-28 Thread Eric Wong
George wrote: > Hi Eric, why would I get this message? > > -- Forwarded message -- > From: > Date: Sat, Apr 28, 2012 at 3:32 PM > Subject: Rack::Lint::LintError > To: li...@southernohio.net > > The message's content type was not explicitly allowed Don't send HTML mail, it's a w

Re: unicorn + sleep = long wake up loading time

2012-04-27 Thread Eric Wong
adam k wrote: > I'm running unicorn behind nginx. If the site isn't accessed for a > long period of time, the next access of the site is loads very slowly, > sometimes even a 404 error shows. Subsequent requests have a normal > loading time until the site isn't accessed for a long period of time >

[ANN] unicorn 4.3.0.2.g4551 gem prerelease

2012-04-27 Thread Eric Wong
Can you guys test this out? Thanks. I'll make a real 4.3.1 release tomorrow. >From RubyGems.org: gem install --pre unicorn ChangeLog since v4.3.0: commit 4551c8ad4d63d4031c618f76d39532b39e88f9be Author: Eric Wong Date: Fri Apr 27 14:42:38 2012 -0700 stream_input: call shutdo

Re: app error: Socket is not connected (Errno::ENOTCONN)

2012-04-27 Thread Eric Wong
George wrote: > No, you know I think you're right Eric. I am testing on OS X 10.7.4 prior > to deployment at the moment and so it appears that the bsd core has some > bearing here. It might just be OSX, I can't reproduce the issue on FreeBSD 9.0 nor Debian/kFreeBSD 6.0. Any OpenBSD/NetBSD users

Re: app error: Socket is not connected (Errno::ENOTCONN)

2012-04-27 Thread Eric Wong
Matt Smith wrote: > I just tried on a 64-bit Ubuntu 11.10 (kernel 3.0.0-17-generic), ruby > 1.9.3p0 (2011-10-30 revision 33570) [x86_64-linux]. No issue. Reloaded > a several pages, many times. No ENOTCONN. Not one. Same app. OK, thank you for the confirmation. I wouldn't rule out an occasional

Re: app error: Socket is not connected (Errno::ENOTCONN)

2012-04-27 Thread Eric Wong
George wrote: > Just fyi, my dev logs are now rife with these: http://j.mp/IezMAu > > Will plug your patch in, but will have to figure out another option for > heroku deployment. Is this affecting your heroku deployment? What OS/kernel version are you running? From what Joel and Matt say, it c

Re: app error: Socket is not connected (Errno::ENOTCONN)

2012-04-27 Thread Eric Wong
Eric Wong wrote: > George wrote: > > Just fyi, my dev logs are now rife with these: http://j.mp/IezMAu > > > > Will plug your patch in, but will have to figure out another option for > > heroku deployment. > > Is this affecting your heroku deployment? What OS

Re: app error: Socket is not connected (Errno::ENOTCONN)

2012-04-27 Thread Eric Wong
Joel Nimety wrote: > On Fri, Apr 27, 2012 at 2:59 PM, Eric Wong wrote: > > Joel Nimety wrote: > >> I'm getting the following errors multiple times per request when using > >> 4.3.0.  I do not receive any errors when using 4.2.1.  Please CC me on > >> r

Re: app error: Socket is not connected (Errno::ENOTCONN)

2012-04-27 Thread Eric Wong
Rainbows! has long had a similar patch as below, but I'm a bit concerned as to why Joel is getting this multiple times per request... >From 04901da5ae0b4655c83be05d24ae737f1b572002 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 27 Apr 2012 11:48:16 -0700 Subject: [PATCH] http_serve

[ANN] unicorn 4.3.0 - minor fixes and updates

2012-04-17 Thread Eric Wong
Changes: * PATH_INFO (aka REQUEST_PATH) increased to 4096 (from 1024). This allows requests with longer path components and matches the system PATH_MAX value common to GNU/Linux systems for serving filesystem components with long names. * Apps that fork() (but do not exec()) internally for

Re: Background jobs with #fork

2012-04-12 Thread Eric Wong
Patrik Wenger wrote: > > Actually, I think my proposed patch (in reply to Hongli) at > > http://mid.gmane.org/20120412221022.ga20...@dcvr.yhbt.net > > should fix your issue. > > Oh, this sounds great! I see it's just one line. I'll try adding this line > and see if it fixes my problem. > Thanks

Re: Background jobs with #fork

2012-04-12 Thread Eric Wong
Patrik Wenger wrote: > Thanks for the answers. No problem. > Isn't there another way to retrieve the right socket? Actually, I think my proposed patch (in reply to Hongli) at http://mid.gmane.org/20120412221022.ga20...@dcvr.yhbt.net should fix your issue. > > I can probably writeup a better ex

Re: Background jobs with #fork

2012-04-12 Thread Eric Wong
Hongli Lai wrote: > On Thu, Apr 12, 2012 at 10:39 PM, Eric Wong wrote: > > paddor wrote: > >> The problem persists even when multiple workers are started. And the > >> problem was not present in the old setup with Passenger. > > > > The difference

Re: Background jobs with #fork

2012-04-12 Thread Eric Wong
paddor wrote: > Hi > > I've migrated from Passenger to Unicorn about a week ago. It's great. > Great transparency and management, thanks for this great software! :> > A few of my Rails applications start background jobs using > Kernel#fork. Of course, the ActiveRecord connections are closed and

Re: Request-URI Too Long from mongrel-unicorn

2012-04-12 Thread Eric Wong
Eric Wong wrote: > Lawrence Pit wrote: > > Should there be a limit at all in unicorn? Should it not be assumed > > this is configured at the webserver level, like: > > > > http://wiki.nginx.org/NginxHttpCoreModule#large_client_header_buffers > > There should

Re: Request-URI Too Long from mongrel-unicorn

2012-04-11 Thread Eric Wong
Nuo Yan wrote: > On Apr 11, 2012, at 1:30 PM, Eric Wong wrote: > > I will consider upping REQUEST_PATH to 4096 (and REQUEST_URI to 15K) > > since 4096 is a common filesystem PATH_MAX on modern systems. > > 4k makes sense to me. When do you think you can cut a gem on this?

Re: Request-URI Too Long from mongrel-unicorn

2012-04-11 Thread Eric Wong
Lawrence Pit wrote: > IE browsers up to and including IEv8 have a max URL length of 2,083 > characters : http://support.microsoft.com/kb/208427. Ah, that probably explains why MAX_URI_LENGTH=2083 in WEBrick (lib/webrick/httprequest.rb). > There may be other clients (ruby http clients, bots, tra

Re: Request-URI Too Long from mongrel-unicorn

2012-04-11 Thread Eric Wong
Nuo Yan wrote: > In my understanding, the mongrel request uri limit is 12k. Correct, that's the entire REQUEST_URI, though: REQUEST_PATH?QUERY_STRING#FRAGMENT > My request uri is certainly not that long (about 1445 bytes), but for > some reason I'm getting 414 Request-URI Too Long from the s

[ANN] unicorn 4.2.1 - minor fix and doc updates

2012-03-26 Thread Eric Wong
Changes: * Stale pid files are detected if a pid is recycled by processes belonging to another user, thanks to Graham Bleach. * nginx example config updates thanks to to Eike Herzbach. * KNOWN_ISSUES now documents issues with apps/libs that install conflicting signal handlers. * http://unicor

Re: [PATCH] make stderr_path/stdout_path support IO objects directly

2012-03-22 Thread Eric Wong
Benedikt Böhm wrote: Hello, can you explain in the commit message why this functionality is useful to have? SIGUSR1 log file reopening only works because it relies on knowing File#path on File objects > --- > lib/unicorn/configurator.rb |2 +- > lib/unicorn/http_server.rb |6 +- >

unicorn 4.2.1 release soon?

2012-03-21 Thread Eric Wong
There's not much going on in unicorn.git nowadays, everything's stabilized nicely over the past few years. This release would mainly be for for Graham's EPERM fix/workaround for stale pid files and some documentation fixes improvements. Shortlog below: Eric Wong (4):

Re: [PATCH] Start the server if another user has a PID matching our stale pidfile.

2012-03-20 Thread Eric Wong
Eric Wong wrote: > Graham Bleach wrote: > > If unicorn doesn't get terminated cleanly (for example if the machine > > has its power interrupted) and the pid in the pidfile gets used by > > another process, the current unicorn code will exit and not start a > > se

Re: Suggestion for improvement of examples/nginx.conf

2012-03-20 Thread Eric Wong
Eric Wong wrote: > Eike Herzbach wrote: > > Hi, > > > > what do you think about that: > > > > diff --git a/examples/nginx.conf b/examples/nginx.conf > > index cc1038a..5ef43f3 100644 > > --- a/examples/nginx.conf > > +++ b/examples/nginx.conf

Re: Unicorn_rails ignores USR2 signal

2012-03-20 Thread Eric Wong
Eric Wong wrote: > "Yeung, Jeffrey" wrote: > > Sorry for the delay. It looks like disabling preload_app did the > > trick. A new master was created after sending the USR2. Now the $$$ > > question is, what in the world is intercepting the signal? :S >

Re: Unicorn_rails ignores USR2 signal

2012-03-12 Thread Eric Wong
"Yeung, Jeffrey" wrote: > Sorry for the delay. It looks like disabling preload_app did the > trick. A new master was created after sending the USR2. Now the $$$ > question is, what in the world is intercepting the signal? :S Good to know, I'd just grep the installation directories for all you

Re: Unicorn_rails ignores USR2 signal

2012-03-12 Thread Eric Wong
Eric Wong wrote: > However, there's another possibility I hadn't considered, what if you > disable preload_app? Your app or some libs it uses may be intercepting > USR2 for something it does. Ping? Was this it? ___ Unicorn mai

Re: Unicorn_rails ignores USR2 signal

2012-03-09 Thread Eric Wong
"Yeung, Jeffrey" wrote: > I have it configured for 4 workers. I just turned it down to 1 worker > and tested both TTIN and TTOU. They both work, creating and killing > workers, respectively. The following is the strace capture from an > TTOU signal, followed by a USR2 signal. Yes, that is the

Re: Unicorn_rails ignores USR2 signal

2012-03-09 Thread Eric Wong
"Yeung, Jeffrey" wrote: > Thanks Eric. New strace capture as follows: > > $ sudo strace -f -e '!futex' -p 14255 > Process 14255 attached with 12 threads - interrupt to quit >From that, you have 5 worker processes? For debugging this, it can cut down on noise to only use one worker process, t

Re: Unicorn_rails ignores USR2 signal

2012-03-09 Thread Eric Wong
"Yeung, Jeffrey" wrote: > $ ruby -v > ruby 1.9.1p376 (2009-12-07 revision 26041) [x86_64-linux] > > The Rails gem version is 2.3.14. Unicorn gem version 4.2.0. > I have done my best to debug it using strace and the stderr logs. The > unicorn_rails master process handles HUP, QUIT, and USR1 s

Re: Running unicorn gracefully on Heroku

2012-03-07 Thread Eric Wong
Seamus Abshere wrote: > I just posted a StackOverflow question about running unicorn > gracefully on Heroku... > > http://stackoverflow.com/questions/9605703/how-can-i-tell-unicorn-to-understand-herokus-signals Ugh, can you just send/copy the question over here next time so we don't have to foll

Re: murdering high-memory workers and auto-scaling

2012-03-01 Thread Eric Wong
Ben Somers wrote: > First: auto-killing bloated workers. My current app has some memory > leakage that wasn't really visible on our older passenger setup, since Btw, you reported issues with memory usage on a Ubuntu system a few months ago, is this the same system? Are you using stock malloc() o

Re: murdering high-memory workers and auto-scaling

2012-03-01 Thread Eric Wong
Ben Somers wrote: > Two ideas, one more controversial than the other. Neither is really controversal. > First: auto-killing bloated workers. My current app has some memory > leakage that wasn't really visible on our older passenger setup, since > the auto-scaling meant that bloated workers got k

Re: [PATCH] Start the server if another user has a PID matching our stale pidfile.

2012-02-29 Thread Eric Wong
. Thanks! Acked-by: Eric Wong and pushed to master on git://bogomips.org/unicorn.git ___ Unicorn mailing list - mongrel-unicorn@rubyforge.org http://rubyforge.org/mailman/listinfo/mongrel-unicorn Do not quote signatures (like this one) or top post when replying

Re: Suggestion for improvement of examples/nginx.conf

2012-02-28 Thread Eric Wong
Eike Herzbach wrote: > Hi, > > what do you think about that: > > diff --git a/examples/nginx.conf b/examples/nginx.conf > index cc1038a..5ef43f3 100644 > --- a/examples/nginx.conf > +++ b/examples/nginx.conf > @@ -55,7 +55,7 @@ http { ># faster or not than doing compression via nginx. It's

Re: using unicorn as a local development server

2012-02-24 Thread Eric Wong
Matt Smith wrote: > Eric Wong wrote: > > Normally I just write integration tests (sometimes starting unicorn (or > > zbatery) + hitting it with curl, but often just mocking a Rack env). > > Unlike most folks that develop apps that run over HTTP, I have a strong > > av

Re: using unicorn as a local development server

2012-02-22 Thread Eric Wong
"Patrick J. Collins" wrote: > > You shouldn't even need the logger directive, it goes to stderr by > > default so your console will still show it. > > Hmm that's odd because I noticed as soon as I began using unicorn that I got > very little output. For example, running my app and browsing to va

Re: using unicorn as a local development server

2012-02-22 Thread Eric Wong
"Patrick J. Collins" wrote: > Hi Unicorn friends, > > I wanted to try out Unicorn as my development server and I see that I > need to perform some configuration to make this work nicely with rails. > >From what I can tell the only real things I need to do to make unicorn > similar to the default

Re: Bug in unicorn_rails when Encoding.default_internal is set

2012-02-16 Thread Eric Wong
Lucas Parry wrote: > On Fri, Feb 17, 2012 at 1:29 PM, Lucas Parry wrote: > > We recently made the switch to 1.9 for our large rails 2.3.14 project (odd, neither I nor gmane got your original message: http://rubyforge.org/pipermail/mongrel-unicorn/2012-February/001310.html Perhaps Mailman misde

Re: FreeBSD jail and unicorn

2012-02-06 Thread Eric Wong
Eric Wong wrote: > ruby-core pointed me to the following issue: > https://bugs.ruby-lang.org/issues/5757 > > So there may already be a fix in Ruby SVN, can you test? > http://svn.ruby-lang.org/repos/ruby/branches/ruby_1_9_3 r34425 Btw, did anybody get a chance to try this? W

Re: Deployment with Capistrano and Foreman

2012-02-05 Thread Eric Wong
Dmytrii Nagirniak wrote: > I wonder how do you deploy Unicorn Rails apps using Foreman and the upstart. > > The things I'm not sure how to deal with are: > > - restarting the Unicorn with no downtime. With upstart I think the master > process gets restarted. I'll defer to actual Foreman/upstar

Re: FreeBSD jail and unicorn

2012-02-02 Thread Eric Wong
ruby-core pointed me to the following issue: https://bugs.ruby-lang.org/issues/5757 So there may already be a fix in Ruby SVN, can you test? http://svn.ruby-lang.org/repos/ruby/branches/ruby_1_9_3 r34425 ___ Unicorn mailing list - mongrel-unicorn@rubyf

<    1   2   3   4   5   6   7   8   9   >