Re: [Musicpd-dev-team] Remove duplicate optimisation for volume

2013-08-16 Thread andrew cooke
On Fri, Aug 16, 2013 at 12:27:15PM +0200, Matthias Larisch wrote: > While I agree on the second case we save one memcpy on the first case. Oh, of course. Sorry. Andrew -- Get 100% visibility into Java/.NET code with App

Re: [Musicpd-dev-team] Remove duplicate optimisation for volume

2013-08-16 Thread Max Kellermann
On 2013/08/16 12:27, Matthias Larisch wrote: > While I agree on the second case we save one memcpy on the first > case. You got it, and that's the reason we have a similar optimisation in two code locations. The two optimisations are not equivalent and neither can be removed. > In my opinion we

Re: [Musicpd-dev-team] Remove duplicate optimisation for volume

2013-08-16 Thread Matthias Larisch
Am Thu, 15 Aug 2013 22:57:25 -0400 schrieb andrew cooke : > > Hi, > > I was just looking through the mpd source and noticed that the optimisations > in ReplayGainFilter::FilterPCM duplicate code in pcm_volume. So the following > code would be equivalent. > Hi, While I agree on the second cas

Re: [Musicpd-dev-team] Support for Musicbrainz ratings

2013-08-16 Thread jean-baptiste Bertin
On the other hand, managing such metadata in a more central fashion would provide for a more consistent experience for those users who run several clients (I use at least 5 different clients fairly regularly to control the same instance of mpd). On 16 August 2013 11:51, Grant wrote: > >>> music

Re: [Musicpd-dev-team] Support for Musicbrainz ratings

2013-08-16 Thread Grant
>>> musicbrainz is for gathering metadata. Ratings are totally personal. >> >> Sure but musicbrainz also gathers ratings and displays the averages: >> >> http://musicbrainz.org/doc/Rating_System > Didn't know about that. Anyway, musicbrainz would be like a metadata > service, and I don't know about

Re: [Musicpd-dev-team] Support for Musicbrainz ratings

2013-08-16 Thread Javier Domingo
On Fri, Aug 16, 2013 at 10:47 AM, Grant wrote: >> musicbrainz is for gathering metadata. Ratings are totally personal. > > Sure but musicbrainz also gathers ratings and displays the averages: > > http://musicbrainz.org/doc/Rating_System Didn't know about that. Anyway, musicbrainz would be like a m

Re: [Musicpd-dev-team] Support for Musicbrainz ratings

2013-08-16 Thread Grant
>> musicbrainz is for gathering metadata. Ratings are totally personal. > > Sure but musicbrainz also gathers ratings and displays the averages: > > http://musicbrainz.org/doc/Rating_System I should also add that the musicbrainz client "picard" can tag music files with the ratings. - Grant

Re: [Musicpd-dev-team] Support for Musicbrainz ratings

2013-08-16 Thread Grant
> musicbrainz is for gathering metadata. Ratings are totally personal. Sure but musicbrainz also gathers ratings and displays the averages: http://musicbrainz.org/doc/Rating_System - Grant P.S. Estoy en Donostia. :) Aste nagusia! >>> You can always extend the mpd protocol through stickers, a

Re: [Musicpd-dev-team] Support for Musicbrainz ratings

2013-08-16 Thread Javier Domingo
I am interested in that document, is there any way to get it? Or is there any place where such standards can be proposed? Javier Domingo Cansino Research & Development Junior Engineer Fon Labs Workgroup, Getxo - Spain. On Fri, Aug 16, 2013 at 9:33 AM, Qball wrote: > There used to be a document t

Re: [Musicpd-dev-team] Support for Musicbrainz ratings

2013-08-16 Thread Qball
There used to be a document that proposed common stickers. I think Rasi wrote it. I Removed rating using stickers from gmpc as there was no interest for It. R, Q Req, screenshot http://images.sarine.nl/gmpc-sticker-rating.png Original message From: Javier Domingo Date: 16/08

Re: [Musicpd-dev-team] Support for Musicbrainz ratings

2013-08-16 Thread Javier Domingo
You can always extend the mpd protocol through stickers, adding there the rating to the meta. But that would be your own implementation. I don't know about any way of obtaining it but through hacks. Javier Domingo Cansino Research & Development Junior Engineer Fon Labs Workgroup, Getxo - Spain.