Re: [Musicpd-dev-team] New event loop implementation

2013-11-24 Thread Denis Krjuchkov
24.11.2013 21:06, Max Kellermann пишет: > My few cents: Thanks for the comments! > > - you reordered code in event/Loop.cxx, which makes reading the diff >more difficult than necessary That's my fault, probably I was addicted to Add/Modify/Remove trio in every class :-) > > - the PollGroup

Re: [Musicpd-dev-team] New event loop implementation

2013-11-24 Thread Max Kellermann
On 2013/11/19 13:12, Denis Krjuchkov wrote: > I'm trying to implement new event loop for MPD without GLib (or any > other library). > It's borrowed from existing epoll-based event loop. > I only abstracted API differences behind general inteface (PollGroup class). > Currently there are 3 backends

Re: [Musicpd-dev-team] New command line parser

2013-11-24 Thread Max Kellermann
On 2013/11/24 14:08, Denis Krjuchkov wrote: > 24.11.2013 18:38, Max Kellermann ??: > >I was wondering whether we should use boost for that. Now you > >implemented a new parser. Why that? > > > > Why not? Probably for the complex cases it's better to use a > library* but MPD currently us

Re: [Musicpd-dev-team] New command line parser

2013-11-24 Thread Denis Krjuchkov
24.11.2013 18:38, Max Kellermann пишет: > I was wondering whether we should use boost for that. Now you > implemented a new parser. Why that? > Why not? Probably for the complex cases it's better to use a library* but MPD currently uses very simple flag options that are easily parsed without a

Re: [Musicpd-dev-team] New command line parser

2013-11-24 Thread Max Kellermann
On 2013/11/24 12:34, Denis Krjuchkov wrote: > this time I'm reworking command line parsing to avoid using g_option > stuff. I was wondering whether we should use boost for that. Now you implemented a new parser. Why that?

[Musicpd-dev-team] New command line parser

2013-11-24 Thread Denis Krjuchkov
Hi, this time I'm reworking command line parsing to avoid using g_option stuff. Commit: http://git.musicpd.org/cgit/dk/mpd.git/commit/?h=new-cmdline-parser&id=db238cc23f3bb5c9768d30ae24b99e67a5795203 Pull from new-cmdline-parser branch of git://git.musicpd.org/dk/mpd.git -- Denis ---