Re: [Musicpd-dev-team] New event loop implementation

2013-11-27 Thread Max Kellermann
On 2013/11/27 14:18, Denis Krjuchkov wrote: > OK. Do you have any comments on the patch itself? Just read it & merged. Looks excellent! -- Rapidly troubleshoot problems before they affect your business. Most IT organiz

Re: [Musicpd-dev-team] New event loop implementation

2013-11-27 Thread Denis Krjuchkov
27.11.2013 19:00, Max Kellermann пишет: > > That's not perfect but ok, because ALSA is Linux specific, and on > Linux we always have epoll (there's no reason not to use it). > OK. Do you have any comments on the patch itself? -- Denis

Re: [Musicpd-dev-team] New event loop implementation

2013-11-27 Thread Max Kellermann
On 2013/11/27 12:53, Denis Krjuchkov wrote: > Also during testing I've found that AlsaMixerMonitor depends on epoll > event loop (specifically on a AddCall method). This means it could not > be compiled when GLib event loop is used. I didn't find immediately > obvious way of fixing this, thus d

Re: [Musicpd-dev-team] New event loop implementation

2013-11-27 Thread Denis Krjuchkov
I've made a helper patch for simplifying futher work. It adds various configuration options to simplify dealting with different event loop implementations. Here it is: http://git.musicpd.org/cgit/dk/mpd.git/commit/?id=46bab7e4b921b79924643bacd08dcd3d1404ceb6 Also during testing I've found that