Re: [Musicpd-dev-team] FS improvements + refinements in PollGroupWinSelect

2013-12-05 Thread Ben Boeckel
On Thu, Dec 05, 2013 at 19:17:56 +0600, Denis Krjuchkov wrote: > g_get_home_dir() works differently depending on GLib version. > Newer GLib versions check $HOME first > and if it's empty use getpwnam_r() to obtain home directory for > currently user. > Old versions go straight into using getpwnam_

Re: [Musicpd-dev-team] Tags in OGG httpd stream

2013-10-19 Thread Ben Boeckel
On Sat, Oct 19, 2013 at 15:47:25 +0200, Max Kellermann wrote: > On 2013/10/11 05:12, Ben Boeckel wrote: > > the tag chunk is dropped because chunk->length is 0 for it. A patch > > which fixes the issue is attached. > > Merged, thanks. Sorry for letting you wait for so l

[Musicpd-dev-team] Crash on master on exit/stream disconnect

2013-10-10 Thread Ben Boeckel
When disconnecting a stream or stopping (SIGINT) mpd, I'm seeing the following backtrace with master (17c6db6c33b9b14a8627b3f9b3da8580a5f932a2): #0 EventLoop::RemoveFD (this=0x0, _fd=0, m=...) at src/event/Loop.cxx:64 #1 0x0043f0d7 in SocketMonitor::Schedule (this=0x1a74c28, flags=flags

Re: [Musicpd-dev-team] Tags in OGG httpd stream

2013-10-10 Thread Ben Boeckel
On Fri, Oct 11, 2013 at 00:14:46 -0400, Ben Boeckel wrote: > On Thu, Oct 10, 2013 at 23:12:27 -0400, Ben Boeckel wrote: > > So this line here was the issue. This flushes the chunk into the stream > > with just the tag and no data on it. Combined with this code right > > before

Re: [Musicpd-dev-team] Tags in OGG httpd stream

2013-10-10 Thread Ben Boeckel
On Thu, Oct 10, 2013 at 23:12:27 -0400, Ben Boeckel wrote: > So this line here was the issue. This flushes the chunk into the stream > with just the tag and no data on it. Combined with this code right > before the chunk leaves for the sources: It seems this fix isn't complete actu

Re: [Musicpd-dev-team] Tags in OGG httpd stream

2013-10-10 Thread Ben Boeckel
On Wed, Dec 05, 2012 at 16:51:54 -0500, Ben Boeckel wrote: > @@ -524,31 +532,7 @@ decoder_replay_gain(struct decoder *decoder, > float return_db = 0; > assert(decoder != NULL); > > - if (replay_gain_info != NULL) { > - static unsigned serial;

Re: [Musicpd-dev-team] Tags in OGG httpd stream

2013-10-09 Thread Ben Boeckel
On Wed, 05 Dec, 2012 at 21:51:54 GMT, Ben Boeckel wrote: > I bisected the repository to find out when this broke and ended up with > a commit from Feb 2010[2], specifically where replay gain was removed > from the core decoder codepath and added as a filter. Hooking up the > replay

Re: [Musicpd-dev-team] FileSystem: new library for Path-friendly file system routines

2013-01-20 Thread Ben Boeckel
On Sun, Jan 20, 2013 at 17:25:26 +0100, Max Kellermann wrote: > bool IsRegularFile(Path, bool follow_symlinks=true) That works as well. --Ben -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC,

Re: [Musicpd-dev-team] FileSystem: new library for Path-friendly file system routines

2013-01-20 Thread Ben Boeckel
On Sun, Jan 20, 2013 at 17:14:12 +0100, Max Kellermann wrote: > - slightly disagree with Ben (but thanks for pointing out that > potential problem): there should be some way to specify whether > symbolic links shall be followed. Some callers may want to follow > symlinks, some do not, and th

Re: [Musicpd-dev-team] UTF-8 file names support for Windows

2013-01-20 Thread Ben Boeckel
On Sun, Jan 20, 2013 at 16:20:13 +0100, Max Kellermann wrote: > > C++ provides wrappers for standard C headers (e.g. cstdio for stdio.h). > > Are there any rules on them? I tend to use them, however they have > > serious disadvantage: it's hard to predict whenever some function > > would appear to

Re: [Musicpd-dev-team] FileSystem: new library for Path-friendly file system routines

2013-01-20 Thread Ben Boeckel
On Sun, Jan 20, 2013 at 19:10:28 +0600, Denis Krjuchkov wrote: > Pushed slightly improved version: > > http://git.musicpd.org/cgit/dk/mpd.git/commit/?id=e6ed592b8aeb5025be0893ee99ff44e46a9ffd1c For CheckExists, you should use lstat instead of stat. stat will error if the path is a broken symlink.

[Musicpd-dev-team] Tags in OGG httpd stream

2012-12-05 Thread Ben Boeckel
artist=Mercury Adept musicbrainz_trackid=e7c5a312-7d8d-4a05-ba3a-3cdd6248d103 artistsort=Mercury Adept tracknumber=1 REPLAYGAIN_REFERENCE_LOUDNESS=89.0 dB REPLAYGAIN_TRACK_GAIN=-3.29 dB REPLAYGAIN_TRACK_PEAK=0.93211985 REPLAYGAIN_ALBUM_GAI