Re: [Musicpd-dev-team] MPD visualization stuff

2009-01-15 Thread Christ Schlacta
okay, I want to add a feature request at this point for RTP and RTCP streaming in MPD, bot configurable in the config file or through your favorite client. On Thu, Jan 15, 2009 at 9:38 AM, Max Kellermann wrote: > On 2009/01/15 18:09, Vasily Stepanov wrote: >> My justification: I was trying to fo

Re: [Musicpd-dev-team] MPD visualization stuff

2009-01-15 Thread Max Kellermann
On 2009/01/15 18:09, Vasily Stepanov wrote: > My justification: I was trying to follow KISS principal. It's exactly the opposite: designing and implementing a brand new protocol is complex and tedious, all but KISS. When we finish fixing the shortcomings of your protocol, it'll probably be RTP l

Re: [Musicpd-dev-team] MPD visualization stuff

2009-01-15 Thread Vasily Stepanov
On Thu, Jan 15, 2009 at 2:22 PM, Max Kellermann wrote: > On 2009/01/15 12:05, Vasily Stepanov wrote: >> I've studied some audio streaming problems and existent solutions, >> and I think that now, you are talking about RTCP over RTP :) Why not >> to use this protocol? It works over UDP and designe

Re: [Musicpd-dev-team] MPD visualization stuff

2009-01-15 Thread Max Kellermann
On 2009/01/15 12:05, Vasily Stepanov wrote: > I've studied some audio streaming problems and existent solutions, > and I think that now, you are talking about RTCP over RTP :) Why not > to use this protocol? It works over UDP and designed for delivering > real-time audio (and video) over the Inter

Re: [Musicpd-dev-team] MPD visualization stuff

2009-01-15 Thread Vasily Stepanov
On Thu, Jan 15, 2009 at 1:26 PM, Max Kellermann wrote: > On 2009/01/14 19:11, Stefan Monnier wrote: >> > When the network between the client and the server is saturated, TCP >> > sees packet loss, and throttles the connection. We can't do that >> > easily with UDP, not without losing UDP's advan

Re: [Musicpd-dev-team] MPD visualization stuff

2009-01-15 Thread Max Kellermann
On 2009/01/14 19:11, Stefan Monnier wrote: > > When the network between the client and the server is saturated, TCP > > sees packet loss, and throttles the connection. We can't do that > > easily with UDP, not without losing UDP's advantages. > > Yes, you'd need to have the client monitor the ra

Re: [Musicpd-dev-team] MPD visualization stuff

2009-01-14 Thread Stefan Monnier
>> I don't get it, what "rate limiting"? > When the network between the client and the server is saturated, TCP > sees packet loss, and throttles the connection. We can't do that > easily with UDP, not without losing UDP's advantages. Yes, you'd need to have the client monitor the rate at which i

Re: [Musicpd-dev-team] MPD visualization stuff

2009-01-14 Thread Max Kellermann
On 2009/01/14 15:52, Vasily Stepanov wrote: > I've read "Basic stgit usage" in your wiki, but I didn't use it yet > (I'm new in git) > If it understood it right, as long as my pathces are not submitted I can > write a lot of changes in a single path Yes. You can work on several patches at a time

Re: [Musicpd-dev-team] MPD visualization stuff

2009-01-14 Thread Max Kellermann
On 2009/01/14 15:52, Vasily Stepanov wrote: > > Now let's talk about your definition of "impatient". What do you mean > > by that? > > Client can ask for chunk to quick, and then he will receive duplicated chunk. You're trying to get around my question ;-) Define "too quick"! And then define

Re: [Musicpd-dev-team] MPD visualization stuff

2009-01-14 Thread Vasily Stepanov
On Wed, Jan 14, 2009 at 9:50 AM, Max Kellermann wrote: > On 2009/01/14 03:37, Vasily Stepanov wrote: >> Great :) >> About CamelCase... do you have any code formatting standards? >> May be in your wiki... I didn't found them, so of course >> I was trying to copypaste existing functions names and v

Re: [Musicpd-dev-team] MPD visualization stuff

2009-01-13 Thread Max Kellermann
On 2009/01/14 03:37, Vasily Stepanov wrote: > Great :) > About CamelCase... do you have any code formatting standards? > May be in your wiki... I didn't found them, so of course > I was trying to copypaste existing functions names and variables. No, we don't have it documented. Try not to copy'n

Re: [Musicpd-dev-team] MPD visualization stuff

2009-01-13 Thread Vasily Stepanov
On Tue, Jan 13, 2009 at 10:24 PM, Max Kellermann wrote: > > On 2009/01/10 23:57, Vasily Stepanov wrote: > > Currently I'm working on MPD visualization stuff. > > Hi Vasily, > > here's a rough review of the "udpfeed" plugin (commit f0fd78a911d6). > > First: I like your coding style, you're using i

Re: [Musicpd-dev-team] MPD visualization stuff

2009-01-13 Thread Max Kellermann
On 2009/01/10 23:57, Vasily Stepanov wrote: > Currently I'm working on MPD visualization stuff. Hi Vasily, here's a rough review of the "udpfeed" plugin (commit f0fd78a911d6). First: I like your coding style, you're using inline functions a lot. You're writing a lot of source code comments. Ho

Re: [Musicpd-dev-team] MPD visualization stuff

2009-01-11 Thread Max Kellermann
On 2009/01/10 23:57, Vasily Stepanov wrote: > "People mainly just want to listen to music, I don't think people really > care about visualizations once they loose their fixation w/ a music player > and get back to just listening to music and doing work." > > But I'm doing it just for fun, so nobo

[Musicpd-dev-team] MPD visualization stuff

2009-01-10 Thread Vasily Stepanov
Hi all! Currently I'm working on MPD visualization stuff. Yes, I've found shank's opinion here http://www.musicpd.org/forum/index.php?topic=351.msg1692#msg1692 and I can agree with him "People mainly just want to listen to music, I don't think people really care about visualizations once they loos