Re: [Musicpd-dev-team] Two minor updates for winmm output plugin

2010-11-03 Thread Denis Krjuchkov
04.11.2010 11:00, Max Kellermann пишет: > Both merged, thanks. > + UINT id = strtoul(device_name,&endptr, 0); > + if (*endptr == 0) > > This is positive for parsing an empty string; please make that: > > endptr> device_name&& *endptr == 0 Hello, Max. Thanks for reviewing. I've made suggest

Re: [Musicpd-dev-team] Two minor updates for winmm output plugin

2010-11-03 Thread Max Kellermann
On 2010/11/03 21:09, Denis Krjuchkov wrote: > Hello all. > I'm back :-) > > Two minor updates for winmm_output_plugin Both merged, thanks. + UINT id = strtoul(device_name, &endptr, 0); + if (*endptr == 0) This is positive for parsing an empty string; please make that: endptr > device_nam

[Musicpd-dev-team] Two minor updates for winmm output plugin

2010-11-03 Thread Denis Krjuchkov
Hello all. I'm back :-) Two minor updates for winmm_output_plugin 1) test_default_device now checks number of playback devices installed in system. If no device is present it returns false. 2) added "device" configuration option (similar to other output devices). Device can be specified eithe