+1
On 11/11/2015 8:50 PM, Hannes Wallnoefer wrote:
Please review JDK-8047366 and JDK-8141505.
These are two trivial test-only fixes enabled by the recent double
conversion commit.
http://cr.openjdk.java.net/~hannesw/8047366/webrev/
http://cr.openjdk.java.net/~hannesw/8141505/webrev/
Thanks,
+1
On 11/12/2015 9:06 PM, Hannes Wallnoefer wrote:
Please review JDK-8142864: Raw types warning in WeakValueCache:
http://cr.openjdk.java.net/~hannesw/8142864/webrev/
This removes a warning in WeakValueCache.java, and I also reduced
methods by combining code as suggested by Attila.
Furtherm
Hi Hannes,
lower-case thumbs up.
Best,
Michael
> Am 12.11.2015 um 16:36 schrieb Hannes Wallnoefer
> :
>
> Please review JDK-8142864: Raw types warning in WeakValueCache:
>
> http://cr.openjdk.java.net/~hannesw/8142864/webrev/
>
> This removes a warning in WeakValueCache.java, and I also red
Please review JDK-8142864: Raw types warning in WeakValueCache:
http://cr.openjdk.java.net/~hannesw/8142864/webrev/
This removes a warning in WeakValueCache.java, and I also reduced
methods by combining code as suggested by Attila.
Furthermore I renamed method in isWrappedPrimitiveAndObject i
Hi Sundar,
yep, lower-case thumbs up. It's *good* to cover more tests with jtreg.
Best,
Michael
> Am 12.11.2015 um 14:43 schrieb Sundararajan Athijegannathan
> :
>
> Please review http://cr.openjdk.java.net/~sundar/8142857/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8142857
>
+1
> On Nov 12, 2015, at 2:43 PM, Sundararajan Athijegannathan
> wrote:
>
> Please review http://cr.openjdk.java.net/~sundar/8142857/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8142857
>
> Thanks,
> -Sundar
>
Thanks.
Made that static initializer change and pushed.
Updated webrev for the record:
http://cr.openjdk.java.net/~sundar/8142857/webrev.01/
-Sundar
On 11/12/2015 7:49 PM, Hannes Wallnoefer wrote:
+1
The static fields in ParseAPITest.java are set twice, if you remove
the first initializer
+1
The static fields in ParseAPITest.java are set twice, if you remove the
first initializer they could remain final.
Hannes
Am 2015-11-12 um 14:43 schrieb Sundararajan Athijegannathan:
Please review http://cr.openjdk.java.net/~sundar/8142857/webrev.00/
for https://bugs.openjdk.java.net/brow
Please review http://cr.openjdk.java.net/~sundar/8142857/webrev.00/ for
https://bugs.openjdk.java.net/browse/JDK-8142857
Thanks,
-Sundar
+1
Am Don, 12. Nov, 2015 um 5:43 schrieb Sundararajan Athijegannathan
:
Hi,
[ Replying based on url from JIRA update. I'm yet to get email from
nashorn-dev list]
Nashorn team runs test via "ant clean test". Only a subset of tests
are enabled for jtreg by appropriate jtreg tags. In this ca
That was in response to this email ->
http://mail.openjdk.java.net/pipermail/nashorn-dev/2015-November/005562.html
On 11/12/2015 10:13 AM, Sundararajan Athijegannathan wrote:
Hi,
[ Replying based on url from JIRA update. I'm yet to get email from
nashorn-dev list]
Nashorn team runs test via
+1
> On 11 Nov 2015, at 16:26, Sundararajan Athijegannathan
> wrote:
>
> +1
>
> On 11/11/2015 8:50 PM, Hannes Wallnoefer wrote:
>> Please review JDK-8047366 and JDK-8141505.
>>
>> These are two trivial test-only fixes enabled by the recent double
>> conversion commit.
>>
>> http://cr.openjd
12 matches
Mail list logo
