[git patches] net driver fixes

2006-07-28 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/myri10ge/myri10ge.c |2 - drivers/net/skge.c|5 drivers/net/via-vel

Re: [PATCH 3/3] forcdeth: NAPI support (rev3)

2006-07-28 Thread Jeff Garzik
Previous patches in this series were applied to netdev-2.6.git#upstream. Can you resend this one + patch #4 as a single patch? Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.ker

Re: [PATCH 1/3] forcedeth: coding style cleanups

2006-07-28 Thread Jeff Garzik
applied patches 1-2 - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] via-velocity: fix reported speed and link detected status

2006-07-28 Thread Jeff Garzik
Francois Romieu wrote: Jay Cliburn <[EMAIL PROTECTED]> : The via-velocity driver reports incorrect speed and link detected status as viewed by ethtool (and probably other tools). This patch fixes those incorrect reports and prettifies a long line. Looks fine. Fixed the whitespace/tabs damage,

[IPV6]: Audit all ip6_dst_lookup/ip6_dst_store calls

2006-07-28 Thread Herbert Xu
On Fri, Jul 28, 2006 at 07:45:31PM +, Matt Domsch wrote: > Triggered on Fedora rawhide kernel-2.6.17-1.2462.fc6 x86_64 which is > based on 2.6.18rc2-git6. IPv6 was in use at the time. > > = > [ INFO: inconsistent lock state ] > -

Re: Please pull 'upstream' branch of wireless-2.6

2006-07-28 Thread Jeff Garzik
pulled - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] mark sk98lin driver for removal

2006-07-28 Thread Jeff Garzik
ACK, however [EMAIL PROTECTED] netdev-2.6]$ git-applymbox /g/tmp/mbox ~/info/signoff.txt 1 patch(es) to process. Applying 'mark sk98lin driver for removal' error: patch failed: Documentation/feature-removal-schedule.txt:258 error: Documentation/feature-removal-schedule.txt: patch does not apply

Re: [RFC 1/4] kevent: core files.

2006-07-28 Thread Nicholas Miell
On Fri, 2006-07-28 at 20:38 -0700, Ulrich Drepper wrote: > Zach Brown wrote: > > Ulrich, would you be satisfied if we didn't > > have the userspace mapped ring on the first pass and only had a > > collection syscall? > > I'm not the one to make a call but why rush things? Let's do it right > from

Re: Please pull 'upstream-fixes' branch of wireless-2.6

2006-07-28 Thread Jeff Garzik
pulled - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC] Multiple IPV6 Routing Tables & Policy Routing

2006-07-28 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 28 Jul 2006 12:32:29 +0200), Thomas Graf <[EMAIL PROTECTED]> says: > * YOSHIFUJI Hideaki / ?$B5HF#1QL@ <[EMAIL PROTECTED]> 2006-07-28 15:10 > > Well, as you stated, the code is based on the work of MIPL, > > which is being jointly developed by Helsinki Univ

Re: [PATCH 2/5] [IPV6]: Multiple Routing Tables

2006-07-28 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 28 Jul 2006 21:14:28 -0700 (PDT)), David Miller <[EMAIL PROTECTED]> says: > For now I would suggest we use Thomas's approach, and we > can make performance measurements to determine if it makes > to optimize this or consider other methods. Okay. --yoshfuj

Re: [PATCH 2/5] [IPV6]: Multiple Routing Tables

2006-07-28 Thread David Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Sat, 29 Jul 2006 13:13:06 +0900 (JST) > Previously, we directly use address, ifindex etc., not flowi, > in IPv6 routing code except for ip6_route_output(). > This patch changes them to use flowi. > I know this should work and it is a good way for a

Re: [PATCH 4/3] forcedeth: fix NAPI hang in IRQ.

2006-07-28 Thread Andrew Morton
On Thu, 27 Jul 2006 19:01:14 -0700 Stephen Hemminger <[EMAIL PROTECTED]> wrote: > Fix for NAPI hanging in interrupt. With NAPI, we only need one > iteration over the IRQ. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> > > --- linux-2.6.orig/drivers/net/forcedeth.c2006-07-27 > 18:58

Re: [PATCH 2/5] [IPV6]: Multiple Routing Tables

2006-07-28 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article <[EMAIL PROTECTED]> (at Thu, 27 Jul 2006 00:00:02 +0200), Thomas Graf <[EMAIL PROTECTED]> says: > Adds the framework to support multiple IPv6 routing tables. Well, one design consideration that I have had for several months is performance impact. Previously, we directly use a

Re: [RFC 1/4] kevent: core files.

2006-07-28 Thread Ulrich Drepper
Zach Brown wrote: > Ulrich, would you be satisfied if we didn't > have the userspace mapped ring on the first pass and only had a > collection syscall? I'm not the one to make a call but why rush things? Let's do it right from the start. Later changes can only lead to problems with users of the

Re: [stable] [PATCH] e1000: add forgotten PCI ID for supported device

2006-07-28 Thread John W. Linville
On Fri, Jul 28, 2006 at 05:24:40PM -0700, Greg KH wrote: > On Fri, Jul 28, 2006 at 05:04:49PM -0700, Brandeburg, Jesse wrote: > > The kernel driver advertises through our probe table and in our readme > > that we support this device (code is in e1000_main.c) but we don't load on > > it correctly

Re: [RESEND 3/5] [NET]: Protocol Independant Policy Routing Rules Framework

2006-07-28 Thread Patrick McHardy
Martin Josefsson wrote: > As a somewhat related note, I've just digged a bit through RCU land, > talked to dipankar and mckenney, and discovered that rcu_read_lock() / > rcu_read_unlock() aren't strictly needed in softirqs since preempt is > already disabled in softirqs. This means that you can use

Re: [PATCH][SECURITY] secmark: nul-terminate secdata

2006-07-28 Thread Patrick McHardy
James Morris wrote: > The patch below fixes a problem in the iptables SECMARK target, where the > user-supplied 'selctx' string may not be nul-terminated. > >>From initial analysis, it seems that the strlen() called from > selinux_string_to_sid() could run until it arbitrarily finds a zero, and

Re: SMSC LAN911x and LAN921x vendor driver

2006-07-28 Thread Stephen Hemminger
Could the tasklet be replaced by using NAPI (dev->poll) routine? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [stable] [PATCH] e1000: add forgotten PCI ID for supported device

2006-07-28 Thread Greg KH
On Fri, Jul 28, 2006 at 05:04:49PM -0700, Brandeburg, Jesse wrote: > On Fri, 28 Jul 2006, Greg KH wrote: > > On Fri, Jul 28, 2006 at 03:06:17PM -0700, Auke Kok wrote: > > > > > > The Intel(R) PRO/1000 82572EI card is fully supported by 7.0.33-k2 and > > > onward. Add the device ID so this card work

Re: [stable] [PATCH] e1000: add forgotten PCI ID for supported device

2006-07-28 Thread Brandeburg, Jesse
On Fri, 28 Jul 2006, Greg KH wrote: > On Fri, Jul 28, 2006 at 03:06:17PM -0700, Auke Kok wrote: > > > > The Intel(R) PRO/1000 82572EI card is fully supported by 7.0.33-k2 and > > onward. Add the device ID so this card works with 2.6.17.y onward. This > > device ID was accidentally omitted. > > Sor

Re: [stable] [PATCH] e1000: add forgotten PCI ID for supported device

2006-07-28 Thread Greg KH
On Fri, Jul 28, 2006 at 03:06:17PM -0700, Auke Kok wrote: > > The Intel(R) PRO/1000 82572EI card is fully supported by 7.0.33-k2 and > onward. Add the device ID so this card works with 2.6.17.y onward. This > device ID was accidentally omitted. Sorry, but we don't add new device support in the

Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-07-28 Thread Ben Greear
David Miller wrote: From: Christophe Devriese <[EMAIL PROTECTED]> Date: Sat, 29 Jul 2006 00:58:59 +0200 On Fri, Jul 28, 2006 at 03:08:49PM -0700, Ben Greear wrote: Christophe Devriese wrote: On Fri, Jul 28, 2006 at 02:55:17PM -0700, Ben Greear wrote: Christophe Devriese wrote: I basi

Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-07-28 Thread David Miller
From: Christophe Devriese <[EMAIL PROTECTED]> Date: Sat, 29 Jul 2006 00:58:59 +0200 > On Fri, Jul 28, 2006 at 03:08:49PM -0700, Ben Greear wrote: > > Christophe Devriese wrote: > > >On Fri, Jul 28, 2006 at 02:55:17PM -0700, Ben Greear wrote: > > > > > >>Christophe Devriese wrote: > > >> > > >>>I b

Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-07-28 Thread Christophe Devriese
On Fri, Jul 28, 2006 at 03:08:49PM -0700, Ben Greear wrote: > Christophe Devriese wrote: > >On Fri, Jul 28, 2006 at 02:55:17PM -0700, Ben Greear wrote: > > > >>Christophe Devriese wrote: > >> > >>>I basically move the skb_bond method into if_bonding.h, include that file > >>>in if_vlan ( and call i

[PATCH] e1000: add forgotten PCI ID for supported device

2006-07-28 Thread Auke Kok
The Intel(R) PRO/1000 82572EI card is fully supported by 7.0.33-k2 and onward. Add the device ID so this card works with 2.6.17.y onward. This device ID was accidentally omitted. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> diff --git a/drivers/net/e1000/e1000_hw.c b/drivers/net/e1000/e1000_hw

Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-07-28 Thread Christophe Devriese
On Fri, Jul 28, 2006 at 02:55:17PM -0700, Ben Greear wrote: > Christophe Devriese wrote: > >I basically move the skb_bond method into if_bonding.h, include that file > >in if_vlan ( and call it from the vlan forwarding path, and the netif_rx > >routine ). > > > >Somehow this patch is very incomple

Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-07-28 Thread Ben Greear
Christophe Devriese wrote: I basically move the skb_bond method into if_bonding.h, include that file in if_vlan ( and call it from the vlan forwarding path, and the netif_rx routine ). Somehow this patch is very incomplete. Let me try again. The patch looks sane this time. The skb_bond meth

Re: SMSC LAN911x and LAN921x vendor driver

2006-07-28 Thread Francois Romieu
[...] > diff --git a/drivers/net/smsc911x.c b/drivers/net/smsc911x.c > new file mode 100644 > index 000..12bbe67 > --- /dev/null > +++ b/drivers/net/smsc911x.c [...] > +/* Tasklet declarations */ > +static unsigned long rx_tasklet_parameter; > +static void smsc911x_rx_tasklet(unsigned long data

Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-07-28 Thread Christophe Devriese
I basically move the skb_bond method into if_bonding.h, include that file in if_vlan ( and call it from the vlan forwarding path, and the netif_rx routine ). Somehow this patch is very incomplete. Let me try again. sorry for the trouble. (I'm new at this) Regards, Christophe > Christophe Dev

Re: [PATCH 2/7] NetLabel: core network changes

2006-07-28 Thread Paul Moore
David Miller wrote: > From: Paul Moore <[EMAIL PROTECTED]> > Date: Fri, 28 Jul 2006 16:09:15 -0400 > >>Okay. I stated earlier today that I would push a new patchset out to >>the list this weekend or perhaps today, but in light of this I think >>I'll wait until I have had a chance to make this cha

[PATCH][SECURITY] secmark: nul-terminate secdata

2006-07-28 Thread James Morris
The patch below fixes a problem in the iptables SECMARK target, where the user-supplied 'selctx' string may not be nul-terminated. >From initial analysis, it seems that the strlen() called from selinux_string_to_sid() could run until it arbitrarily finds a zero, and possibly cause a kernel oops

Re: [PATCH 2/7] NetLabel: core network changes

2006-07-28 Thread David Miller
From: Paul Moore <[EMAIL PROTECTED]> Date: Fri, 28 Jul 2006 16:09:15 -0400 > Okay. I stated earlier today that I would push a new patchset out to > the list this weekend or perhaps today, but in light of this I think > I'll wait until I have had a chance to make this change which should be > some

Re: r8169 driver problem with RTL8110SB chip (on iop3xx ARM board)

2006-07-28 Thread Martin Michlmayr
* Francois Romieu <[EMAIL PROTECTED]> [2006-07-28 21:49]: > The (untested) patch below should apply to the source code that Realtek > included in linux-r1000(103).zip, wherence supporting the extraction > of the same info. Note quite. I also had to add the patch below but now it's working: Offse

Re: [PATCH 2/7] NetLabel: core network changes

2006-07-28 Thread Paul Moore
David Miller wrote: > From: Paul Moore <[EMAIL PROTECTED]> > Date: Fri, 28 Jul 2006 15:08:44 -0400 > >>Thanks for your feedback but unless I hear from others that this >>is a requirement I think I'm going to leave the code as written for the >>reasons I listed above. > > Please switch over to th

Re: [PATCH 2/7] NetLabel: core network changes

2006-07-28 Thread David Miller
From: Paul Moore <[EMAIL PROTECTED]> Date: Fri, 28 Jul 2006 15:08:44 -0400 > Thanks for your feedback but unless I hear from others that this > is a requirement I think I'm going to leave the code as written for the > reasons I listed above. Please switch over to the scheme which Thomas has sugge

Re: [PATCH 2/7] NetLabel: core network changes

2006-07-28 Thread David Miller
From: Paul Moore <[EMAIL PROTECTED]> Date: Fri, 28 Jul 2006 14:45:53 -0400 > I'm happy to drop this hook as it *looks* like the MLSXFRM patchset is > going to make it which has some of the accept hooks I was hoping to get, > but figured I stood a "snowballs chance in hell" trying to get it in > so

Re: tg3 module problem with suspend2

2006-07-28 Thread Lamarque Souza
I have this problem since I first tried to use suspend. The first kernel I tried was 2.6.13 I guess. Since that time I reload the driver, then I do not know if it works with kernel 2.6.14, 2.6.15 or 2.6.16 without reloading. - Lamarque V. Souza http://www.geographicguide.com/brazil.htm Lin

Re: r8169 driver problem with RTL8110SB chip (on iop3xx ARM board)

2006-07-28 Thread Francois Romieu
Martin Michlmayr <[EMAIL PROTECTED]> : [...] > Here's the output using the r8169 driver: > > RealTek RTL-8110 registers: > -- The (untested) patch below should apply to the source code that Realtek included in linux-r1000(103).zip, wherence supporting the extraction of

Re: [PATCH 2/7] NetLabel: core network changes

2006-07-28 Thread Evgeniy Polyakov
On Fri, Jul 28, 2006 at 03:08:44PM -0400, Paul Moore ([EMAIL PROTECTED]) wrote: > > Not a requirement but I would encourage it. Almost all netlink > > families are using attributes with a few exceptions. We just > > used to call them rtattr defined in rtnetlink.h before the new > > api was added. T

lockdep tcp_v6_rcv message

2006-07-28 Thread Matt Domsch
Triggered on Fedora rawhide kernel-2.6.17-1.2462.fc6 x86_64 which is based on 2.6.18rc2-git6. IPv6 was in use at the time. = [ INFO: inconsistent lock state ] - inconsistent {softirq-on-W} -> {in-softirq-R} usage. swapper/0 [HC0[0]:

Re: [RFC 1/4] kevent: core files.

2006-07-28 Thread Zach Brown
>>> Clearly we should port httpd to kevents and take some measurements :) oh, I see, I forgot the 't' in 'thttpd'. My mistake. - z - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/maj

Re: [RFC 1/4] kevent: core files.

2006-07-28 Thread Zach Brown
Evgeniy Polyakov wrote: > On Fri, Jul 28, 2006 at 12:01:28PM -0700, Zach Brown ([EMAIL PROTECTED]) > wrote: >> Clearly we should port httpd to kevents and take some measurements :) > > One of my main kevent benchmarks (socket notifications for > accept/receive) is handmade http server. Yeah, so

Re: [RFC 1/4] kevent: core files.

2006-07-28 Thread Evgeniy Polyakov
On Fri, Jul 28, 2006 at 12:01:28PM -0700, Zach Brown ([EMAIL PROTECTED]) wrote: > Clearly we should port httpd to kevents and take some measurements :) One of my main kevent benchmarks (socket notifications for accept/receive) is handmade http server. I compared it with FreeBSD kqueue, epoll and k

Re: [RFC 1/4] kevent: core files.

2006-07-28 Thread Zach Brown
> So, I'm going to create kevent_create/destroy/control and kevent_get_events() > Or any better names? Yeah, that sounds good. > Some events are impossible to create in userspace (like timer > notification, which requires timer start and check when timer > completed). We're not talking about *c

Re: [PATCH 2/7] NetLabel: core network changes

2006-07-28 Thread Paul Moore
Thomas Graf wrote: > * Paul Moore <[EMAIL PROTECTED]> 2006-07-28 14:39 > >>It sounds like you main concern is that I'm not using the netlink >>attribute interfaces, yes? I looked at using those originally but >>decided not to use them for the following reasons: >> >> 1. They are listed as "option

Re: [PATCH 2/7] NetLabel: core network changes

2006-07-28 Thread Thomas Graf
* Paul Moore <[EMAIL PROTECTED]> 2006-07-28 14:39 > It sounds like you main concern is that I'm not using the netlink > attribute interfaces, yes? I looked at using those originally but > decided not to use them for the following reasons: > > 1. They are listed as "optional" in the documents I r

Re: [RFC 1/4] kevent: core files.

2006-07-28 Thread Zach Brown
> Things were like that at one point in time, but file descriptors turn out > to introduce a huge gaping security hole with SUID programs. The problem > is that any event context is closely tied to the address space of the > thread issuing the syscalls, and file descriptors do not have this cl

Re: [PATCH 1/7] NetLabel: documentation

2006-07-28 Thread Paul Moore
David Miller wrote: > From: [EMAIL PROTECTED] > Date: Mon, 17 Jul 2006 11:52:25 -0400 > > >>+CIPSOv4 Variables: >>+ >>+cipso_cache_enable - BOOLEAN > > ... > >>+cipso_cache_bucket_size - INTEGER > > ... > >>+cipso_rbm_optfmt - BOOLEAN > > ... > >>+cipso_rbm_structvalid - BOOLEAN > > ..

Re: [PATCH 2/7] NetLabel: core network changes

2006-07-28 Thread Paul Moore
David Miller wrote: > From: [EMAIL PROTECTED] > Date: Mon, 17 Jul 2006 11:52:26 -0400 >>@@ -617,6 +618,8 @@ int inet_accept(struct socket *sock, str >> >> sock_graft(sk2, newsock); >> >>+ netlbl_socket_inet_accept(sock, newsock); >>+ >> newsock->state = SS_CONNECTED; >> err = 0

Re: [RFC 1/4] kevent: core files.

2006-07-28 Thread Evgeniy Polyakov
On Fri, Jul 28, 2006 at 11:33:16AM -0700, Zach Brown ([EMAIL PROTECTED]) wrote: > > > I completely agree that existing kevent interface is not the best, so > > I'm opened for any suggestions. > > Should kevent creation/removing/modification be separated too? > > Yeah, I think so. So, I'm going t

Re: [PATCH 2/7] NetLabel: core network changes

2006-07-28 Thread Paul Moore
Thomas Graf wrote: > * Paul Moore <[EMAIL PROTECTED]> 2006-07-28 13:58 > >>I'm a little confused by your comment, could you be a bit more >>specific? Are you basing your comment strictly on the text above? If >>so, the problem may be my poor excuse for documentation rather then my >>poor excuse

[PATCH Round 5 2/3] Core net changes to generate netevents

2006-07-28 Thread Steve Wise
Generate netevents for: - neighbour changes - routing redirects - pmtu changes --- net/core/Makefile|2 +- net/core/neighbour.c | 14 -- net/ipv4/route.c |8 net/ipv6/route.c |7 +++ 4 files changed, 24 insertions(+), 7 deletions(-) diff --git

[PATCH Round 5 3/3] Cleanup ib_addr module to use the netevents

2006-07-28 Thread Steve Wise
--- drivers/infiniband/core/addr.c | 30 ++ 1 files changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c index d294bbc..1205e80 100644 --- a/drivers/infiniband/core/addr.c +++ b/drivers/infiniband/

[PATCH Round 5 0/3] Network Event Notifier Mechanism

2006-07-28 Thread Steve Wise
Dave/Roland, is this patchset about ready to go? Round 5 Changes: - removed user-mode support - removed route add/del events. -- This patch implements a mechanism that allows interested clients to register for notification of certain network events. The intended use is to allow RDMA device

[PATCH Round 5 1/3] Network Event Notifier Mechanism.

2006-07-28 Thread Steve Wise
This patch uses notifier blocks to implement a network event notifier mechanism. Clients register their callback function by calling register_netevent_notifier() like this: static struct notifier_block nb = { .notifier_call = my_callback_func }; ... register_netevent_notifier(&nb); ---

Re: [RFC 1/4] kevent: core files.

2006-07-28 Thread Zach Brown
> I completely agree that existing kevent interface is not the best, so > I'm opened for any suggestions. > Should kevent creation/removing/modification be separated too? Yeah, I think so. >>> Hmm, it looks like I'm lost here... >> Yeah, it seems my description might not have sunk in :). We're

Re: [RFC 6/8] NetLabel: CIPSOv4 integration

2006-07-28 Thread Paul Moore
Jamal Hadi Salim wrote: > On Thu, 2006-22-06 at 18:49 -0400, [EMAIL PROTECTED] wrote: >>+/** >>+ * netlbl_cipsov4_rcv - Process incoming NetLabel packets >>+ * @skb: the NETLINK buffer >>+ * @msg: pointer to the start of the NetLabel data >>+ * >>+ * Description: >>+ * This function is reponsibile

Re: [PATCH 2/7] NetLabel: core network changes

2006-07-28 Thread Thomas Graf
* Paul Moore <[EMAIL PROTECTED]> 2006-07-28 13:58 > I'm a little confused by your comment, could you be a bit more > specific? Are you basing your comment strictly on the text above? If > so, the problem may be my poor excuse for documentation rather then my > poor excuse for implementation :) >

Re: [PATCH 2/7] NetLabel: core network changes

2006-07-28 Thread Paul Moore
Thomas Graf wrote: > * [EMAIL PROTECTED] <[EMAIL PROTECTED]> 2006-07-17 11:52 > >>+ * NetLabel makes use of the Generic NETLINK mechanism as a transport layer >>to >>+ * send messages between kernel and user space. The general format of a >>+ * NetLabel message is shown below: >>+ * >>+ * +

Re: PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-07-28 Thread Ben Greear
This patch by itself does nothing useful, other than remove a method. If we assume you did the patch backwards, and wanted to add the method instead, then where is this method ever called? Ben Christophe Devriese wrote: diff -rU3 linux-2.6.17.7/net/core/dev.c linux-2.6.17.7-wapper/net/core/de

Re: Debugging kernel lockups during network activity

2006-07-28 Thread Jarek Poplawski
On 27-07-2006 20:19, Art Haas wrote: Hi. I've got Fedora Rawhide running on a SMP PIII machine, and the latest kernels from Fedora have been locking up when I run 'yum update' to get the latest packages. I also experience lock-ups when I use Firefox to do some web browsing. Not all my network us

Re: SMSC LAN911x and LAN921x vendor driver

2006-07-28 Thread Stephen Hemminger
> +/* Tasklet declarations */ > +static unsigned long rx_tasklet_parameter; > +static void smsc911x_rx_tasklet(unsigned long data); > + > +DECLARE_TASKLET(rx_tasklet, smsc911x_rx_tasklet, 0); You can make this local with static DECLARE_TASKLET(rx_tasklet, smsc911x_rx_tasklet, 0); - To unsubscribe

Re: [PATCH 0/9] d80211: pull request

2006-07-28 Thread Jiri Benc
On Tue, 18 Jul 2006 17:45:20 +0200 (CEST), Jiri Benc wrote: > Please pull from > git://git.kernel.org/pub/scm/linux/kernel/git/jbenc/dscape.git master I renamed that branch to 'up'. Please pull from 'up' branch. > to obtain following patches: > > Jiri Benc: > d80211: do not receive through

Re: [PATCH] NET: fix kernel panic from no dev->hard_header_len space

2006-07-28 Thread Krzysztof Halasa
Krzysztof Halasa <[EMAIL PROTECTED]> writes: > Are you sure about that? It would mean almost devices, including ^^ > Ethernet, are at risk: "almost all devices", of course. -- Krzysztof Halasa - To unsubscribe from this list: send the line "un

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-28 Thread Sébastien Dugué
On Thu, 2006-07-27 at 14:02 -0700, Badari Pulavarty wrote: > On Thu, 2006-07-27 at 11:44 -0700, Ulrich Drepper wrote: > > Badari Pulavarty wrote: > > > Before we spend too much time cleaning up and merging into mainline - > > > I would like an agreement that what we add is good enough for glibc > >

Re: Regarding offloading IPv6 addrconf and ndisc

2006-07-28 Thread Jamal Hadi Salim
On Fri, 2006-28-07 at 09:34 +0100, Hugo Santos wrote: > > 2. What if user process dies? or gets overwhelmed? > >One of the assumptions of the any well designed kernel is that the > > system should never > >hang because some user application died or waited for ever. > >Of course that

Re: r8169 driver problem with RTL8110SB chip (on iop3xx ARM board)

2006-07-28 Thread Jamal Hadi Salim
On Fri, 2006-28-07 at 13:15 +0200, Lennert Buytenhek wrote: > On Fri, Jul 28, 2006 at 12:49:46PM +0200, Francois Romieu wrote: > > > > The in-kernel 'r8169' drivers in 2.6.17 and 2.6.18-rc2 appear to work > > > initially, but they don't actually seem to transmit any packets on the > > > wire, nor

Re: [RFC 6/8] NetLabel: CIPSOv4 integration

2006-07-28 Thread Jamal Hadi Salim
On Thu, 2006-22-06 at 18:49 -0400, [EMAIL PROTECTED] wrote: > plain text document attachment (netlabel-cipsov4) > Add CIPSO/IPv4 support and management to the NetLabel subsystem. These > changes > integrate the CIPSO/IPv4 configuration into the existing NetLabel code and > enable the use of CIPSO

Re: r8169 driver problem with RTL8110SB chip (on iop3xx ARM board)

2006-07-28 Thread Martin Michlmayr
* Lennert Buytenhek <[EMAIL PROTECTED]> [2006-07-28 13:15]: > > - an ethtool dump of the registers. I don't know if Realtek's > > driver support but it can help even the in-kernel driver > > I'll ask someone else with the same board to do the test and will > post the results. Here's the output us

Re: [PATCH 2/7] NetLabel: core network changes

2006-07-28 Thread Thomas Graf
* [EMAIL PROTECTED] <[EMAIL PROTECTED]> 2006-07-17 11:52 > + * NetLabel makes use of the Generic NETLINK mechanism as a transport layer > to > + * send messages between kernel and user space. The general format of a > + * NetLabel message is shown below: > + * > + * +-+--

Re: [PATCH] SNMPv2 tcpAttemptFails counter error

2006-07-28 Thread Wei Yongjun
I have changed my patch with your advice and it looks more effective. On Monday 24 July 2006 17:22, David Miller wrote: > From: Wei Yongjun <[EMAIL PROTECTED]> > Date: Wed, 05 Jul 2006 05:19:54 -0400 > > > In my test, those direct state transition can not be counted to > > tcpAttemptFails. Followi

Re: r8169 driver problem with RTL8110SB chip (on iop3xx ARM board)

2006-07-28 Thread Lennert Buytenhek
On Fri, Jul 28, 2006 at 12:49:46PM +0200, Francois Romieu wrote: > > The in-kernel 'r8169' drivers in 2.6.17 and 2.6.18-rc2 appear to work > > initially, but they don't actually seem to transmit any packets on the > > wire, nor do they receive any. > > > > Boot logs from 2.6.17 and 2.6.18-rc2 att

Re: r8169 driver problem with RTL8110SB chip (on iop3xx ARM board)

2006-07-28 Thread Francois Romieu
Lennert Buytenhek <[EMAIL PROTECTED]> : [...] > We're currently working on getting the Thecus n2100 supported in 2.6. > > http://www.thecus.com/products_over.php?cid=1&pid=1 I should really write some wish-list one day... > Amongst other nice goodies, it has two on-board RTL8110SB gigabit

FACK and CWND

2006-07-28 Thread Ma Lin
Hi there, A question related to TCP-FACK, which is a default in Linux: In FACK, the holes between SACK blocks are considered as loss. To a sender, when SACK comes in, loss_out would be non-zero. According to linux-2.6.17.7/net/ipv4/tcp_input.c, function tcp_time_to_recover(), this non-zero loss_o

Re: [RFC] Multiple IPV6 Routing Tables & Policy Routing

2006-07-28 Thread Thomas Graf
* YOSHIFUJI Hideaki / ?$B5HF#1QL@ <[EMAIL PROTECTED]> 2006-07-28 15:10 > Well, as you stated, the code is based on the work of MIPL, > which is being jointly developed by Helsinki University of Technology (HUT) > and USAGI/WIDE Project. Please describe this on your commit logs. > Please retain cop

Re: [RESEND 3/5] [NET]: Protocol Independant Policy Routing Rules Framework

2006-07-28 Thread Thomas Graf
* Patrick McHardy <[EMAIL PROTECTED]> 2006-07-28 01:30 > > +int fib_rules_lookup(struct fib_rules_ops *ops, struct flowi *fl, > > +int flags, struct fib_lookup_arg *arg) > > +{ > > + struct fib_rule *rule; > > + int err; > > + > > + rcu_read_lock(); > > + > > + list_for_each

Re: [PATCH] Create IP100A Driver

2006-07-28 Thread Jeff Garzik
Jesse Huang wrote: Hi John: I will try mutt or mail when i want to send next patch. Most different of ip100a.c and sundance.c are almost same only fix some bugs. The different of ip100a and ip100 is in phy. We can use one driver to support those two device, I want to know what is better for kern

r8169 driver problem with RTL8110SB chip (on iop3xx ARM board)

2006-07-28 Thread Lennert Buytenhek
Hi! We're currently working on getting the Thecus n2100 supported in 2.6. http://www.thecus.com/products_over.php?cid=1&pid=1 Amongst other nice goodies, it has two on-board RTL8110SB gigabit controllers. The realtek-supplied 'r1000' driver kind of sort of works, if you don't mind the m

PATCH Fix bonding active-backup behavior for VLAN interfaces

2006-07-28 Thread Christophe Devriese
diff -rU3 linux-2.6.17.7/net/core/dev.c linux-2.6.17.7-wapper/net/core/dev.c --- linux-2.6.17.7/net/core/dev.c 2006-07-25 05:36:01.0 +0200 +++ linux-2.6.17.7-wapper/net/core/dev.c2006-07-27 20:16:36.0 +0200 @@ -88,6 +88,7 @@ #include #include #include +#include

Re: [RESEND 3/5] [NET]: Protocol Independant Policy Routing Rules Framework

2006-07-28 Thread Martin Josefsson
On Fri, 2006-07-28 at 00:58 +0200, Patrick McHardy wrote: > > +int fib_rules_lookup(struct fib_rules_ops *ops, struct flowi *fl, > > +int flags, struct fib_lookup_arg *arg) > > +{ > > + struct fib_rule *rule; > > + int err; > > + > > + rcu_read_lock(); > > + > > + list_for_

Re: Hello, We have IP100A Linux driver need to submit to 2.6.x kernel

2006-07-28 Thread Arjan van de Ven
On Fri, 2006-07-28 at 09:55 +0800, Jesse Huang wrote: > Hi Francois: > > Sorry, I don't know this patch before. IP100A is a new version of IP100 > (sundance.c). I don't know what is you suggestion of IP100A driver? Should > I... > > 1. Only updata sundance.c to support IP100A > 2. Release ip1

Re: [RFC] [IPV6] ADDRCONF: Lifetime handling fixes

2006-07-28 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 28 Jul 2006 17:18:18 +0900 (JST)), YOSHIFUJI Hideaki <[EMAIL PROTECTED]> says: > In article <[EMAIL PROTECTED]> (at Fri, 28 Jul 2006 01:11:03 -0700 (PDT)), > David Miller <[EMAIL PROTECTED]> says: > > > Besides this correction, the rest of the changes loo

Re: [PATCH 1/3] add netdev_alloc_skb

2006-07-28 Thread Christoph Hellwig
On Fri, Jul 28, 2006 at 01:28:32AM -0700, David Miller wrote: > From: Christoph Hellwig <[EMAIL PROTECTED]> > Date: Fri, 28 Jul 2006 10:27:12 +0200 > > > We need a fixup patch for the existing wrong comments on dev_alloc_skb > > anyway - but if you prefer to respin the netdev_alloc_skb and have >

Re: Regarding offloading IPv6 addrconf and ndisc

2006-07-28 Thread Hugo Santos
> A couple of basic questions: > 1. Can we just proceed assuming it is non-secure until a later time when >the certificate path is established? This is not something which is described in the standard. In fact, processing the RA without a certificate path to the router already assumes the

Re: [PATCH 1/3] add netdev_alloc_skb

2006-07-28 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Fri, 28 Jul 2006 10:27:12 +0200 > We need a fixup patch for the existing wrong comments on dev_alloc_skb > anyway - but if you prefer to respin the netdev_alloc_skb and have > another patch to fixup the original comments I can do that aswell. I in

Re: [PATCH 1/3] add netdev_alloc_skb

2006-07-28 Thread Christoph Hellwig
On Fri, Jul 28, 2006 at 01:24:24AM -0700, David Miller wrote: > From: Christoph Hellwig <[EMAIL PROTECTED]> > Date: Fri, 28 Jul 2006 09:08:51 +0200 > > > Yes, Joe Perches already pointed that out in private. This typo is copy > > and pasted from the dev_alloc_skb kerneldoc, so this patch fixes up

Re: [PATCHv2 2.6.18-rc1-mm2 1/3] net: UDP-Lite generic support

2006-07-28 Thread David Miller
From: Gerrit Renker <[EMAIL PROTECTED]> Date: Fri, 28 Jul 2006 09:19:55 +0100 > I will start with the v4-side and post a small RFC patch to see whether > I got the concepts right. (Due to vacation, this will not before mid/end > of August.) Ok, I look forward to reviewing it. - To unsubscribe f

Re: Netchannles: first stage has been completed. Further ideas.

2006-07-28 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 27 Jul 2006 11:54:19 -0700 > I think we sell our existing stack short. I agree. > There are lots of opportunities left to look more closely at actual > real performance bottlenecks and improve incrementally. But it > requires, tools, time, f

Re: [RFC] Multiple IPV6 Routing Tables & Policy Routing

2006-07-28 Thread David Miller
From: YOSHIFUJI Hideaki <[EMAIL PROTECTED]> Date: Fri, 28 Jul 2006 15:10:09 +0900 (JST) > Well, as you stated, the code is based on the work of MIPL, > which is being jointly developed by Helsinki University of Technology (HUT) > and USAGI/WIDE Project. Please describe this on your commit logs. >

Re: [PATCH 1/3] add netdev_alloc_skb

2006-07-28 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Fri, 28 Jul 2006 09:08:51 +0200 > Yes, Joe Perches already pointed that out in private. This typo is copy > and pasted from the dev_alloc_skb kerneldoc, so this patch fixes up all > four occurances: > > Signed-off-by: Christoph Hellwig <[EMAIL PR

Re: [PATCHv2 2.6.18-rc1-mm2 1/3] net: UDP-Lite generic support

2006-07-28 Thread Gerrit Renker
Hi David, thank you very much for taking time to revise the code and for the detailed comments. | The amount of code duplication is absolutely enormous and | totally unnecessary. You are right. So far I thought it better to keep UDP and UDP-Lite separate but an intelligent code integration d

Re: [RFC] [IPV6] ADDRCONF: Lifetime handling fixes

2006-07-28 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Fri, 28 Jul 2006 01:11:03 -0700 (PDT)), David Miller <[EMAIL PROTECTED]> says: > Besides this correction, the rest of the changes look fine to me. > I think we should get these fixes into 2.6.18, if you don't mind. > > So please resubmit with the correction. O

Re: [RFC] [IPV6] ADDRCONF: Lifetime handling fixes

2006-07-28 Thread David Miller
From: Noriaki TAKAMIYA <[EMAIL PROTECTED]> Date: Thu, 27 Jul 2006 19:49:29 +0900 (JST) > >> Thu, 27 Jul 2006 11:28:02 +0100 > >> [Subject: Re: [RFC] [IPV6] ADDRCONF: Lifetime handling fixes] wrote... > >> Hugo Santos <[EMAIL PROTECTED]> wrote... > > > > + ifp = ipv6_get_ifaddr(pfx, dev, 1); > > >

Re: [PATCH] sunlance: fix compilation on sparc-UP

2006-07-28 Thread David Miller
From: Alexey Dobriyan <[EMAIL PROTECTED]> Date: Thu, 27 Jul 2006 13:35:20 +0400 > Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]> Applied, thanks Alexey. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at ht

Re: 2.6.18-rc2-mm1

2006-07-28 Thread Reuben Farrelly
On 27/07/2006 8:56 p.m., Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc2/2.6.18-rc2-mm1/ - git-klibc has been dropped due to very bad parallel-make problems. - Added a new line to the boilerplate, below! - Added Sam's lxdialog tree, as git-lxdial

Re: [PATCH 3/7] NetLabel: CIPSOv4 engine

2006-07-28 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 17 Jul 2006 11:52:27 -0400 > + cipso_v4_cache[iter].lock = SPIN_LOCK_UNLOCKED; Please use: "spin_lock_init(&cipso_v4_cache[iter].lock);" - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED

Re: [PATCH 2/7] NetLabel: core network changes

2006-07-28 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 17 Jul 2006 11:52:26 -0400 > @@ -617,6 +618,8 @@ int inet_accept(struct socket *sock, str > > sock_graft(sk2, newsock); > > + netlbl_socket_inet_accept(sock, newsock); > + > newsock->state = SS_CONNECTED; > err = 0; > release_sock(

Re: [PATCH 1/7] NetLabel: documentation

2006-07-28 Thread David Miller
From: [EMAIL PROTECTED] Date: Mon, 17 Jul 2006 11:52:25 -0400 > +CIPSOv4 Variables: > + > +cipso_cache_enable - BOOLEAN ... > +cipso_cache_bucket_size - INTEGER ... > +cipso_rbm_optfmt - BOOLEAN ... > +cipso_rbm_structvalid - BOOLEAN ... We need some more information for these entries. First

Re: [3/4] kevent: AIO, aio_sendfile() implementation.

2006-07-28 Thread Sébastien Dugué
On Thu, 2006-07-27 at 14:02 -0700, Badari Pulavarty wrote: > On Thu, 2006-07-27 at 11:44 -0700, Ulrich Drepper wrote: > > Badari Pulavarty wrote: > > > Before we spend too much time cleaning up and merging into mainline - > > > I would like an agreement that what we add is good enough for glibc > >

  1   2   >