From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Sat, 16 Jun 2007 02:04:25 +0300 (EEST)
> On Fri, 15 Jun 2007, David Miller wrote:
>
> > Patch applied.
>
> ...I think it should go to stable as well.
I thought Baruch's DSACK seperation that created this problem didn't
go in until 2.6.22?
-
To un
On Wed, 13 Jun 2007, Michal Piotrowski wrote:
>
> Subject: hibernate(?) fails totally - regression
> References : http://lkml.org/lkml/2007/6/1/401
> Submitter : David Greaves <[EMAIL PROTECTED]>
> Handled-By : Rafael J. Wysocki <[EMAIL PROTECTED]>
> Caused-By : Tejun Heo <[EMAIL PROTECTED
On Fri, 15 Jun 2007, David Miller wrote:
> From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
> Date: Fri, 15 Jun 2007 16:07:37 +0300 (EEST)
>
> > Commit 6f74651ae626ec672028587bc700538076dfbefb is found guilty
> > of breaking DSACK counting, which should be done only for the
> > SACK block reported by th
From: Adrian Bunk <[EMAIL PROTECTED]>
Date: Fri, 15 Jun 2007 23:45:20 +0200
> This patch removes dead code spotted by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
I'll let David H. decide how to handle these cleanups
and simplifications. Thanks Adrian.
-
To unsubscri
From: Adrian Bunk <[EMAIL PROTECTED]>
Date: Fri, 15 Jun 2007 23:45:13 +0200
> This patch fixes a NULL dereference spotted by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Looks good to me, patch applied, thanks Adrian.
-
To unsubscribe from this list: send the line "un
From: "Ilpo_Järvinen" <[EMAIL PROTECTED]>
Date: Fri, 15 Jun 2007 16:07:37 +0300 (EEST)
> Commit 6f74651ae626ec672028587bc700538076dfbefb is found guilty
> of breaking DSACK counting, which should be done only for the
> SACK block reported by the DSACK instead of every SACK block
> that is received
From: Vlad Yasevich <[EMAIL PROTECTED]>
Date: Fri, 15 Jun 2007 16:42:22 -0400
> No, the questions should really be:
>
> 1. Is IPV6 supported over this media type.
> yes: got to 2
> no: stop
>
> 2. Is the device MTU >= IPV6_MIN_MTU
> yes: continue
> no: stop
>
> Autoc
From: Stephen Hemminger <[EMAIL PROTECTED]>
Date: Fri, 15 Jun 2007 07:32:55 -0700
> On Fri, 15 Jun 2007 12:30:12 +0300 (EEST)
> "Ilpo Järvinen" <[EMAIL PROTECTED]> wrote:
>
> > Commit 164891aadf1721fca4dce473bb0e0998181537c6 broke RTT
> > sampling of congestion control modules. Inaccurate timesta
On Friday, 15 June 2007 23:50, David Greaves wrote:
> I've started a new thread here since the old one got somewhat hijacked.
>
> Rafael J. Wysocki wrote:
> > On Friday, 1 June 2007 23:23, David Greaves wrote:
> >> Not a regression though, it does it in 2.6.21
> >>
> >> If I cause the system t
I've started a new thread here since the old one got somewhat hijacked.
Rafael J. Wysocki wrote:
> On Friday, 1 June 2007 23:23, David Greaves wrote:
>> Not a regression though, it does it in 2.6.21
>>
>> If I cause the system to save state to disk then whilst off it no longer
>> responds to g-wo
This patch removes dead code spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
net/rxrpc/ar-output.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
--- linux-2.6.22-rc4-mm2/net/rxrpc/ar-output.c.old 2007-06-15
21:38:02.0
This patch fixes a NULL dereference spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
---
net/rxrpc/ar-connection.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.22-rc4-mm2/net/rxrpc/ar-connection.c.old 2007-06-15
23:05:26.0 +020
Oliver Hartkopp wrote:
> Hallo David, hello Herbert,
>
> indeed i have some concerns about reverting the patch as i do not see
> that the MTU is the right thing to distinguish whether a netdevice is
> capable to have IPv4/IPv6. E.g. is decnet able to run IPv6?
>
> IMHO the autoconf (in any case)
Hi Dan.
Dan Williams wrote:
> On Fri, 2007-06-15 at 10:16 -0700, Geoff Levand wrote:
>> This all seems fine, but what is causing us trouble is that
>> during the review of the wireless part Dan Williams made many
>> non-trivial recommendations, and so we decided we need to re-work
>
> sorry :)
I
On Fri, 2007-06-15 at 10:16 -0700, Geoff Levand wrote:
> Jeff Garzik wrote:
> > MOKUNO Masakazu wrote:
> >> +config GELIC_NET
> >> + tristate "PS3 Gigabit Ethernet driver"
> >> + depends on PPC_PS3
> >> + help
> >> +This driver supports the Gigabit Ethernet device on the
> >> +PS3 game c
On 6/15/07, Kieran Mansley <[EMAIL PROTECTED]> wrote:
The lock protects the use_count variable. The use_count variable
prevents the plugin module unloading while it is being used. I couldn't
just use the lock to prevent the module unloading as the hook function
(i) might block (and holding a s
> - "if (ret == NETDEV_TX_LOCKED && lockless)" is buggy, and
> the lockless
> check should be removed, since driver will return
> NETDEV_TX_LOCKED only
> if lockless is true and driver has to do the locking. In
> the original
> code as well as the latest code, this code can result in a bug
Jeff Garzik wrote:
> MOKUNO Masakazu wrote:
>> +config GELIC_NET
>> +tristate "PS3 Gigabit Ethernet driver"
>> +depends on PPC_PS3
>> +help
>> + This driver supports the Gigabit Ethernet device on the
>> + PS3 game console.
>> +
>> + To compile this driver as a module, ch
On 15/6/07 17:22, "Kieran Mansley" <[EMAIL PROTECTED]> wrote:
> The lock protects the use_count variable.
Yes, that's one thing I noticed -- can you use atomic_t for reference counts
and hence reduce the number of times you need to lock/unlock? At least the
open-coded lock-decrement-test-maybe-fr
On Fri, 2007-06-15 at 11:59 -0400, Zhu Han wrote:
> Hi, Kieran,
>
> I'm just wonder why you try to acquire the lock and increase the
> hooks_usecount each time when you use the hook routine. Is there any
> generic ways to synchronze the code path using hook routines and
> netfront_accelerator_unlo
On Fri, 15 Jun 2007 11:59:43 -0400
"Zhu Han" <[EMAIL PROTECTED]> wrote:
> Hi, Kieran,
>
> I'm just wonder why you try to acquire the lock and increase the
> hooks_usecount each time when you use the hook routine. Is there any
> generic ways to synchronze the code path using hook routines and
> ne
Hi, Kieran,
I'm just wonder why you try to acquire the lock and increase the
hooks_usecount each time when you use the hook routine. Is there any
generic ways to synchronze the code path using hook routines and
netfront_accelerator_unloaded, considering you can synchronize the
tx/rx data path eas
Wolfgang Nothdurft wrote:
Hi,
with the new e1000 driver version 7.3.20 the onboard gigabit nic 82547EI
(8086:1019) doesn't work correctly.
After transferring about 100 megabytes over a gigabit link the transfer
stopped and I have to reinit the link either by doing a ifconfig down/up
or unpluggin
Milton Miller wrote:
On Jun 6, 2007, at 4:28 AM, Milton Miller wrote:
On Jun 5, 2007, at 9:26 PM, Kok, Auke wrote:
Kok, Auke wrote:
Hmm git-revert seems to do the job right. I checked it with git-show
| patch -p1 -R and the results look OK. The two patches on top of
the one we want to r
On Fri, 15 Jun 2007 12:30:12 +0300 (EEST)
"Ilpo Järvinen" <[EMAIL PROTECTED]> wrote:
> Commit 164891aadf1721fca4dce473bb0e0998181537c6 broke RTT
> sampling of congestion control modules. Inaccurate timestamps
> could be fed to them without providing any way for them to
> identify such cases. Previ
On Fri, Jun 15 2007, Evgeniy Polyakov wrote:
> On Fri, Jun 15, 2007 at 11:34:30AM +0200, Jens Axboe ([EMAIL PROTECTED])
> wrote:
> > > Both spd->nr_pages and page_nr are equal to 1. When spd->nr_pages
> > > was 2 there was only 1 free slot in pipe_buffer.
> >
> > Ah duh, indeed, it is a dumb bug
Commit 6f74651ae626ec672028587bc700538076dfbefb is found guilty
of breaking DSACK counting, which should be done only for the
SACK block reported by the DSACK instead of every SACK block
that is received along with DSACK information.
Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
---
net/ipv4/t
On 15/6/07 13:21, "Michael Buesch" <[EMAIL PROTECTED]> wrote:
>> True in general, but not the cases I've seen in this patchset, where 'foo'
>> is a predicate.
>
> Ok, if foo is a variable containing an error code, it's
> better to return that error code. I assumed that foo is a
> variable cont
On Friday 15 June 2007 14:20:34 Keir Fraser wrote:
>
> On 15/6/07 13:11, "Michael Buesch" <[EMAIL PROTECTED]> wrote:
>
> >> No use of the following please:
> >> If (foo) return 1; else return 0;
> >> Is clearer as:
> >> Return foo;
> >
> > But it's not the same.
> > return !!foo;
> > would be th
On 15/6/07 13:11, "Michael Buesch" <[EMAIL PROTECTED]> wrote:
>> No use of the following please:
>> If (foo) return 1; else return 0;
>> Is clearer as:
>> Return foo;
>
> But it's not the same.
> return !!foo;
> would be the same. And yes, it does matter:
True in general, but not the cases I'
On Friday 15 June 2007 13:26:03 Keir Fraser wrote:
> On 15/6/07 11:46, "Kieran Mansley" <[EMAIL PROTECTED]> wrote:
>
> > This is a repost of some earlier patches to the xen-devel mailing list,
> > with a number of changes thanks to some useful suggestions from others.
>
> The coding style needs f
On 15/6/07 11:46, "Kieran Mansley" <[EMAIL PROTECTED]> wrote:
> This is a repost of some earlier patches to the xen-devel mailing list,
> with a number of changes thanks to some useful suggestions from others.
The coding style needs fixing in various ways.
Hard tabs need to be used, no spaces in
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]>
Previously code had IsReno/IsFack defined as macros that were
local to tcp_input.c though sack_ok field has users elsewhere
too for the same purpose. This changes them to static inlines as
preferred according the current coding style and u
Couple of relatively simple cleanups to tcp-2.6.
--
i.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]>
Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]>
---
include/net/tcp.h | 11 ---
net/ipv4/tcp_output.c |8 ++--
2 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/include/net/tcp.h b/include/net/tcp.h
in
From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= <[EMAIL PROTECTED]>
There is no need for such check in pkts_acked because the
callback is not invoked unless at least one segment got fully
ACKed (i.e., the snd_una moved past skb's end_seq) by the
cumulative ACK's snd_una advancement.
Signed-off-by: Ilpo Jä
Hello Yi,
On Fri, 2007-15-06 at 09:27 +0800, Zhu Yi wrote:
> 1. driver becomes complicated (as it is too elaborate in the queue
> wakeup strategies design)
I am not sure i see the complexity in the wireless driver's wakeup
strategy. I just gave some suggestions to use management frames - they
do
Backend net driver acceleration
Signed-off-by: Kieran Mansley <[EMAIL PROTECTED]>
diff -r fd61ea65cba3 drivers/xen/netback/common.h
--- a/drivers/xen/netback/common.h Thu Jun 14 14:51:20 2007 +0100
+++ b/drivers/xen/netback/common.h Thu Jun 14 14:56:41 2007 +0100
@@ -122,6 +122,41 @@ en
Add accel option to vif xend config
Signed-off-by: Kieran Mansley <[EMAIL PROTECTED]>
diff -r 405eb3e22887 tools/python/xen/xend/server/netif.py
--- a/tools/python/xen/xend/server/netif.py Thu Jun 14 14:50:04 2007 +0100
+++ b/tools/python/xen/xend/server/netif.py Thu Jun 14 14:52:55 2007
This is a repost of some earlier patches to the xen-devel mailing list,
with a number of changes thanks to some useful suggestions from others.
I've also CC'd netdev@vger.kernel.org at Herbert Xu's request as some of
the files being patched may be merged into upstream linux soon, and so
folks ther
Add xenbus_for_each_[back,front]end functions to iterate each bus
Signed-off-by: Kieran Mansley <[EMAIL PROTECTED]>
diff -r d5e0eb7dd069 drivers/xen/xenbus/xenbus_probe.c
--- a/drivers/xen/xenbus/xenbus_probe.c Sun Jun 10 19:50:32 2007 +0100
+++ b/drivers/xen/xenbus/xenbus_probe.c Thu Jun 14 14:
On Fri, 2007-15-06 at 09:01 +0800, Zhang Rui wrote:
> > rtnl_open_byproto(&rth, nl_mgrp(mydiscoveredacpiid), NETLINK_GENERIC)
> >
> Yes. It doesn't work if I use my group id here.
> In fact, I'm using rtnl_open_byproto(&rth, 1, NETLINK_GENERIC) now.
> That's why I said that this demo receives all
On Fri, Jun 15, 2007 at 11:34:30AM +0200, Jens Axboe ([EMAIL PROTECTED]) wrote:
> > Both spd->nr_pages and page_nr are equal to 1. When spd->nr_pages
> > was 2 there was only 1 free slot in pipe_buffer.
>
> Ah duh, indeed, it is a dumb bug indeed. This should work.
Yep, this one works too.
> dif
On Fri, Jun 15 2007, Evgeniy Polyakov wrote:
> On Fri, Jun 15, 2007 at 10:43:18AM +0200, Jens Axboe ([EMAIL PROTECTED])
> wrote:
> > > So, things turned down to be not in the __splice_from_pipe(), but
> > > splice_to_pipe(). Attached patch fixes a leak for me.
> > > It was tested with different da
Commit 164891aadf1721fca4dce473bb0e0998181537c6 broke RTT
sampling of congestion control modules. Inaccurate timestamps
could be fed to them without providing any way for them to
identify such cases. Previously RTT sampler was called only if
FLAG_RETRANS_DATA_ACKED was not set filtering inaccurate
Hallo David, hello Herbert,
indeed i have some concerns about reverting the patch as i do not see
that the MTU is the right thing to distinguish whether a netdevice is
capable to have IPv4/IPv6. E.g. is decnet able to run IPv6?
IMHO the autoconf (in any case) should only handle netdevices that ar
On Fri, Jun 15, 2007 at 10:43:18AM +0200, Jens Axboe ([EMAIL PROTECTED]) wrote:
> > So, things turned down to be not in the __splice_from_pipe(), but
> > splice_to_pipe(). Attached patch fixes a leak for me.
> > It was tested with different data files and all were received correctly.
> >
> > Signe
On Fri, Jun 15 2007, Evgeniy Polyakov wrote:
> On Thu, Jun 14, 2007 at 01:59:02PM +0200, Jens Axboe ([EMAIL PROTECTED])
> wrote:
> > On Thu, Jun 14 2007, Evgeniy Polyakov wrote:
> > > On Wed, Jun 13, 2007 at 12:01:04PM +0400, Evgeniy Polyakov ([EMAIL
> > > PROTECTED]) wrote:
> > > > I will rebase
On Thu, Jun 14, 2007 at 01:59:02PM +0200, Jens Axboe ([EMAIL PROTECTED]) wrote:
> On Thu, Jun 14 2007, Evgeniy Polyakov wrote:
> > On Wed, Jun 13, 2007 at 12:01:04PM +0400, Evgeniy Polyakov ([EMAIL
> > PROTECTED]) wrote:
> > > I will rebase my tree, likely something was not merged correctly.
> >
Hi,
with the new e1000 driver version 7.3.20 the onboard gigabit nic 82547EI
(8086:1019) doesn't work correctly.
After transferring about 100 megabytes over a gigabit link the transfer
stopped and I have to reinit the link either by doing a ifconfig down/up
or unplugging the network cable.
The RxI
50 matches
Mail list logo
