On Mon, 2018-02-05 at 02:21 +0100, Ulf Magnusson wrote:
> 'default false' should be 'default n', though they happen to have the
> same effect here, due to undefined symbols ('false' in this case)
> evaluating to n in a tristate sense.
>
> Remove the default instead of changing it. bool and tristat
This can be reproduced by bind/unbind the driver multiple times
in AM3517 board.
Analysis revealed that rtl8187_start() was invoked before probe
finishes(ie. before the mutex is initialized).
INFO: trying to register non-static key.
the code is fine but needs lockdep annotation.
turning off th
Define macro for TLS Key context
Signed-off-by: Atul Gupta
---
drivers/crypto/chelsio/chcr_algo.h | 42 +
drivers/crypto/chelsio/chcr_core.h | 55 +-
2 files changed, 96 insertions(+), 1 deletion(-)
diff --git a/drivers/crypto/chel
Program the tx and rx key on chip.
Signed-off-by: Atul Gupta
---
drivers/crypto/chelsio/chtls/chtls_hw.c | 394
1 file changed, 394 insertions(+)
create mode 100644 drivers/crypto/chelsio/chtls/chtls_hw.c
diff --git a/drivers/crypto/chelsio/chtls/chtls_hw.c
b/
Key area size in hw-config file. CPL struct for TLS request
and response. Work request for Inline TLS.
Signed-off-by: Atul Gupta
---
drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 121 ++-
drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 2 +
drivers/net/ethernet/chelsio/cxgb4/
Entry for Inline TLS as another driver dependent on cxgb4 and chcr
Signed-off-by: Atul Gupta
---
drivers/crypto/chelsio/Kconfig| 11 +++
drivers/crypto/chelsio/Makefile | 1 +
drivers/crypto/chelsio/chtls/Makefile | 4
3 files changed, 16 insertions(+)
create mode 1
Read FW capability. Read key area size. Dump the TLS record count.
Signed-off-by: Atul Gupta
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 18 +++-
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c| 32 +--
drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 7 ++
drivers/net/
Add new uld driver for Inline TLS support. Register ULP for chtls.
Setsockopt to program key on chip. support AES GCM key size 128.
Signed-off-by: Atul Gupta
---
drivers/crypto/chelsio/chtls/chtls_main.c | 574 ++
include/uapi/linux/tls.h | 1 +
2 f
TLS handler for record transmit and receive.
Create Inline TLS work request and post to FW.
Signed-off-by: Atul Gupta
---
drivers/crypto/chelsio/chtls/chtls_io.c | 1867 +++
1 file changed, 1867 insertions(+)
create mode 100644 drivers/crypto/chelsio/chtls/chtls_io.c
tls_device structure to register Inline TLS drivers
with net/tls
Signed-off-by: Atul Gupta
---
include/net/tls.h | 24
1 file changed, 24 insertions(+)
diff --git a/include/net/tls.h b/include/net/tls.h
index 936cfc5..6b64510 100644
--- a/include/net/tls.h
+++ b/include
CPL handlers for TLS session, record transmit and receive.
Signed-off-by: Atul Gupta
---
drivers/crypto/chelsio/chtls/chtls_cm.c | 2046 +++
net/ipv4/tcp_minisocks.c|1 +
2 files changed, 2047 insertions(+)
create mode 100644 drivers/crypto/chelsi
Signed-off-by: Atul Gupta
---
include/linux/netdev_features.h | 2 ++
net/core/ethtool.c | 1 +
2 files changed, 3 insertions(+)
diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h
index b1b0ca7..e1a33b7 100644
--- a/include/linux/netdev_features.h
+++ b/i
Inline TLS state, connection management. Supporting macros definition.
Signed-off-by: Atul Gupta
---
drivers/crypto/chelsio/chtls/chtls.h| 487
drivers/crypto/chelsio/chtls/chtls_cm.h | 203 +
2 files changed, 690 insertions(+)
create mode 100644
Series for Chelsio Inline TLS driver (chtls.ko)
Driver use the ULP infrastructure to register chtls as Inline TLS ULP.
Chtls use TCP Sockets to transmit and receive TLS record. TCP proto_ops
is extended to offload TLS record.
T6 adapter provides the following features:
-TLS record offload
Facility to register Inline TLS drivers to net/tls. Setup
TLS_FULL_HW prot to listen on offload device.
Cases handled
1. Inline TLS device exists, setup prot for TLS_FULL_HW
2. Atleast one Inline TLS exists, sets TLS_FULL_HW. If
non-inline capable device establish connection, move to TLS_SW_TX
3.
From: Quentin Monnet
Before this patch, perror() function is used in some cases when bpftool
fails to parse its input file in batch mode. This function does not
integrate well with the rest of the output when JSON is used, so we
replace it by something that is compliant.
Most calls to perror() h
Quentin says:
These are two minor fixes to avoid breaking JSON output in batch mode. The
first one makes bpftool output a "null" JSON object, as expected in batch
mode if nothing else is to be printed, when dumping program instructions
into an output file. The second one replaces a call to "perror
From: Quentin Monnet
Print a "null" JSON object to standard output when bpftool is used to
print program instructions to a file, so as to avoid breaking JSON
output on batch mode.
This null object was added for most commands in a previous commit, but
this specific case had been omitted.
Fixes:
On Wed, Feb 14, 2018 at 10:32:22AM -0700, Tycho Andersen wrote:
> > >
> > > What's the reason for adding eBPF support? seccomp shouldn't need it,
> > > and it only makes the code more complex. I'd rather stick with cBPF
> > > until we have an overwhelmingly good reason to use eBPF as a "native"
> >
On 2/14/18 1:55 AM, Arkadi Sharshevsky wrote:
> Add support for devlink resource abstraction.
>
> Arkadi Sharshevsky (7):
> devlink: Change empty line indication with indentations
> devlink: mnlg: Add support for extended ack
> devlink: Add support for devlink resource abstraction
> devlin
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On
> Behalf Of Benjamin Poirier
> Sent: Wednesday, February 7, 2018 10:47 PM
> To: Kirsher, Jeffrey T
> Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux-
> ker...@vger.kernel.org
> Subject: [Intel-wired-lan] [PA
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On
> Behalf Of Benjamin Poirier
> Sent: Wednesday, February 7, 2018 10:47 PM
> To: Kirsher, Jeffrey T
> Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux-
> ker...@vger.kernel.org
> Subject: [Intel-wired-lan] [PA
> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On
> Behalf Of Benjamin Poirier
> Sent: Wednesday, February 7, 2018 10:47 PM
> To: Kirsher, Jeffrey T
> Cc: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux-
> ker...@vger.kernel.org
> Subject: [Intel-wired-lan] [PA
Hi Atul,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on cryptodev/master]
[cannot apply to net/master net-next/master v4.16-rc1 next-20180214]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https
From: Matteo Croce
Date: Wed, 14 Feb 2018 19:13:42 +0100
> The IPVlan module currently depends on IPv6 and Netfilter.
> Refactor the code to allow building IPVlan module regardless of the value of
> CONFIG_IPV6 and CONFIG_NETFILTER.
> Also change the dependency to CONFIG_NET_L3_MASTER_DEV into a
On Wed, Feb 14, 2018 at 5:28 AM, Sowmini Varadhan
wrote:
> RDS removes a datagram (rds_message) from the retransmit queue when
> an ACK is received. The ACK indicates that the receiver has queued
> the RDS datagram, so that the sender can safely forget the datagram.
> When all references to the rd
On Wed, Feb 14, 2018 at 7:19 PM, Prashant Bhole
wrote:
> eBPF test fails due to verifier failure because log_buf is too small.
> Fixed by increasing log_buf size
>
> Signed-off-by: Prashant Bhole
Acked-by: Willem de Bruijn
Thanks Prashant.
eBPF test fails due to verifier failure because log_buf is too small.
Fixed by increasing log_buf size
Signed-off-by: Prashant Bhole
---
v2: log_buf is statically allocated
tools/testing/selftests/net/psock_fanout.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/tes
On Wed, Feb 14, 2018 at 5:28 AM, Sowmini Varadhan
wrote:
> This is version 2 of the series at
> https://www.mail-archive.com/netdev@vger.kernel.org/msg213829.html
>
> Review comments addressed
> Patch 4:
> - make sure to always sock_put m_rs even if there is no znotifier.
> - major rewrite o
On 2/14/2018 2:26 PM, Willem de Bruijn wrote:
On Wed, Feb 14, 2018 at 1:50 PM, Santosh Shilimkar
[...]
This error change might need to go though other subsystem tree. May
be you can seperate it and also copy "linux-...@vger.kernel.org"
Previous changes to this file also went in through net-
On Wed, Feb 14, 2018 at 7:09 PM, Sowmini Varadhan
wrote:
> On (02/14/18 18:48), Willem de Bruijn wrote:
>>
>> If the missing break is intentional, no need to respin just for the other
>> minor comments.
>
> yes the missing break is intentional- the function returns the
> size of the scatterlist n
On Wed, Feb 14, 2018 at 5:28 AM, Sowmini Varadhan
wrote:
> RDS removes a datagram (rds_message) from the retransmit queue when
> an ACK is received. The ACK indicates that the receiver has queued
> the RDS datagram, so that the sender can safely forget the datagram.
> When all references to the rd
On (02/14/18 18:48), Willem de Bruijn wrote:
>
> If the missing break is intentional, no need to respin just for the other
> minor comments.
yes the missing break is intentional- the function returns the
size of the scatterlist needed for RDMA, and RDS_CMSG_ZCOPY_COOKIE
(like RDMA_DEST and RDMA_
On Wed, Feb 14, 2018 at 5:28 AM, Sowmini Varadhan
wrote:
> If the MSG_ZEROCOPY flag is specified with rds_sendmsg(), and,
> if the SO_ZEROCOPY socket option has been set on the PF_RDS socket,
> application pages sent down with rds_sendmsg() are pinned.
>
> The pinning uses the accounting infrastru
The tlv_len is u8, so we need to limit the size of the SDP URI. Enforce
this both in the NLA policy and in the code that performs the allocation
and copy, to avoid writing past the end of the allocated buffer.
Fixes: d9b8d8e19b073 ("NFC: llcp: Service Name Lookup netlink interface")
Signed-off-by:
Matteo Croce wrote:
> The IPVlan module currently depends on IPv6 and Netfilter.
> Refactor the code to allow building IPVlan module regardless of the value of
> CONFIG_IPV6 and CONFIG_NETFILTER.
> Also change the dependency to CONFIG_NET_L3_MASTER_DEV into a select,
> as compiling L3 Master devic
On 2/14/18 3:45 PM, Or Gerlitz wrote:
> On Tue, Feb 13, 2018 at 5:21 PM, David Ahern wrote:
>> On 2/13/18 5:42 AM, Ido Schimmel wrote:
>>> On Tue, Feb 13, 2018 at 01:03:14PM +0200, Or Gerlitz wrote:
On Tue, Feb 13, 2018 at 2:05 AM, David Ahern wrote:
> Hardware supports multipath selecti
On Wed, Feb 14, 2018 at 2:09 PM, Brenda J. Butler wrote:
> Signed-off-by: Brenda J. Butler
Acked-by: Lucas Bates
> ---
> tools/testing/selftests/tc-testing/README | 173
> +---
> tools/testing/selftests/tc-testing/TODO.txt | 25 +++-
> 2 files changed, 179 insertion
On Mon, 12 Feb, at 04:16:42PM, Peter Zijlstra wrote:
> On Fri, Feb 09, 2018 at 05:59:12PM +, Jon Maloy wrote:
> > Command for TCP:
> > "netperf TCP_STREAM (netperf -n 4 -f m -c 4 -C 4 -P 1 -H 10.0.0.1 -t
> > TCP_STREAM -l 10 -- -O THROUGHPUT)"
> > Command for TIPC:
> > "netperf TIPC_STREAM (n
On Wed, Feb 14, 2018 at 2:09 PM, Brenda J. Butler wrote:
> Run the command under test under valgrind. Produce an extra set of
> tap output for the memory check on each test.
>
> Signed-off-by: Brenda J. Butler
Acked-by: Lucas Bates
> ---
> .../tc-testing/plugin-lib/valgrindPlugin.py|
On Wed, Feb 14, 2018 at 2:09 PM, Brenda J. Butler wrote:
> Move the functionality of creating a namespace before the test suite
> and destroying it afterwards to a plugin.
>
> Signed-off-by: Brenda J. Butler
Acked-by: Lucas Bates
> ---
> .../selftests/tc-testing/plugin-lib/nsPlugin.py| 14
On Tue, Feb 13, 2018 at 3:16 PM, Or Gerlitz wrote:
> [...] note we have two ends to deal with here (1) generation (2) usage
>
> E.g if the kernel generates flow label but uses source port we have
> inconsistent
> environment. Problem is that the generation and usage typically don't happen
> on t
On Wed, Feb 14, 2018 at 2:09 PM, Brenda J. Butler wrote:
> This should be a general test architecture, and yet allow specific
> tests to be done. Introduce a plugin architecture.
>
> An individual test has 4 stages, setup/execute/verify/teardown. Each
> plugin gets a chance to run a function at
On Tue, Feb 13, 2018 at 5:21 PM, David Ahern wrote:
> On 2/13/18 5:42 AM, Ido Schimmel wrote:
>> On Tue, Feb 13, 2018 at 01:03:14PM +0200, Or Gerlitz wrote:
>>> On Tue, Feb 13, 2018 at 2:05 AM, David Ahern wrote:
Hardware supports multipath selection using the standard L4 5-tuple
instea
On Wed, Feb 14, 2018 at 2:09 PM, Brenda J. Butler wrote:
> Move the functionality that checks for root permissions into a plugin.
>
> Signed-off-by: Brenda J. Butler
Acked-by: Lucas Bates
> ---
> .../selftests/tc-testing/plugin-lib/rootPlugin.py | 19
> +++
> tools/testing/
On Wed, Feb 14, 2018 at 2:09 PM, Brenda J. Butler wrote:
> Split the test_runner function into the loop part (test_runner)
> and the contents (run_one_test) for maintainability.
> It makes it a little easier to catch exceptions
> in an individual test, and keep going (and flush a bunch
> of tap re
On Wed, Feb 14, 2018 at 2:09 PM, Brenda J. Butler wrote:
> Separate the functionality of the command line parameters into "selection"
> parameters, "action" parameters and other parameters.
>
> "Selection" parameters are for choosing which tests on which to act.
> "Action" parameters are for choos
On Wed, 2018-02-14 at 15:38 -0500, David Miller wrote:
> From: Tom Herbert
> Date: Wed, 14 Feb 2018 09:22:42 -0800
>
> > In kcm_attach strp_done is called when sk_user_data is already
> > set to fail the attach. strp_done needs the strp to be stopped and
> > warns if it isn't. Call strp_stop in t
On Wed, Feb 14, 2018 at 1:50 PM, Santosh Shilimkar
wrote:
> On 2/14/2018 2:28 AM, Sowmini Varadhan wrote:
>>
>> RDS removes a datagram (rds_message) from the retransmit queue when
>> an ACK is received. The ACK indicates that the receiver has queued
>> the RDS datagram, so that the sender can safe
Remove rt_table_id from rtable. It was added for getroute to return the
table id that was hit in the lookup. With the changes for fibmatch the
table id can be extracted from the fib_info returned in the fib_result
so it no longer needs to be in rtable directly.
Signed-off-by: David Ahern
---
dri
From: Finn Thain
Date: Thu, 15 Feb 2018 09:11:13 +1100 (AEDT)
> On Tue, 13 Feb 2018, David Miller wrote:
>
>> > I think you have overlooked those modules which offer no way to set
>> > p->msg_enable, i.e. ax88796, axnet_cs, etherh, hydra, mac8390,
>> > mcf8390, pcnet_cs and zorro8390.
>>
>> T
This patch is used by subsequent patches. It fixes code style issues
caught by checkpatch.
Signed-off-by: Alexander Aring
---
include/net/act_api.h | 5 +++--
net/sched/act_api.c| 12 ++--
net/sched/act_mirred.c | 6 +++---
3 files changed, 12 insertions(+), 11 deletions(-)
diff
This patch adds extack to tcf_action_init and tcf_action_init_1
functions. These are necessary to make individual extack handling in
each act implementation.
Based on work by David Ahern
Cc: David Ahern
Signed-off-by: Alexander Aring
---
include/net/act_api.h | 5 +++--
net/sched/act_api.c
On 2/14/2018 1:25 PM, Sowmini Varadhan wrote:
On (02/14/18 13:10), Santosh Shilimkar wrote:
RDS support true zero copy already with RDMA transport so some of
this code can easily get confused.
btw, another way to solve this is to have the RDMA code use the
suffix "rdma" (which is what it reall
This patch adds extack support for act init callback api. This
prepares to handle extack support inside each specific act
implementation.
Based on work by David Ahern
Cc: David Ahern
Signed-off-by: Alexander Aring
---
include/net/act_api.h | 2 +-
net/sched/act_api.c| 5 +++--
ne
Hi,
this patch series adds extack support for the TC action subsystem.
As example I for the extack support in a TC action I choosed mirred
action.
- Alex
Cc: David Ahern
changes since v2:
- remove newline in extack of generic walker handling
Thanks to Davide Caratti
- add ker...@mojatatu.co
This patch adds extack support for generic act handling. The extack
will be set deeper to each called function which is not part of netdev
core api.
Based on work by David Ahern
Cc: David Ahern
Signed-off-by: Alexander Aring
---
net/sched/act_api.c | 93 +++
This patch adds extack support for TC mirred action.
Cc: David Ahern
Signed-off-by: Alexander Aring
---
net/sched/act_mirred.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c
index 05c2ebe92eca..fd34015331ab 10
This patch adds extack support for act walker callback api. This
prepares to handle extack support inside each specific act
implementation.
Cc: David Ahern
Signed-off-by: Alexander Aring
---
include/net/act_api.h | 3 ++-
net/sched/act_api.c| 4 ++--
net/sched/act_bpf.c| 3
This patch adds extack handling for a common used TC act function
"tcf_generic_walker()" to add an extack message on failures.
The tcf_generic_walker() function can fail if get a invalid command
different than DEL and GET. The naming "action" here is wrong, the
correct naming would be command.
Cc:
This patch adds extack support for act lookup callback api. This
prepares to handle extack support inside each specific act
implementation.
Cc: David Ahern
Signed-off-by: Alexander Aring
---
include/net/act_api.h | 3 ++-
net/sched/act_api.c| 2 +-
net/sched/act_bpf.c| 3 ++
On Tue, 13 Feb 2018, David Miller wrote:
> > I think you have overlooked those modules which offer no way to set
> > p->msg_enable, i.e. ax88796, axnet_cs, etherh, hydra, mac8390,
> > mcf8390, pcnet_cs and zorro8390.
>
> Then that's a bug, we have a very simple easy to implement interface for
On Wed, 14 Feb 2018 23:33:37 +0200
Serhey Popovych wrote:
> if (tb[IFLA_MASTER]) {
> - SPRINT_BUF(b1);
> + int master = rta_getattr_u32(tb[IFLA_MASTER]);
>
> print_string(PRINT_ANY,
>"master",
>"
When priviliged tests are skipped due to user rights, count the number of
skipped tests so it's more obvious that the test did not check everything.
Signed-off-by: Joe Stringer
---
tools/testing/selftests/bpf/test_verifier.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff
The "kernel.unprivileged_bpf_disabled" sysctl, if enabled, causes all
unprivileged tests to fail because it permanently disables unprivileged
BPF access for the currently running kernel. Skip the relevant tests if
the user attempts to run the testsuite with this sysctl enabled.
Signed-off-by: Joe
This array appears to be completely unused, remove it.
Signed-off-by: Joe Stringer
---
kernel/bpf/verifier.c | 4
1 file changed, 4 deletions(-)
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index 5fb69a85d967..3c74b163eaeb 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/v
This is series makes some minor changes primarily focused on making it easier
to understand why test_verifier is failing a test. This includes printing the
observed output when a test fails in a different way than expected, or when
unprivileged tests fail due to sysctl kernel.unprivileged_bpf_disab
This makes it easier to debug off-hand when the error message isn't
exactly as expected.
Signed-off-by: Joe Stringer
---
tools/testing/selftests/bpf/test_verifier.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/bpf/test_verifier.c
b/tools/testing/
On 2/14/2018 1:25 PM, Sowmini Varadhan wrote:
On (02/14/18 13:10), Santosh Shilimkar wrote:
RDS support true zero copy already with RDMA transport so some of
this code can easily get confused.
btw, another way to solve this is to have the RDMA code use the
suffix "rdma" (which is what it reall
David Ahern wrote:
> On 2/14/18 1:09 PM, Serhey Popovych wrote:
>
>>
>> Any comments on this series? Should I perform some additional testing?
>>
>>
>
> I thought I had applied them. Can you re-send and cc me?
>
Done. v2 is broken due to missing subject line. v3 is ready.
signature.asc
Descr
Be consistent in handling of IFLA_IFNAME attribute in all places: if
there is no attribute report bug to stderr and use ll_idx_n2a() as
last measure to get name in "if%u" format instead of "".
Use check_ifname() to validate network device name: this catches both
unexpected return from kernel and l
Simplify calling code in ipaddr_list_flush_or_save() by introducing
intermediate variable of @struct nlmsghdr, drop duplicated code:
print_linkinfo_brief() never returns values other than <= 0 so we can
move print_selected_addrinfo() outside of each block.
Signed-off-by: Serhey Popovych
---
ip/i
Now all users of ll_idx_n2a() replaced with ll_index_to_name() we can
move it's functionality to ll_index_to_name() and implement index to
name conversion using snprintf() and "if%u".
Use %u specifier in "if%..." template consistently: network device
indexes are always greather than zero.
Also in
There is at least three places implementing same things: two in
ipaddress.c print_linkinfo() & print_linkinfo_brief() and one in
bridge/link.c.
They are diverge from each other very little: bridge/link.c does not
support JSON output at the moment and print_linkinfo_brief() does not
handle IFLA_LIN
There is no reentrancy as well as deferred result usage for all cases
where ll_idx_n2a() being used: it is safe to use ll_index_to_name() that
internally calls ll_idx_n2a() with static buffer to hold result.
Signed-off-by: Serhey Popovych
---
ip/ipaddress.c | 14 +-
1 file changed,
Neither internal libnetlink nor libgenl depends on ll_map.o: prepare for
upcoming changes that brings much more cleaner dependency between
utils.o and ll_map.o.
Signed-off-by: Serhey Popovych
---
lib/Makefile |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/Makefile
With this series I propose to make print_linkinfo_brief() static in
favor of print_linkinfo() as single point for linkinfo printing.
Changes presented with this series tested using following script:
\#!/bin/bash
iproute2_dir="$1"
iface='eth0.2'
pushd "$iproute2_dir" &>/dev/null
for i in new ol
It shares lot of code with print_linkinfo(): drop duplicated part,
change parameters list, make it static and call from print_linkinfo()
after common path.
While there move SPRINT_BUF() to the function scope from blocks to
avoid duplication and use "%s" to print "\n" to help compiler optimize
exit
There at least two places in ip/ipaddress.c where we match IFA_LABEL
against filter.label if that is given.
Get rid of "common" if () statement for inet_addr_match_rta() and
ifa_label_match_rta(): it is not common because first will check for
filter.pfx.family != AF_UNSPEC inside and second for fi
There are few places to improve:
1) return -1 when entry is filtered instead of zero, which means
accept entry: ipaddress_list_flush_or_save() the only user of this
2) use ll_idx_n2a() as last resort to translate name to index for
"should never happen" cases when cache shouldn't be
Please ignore this series: wrong subject.
> Changes presented with this series tested using following script:
>
> \#!/bin/bash
>
> iproute2_dir="$1"
> iface='eth0.2'
>
> pushd "$iproute2_dir" &>/dev/null
>
> for i in new old; do
> DIR="/tmp/$i"
> mkdir -p "$DIR"
>
> ln -snf
There is no reentrancy as well as deferred result usage for all cases
where ll_idx_n2a() being used: it is safe to use ll_index_to_name() that
internally calls ll_idx_n2a() with static buffer to hold result.
Signed-off-by: Serhey Popovych
---
ip/ipaddress.c | 14 +-
1 file changed,
There is at least three places implementing same things: two in
ipaddress.c print_linkinfo() & print_linkinfo_brief() and one in
bridge/link.c.
They are diverge from each other very little: bridge/link.c does not
support JSON output at the moment and print_linkinfo_brief() does not
handle IFLA_LIN
There at least two places in ip/ipaddress.c where we match IFA_LABEL
against filter.label if that is given.
Get rid of "common" if () statement for inet_addr_match_rta() and
ifa_label_match_rta(): it is not common because first will check for
filter.pfx.family != AF_UNSPEC inside and second for fi
Changes presented with this series tested using following script:
\#!/bin/bash
iproute2_dir="$1"
iface='eth0.2'
pushd "$iproute2_dir" &>/dev/null
for i in new old; do
DIR="/tmp/$i"
mkdir -p "$DIR"
ln -snf ip.$i ip/ip
# normal
ip/ip link show
Be consistent in handling of IFLA_IFNAME attribute in all places: if
there is no attribute report bug to stderr and use ll_idx_n2a() as
last measure to get name in "if%u" format instead of "".
Use check_ifname() to validate network device name: this catches both
unexpected return from kernel and l
There are few places to improve:
1) return -1 when entry is filtered instead of zero, which means
accept entry: ipaddress_list_flush_or_save() the only user of this
2) use ll_idx_n2a() as last resort to translate name to index for
"should never happen" cases when cache shouldn't be
Simplify calling code in ipaddr_list_flush_or_save() by introducing
intermediate variable of @struct nlmsghdr, drop duplicated code:
print_linkinfo_brief() never returns values other than <= 0 so we can
move print_selected_addrinfo() outside of each block.
Signed-off-by: Serhey Popovych
---
ip/i
Now all users of ll_idx_n2a() replaced with ll_index_to_name() we can
move it's functionality to ll_index_to_name() and implement index to
name conversion using snprintf() and "if%u".
Use %u specifier in "if%..." template consistently: network device
indexes are always greather than zero.
Also in
It shares lot of code with print_linkinfo(): drop duplicated part,
change parameters list, make it static and call from print_linkinfo()
after common path.
While there move SPRINT_BUF() to the function scope from blocks to
avoid duplication and use "%s" to print "\n" to help compiler optimize
exit
Neither internal libnetlink nor libgenl depends on ll_map.o: prepare for
upcoming changes that brings much more cleaner dependency between
utils.o and ll_map.o.
Signed-off-by: Serhey Popovych
---
lib/Makefile |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/Makefile
On (02/14/18 13:10), Santosh Shilimkar wrote:
> >>>RDS support true zero copy already with RDMA transport so some of
> >>>this code can easily get confused.
btw, another way to solve this is to have the RDMA code use the
suffix "rdma" (which is what it really is) as needed.
--Sowmini
Hello David Miller,
Would this patch be able to be reverted? We have found in further testing that
this produces undesired results.
For example, using some PBR rule that uses conntrack to set the skb->mark and
the desired nexthop is a tunnel then the tunnel route selection hits a routing
loop
On Wed, Feb 14, 2018 at 02:19:03PM -0500, Paul Moore wrote:
> On Tue, Feb 13, 2018 at 3:52 PM, Richard Haines
> wrote:
> > These patches have been built on Fedora 27 with kernel-4.16.0-0.rc1 plus
> > the following userspace patches to enable testing:
> >
> > 1) Updates to libsepol 2.7 to support t
On 2/14/2018 11:49 AM, Sowmini Varadhan wrote:
On (02/14/18 11:10), Santosh Shilimkar wrote:
s/RDS_CMSG_ZCOPY_COOKIE/RDS_CMSG_ZMSGCOPY_COOKIE
Please see https://www.spinics.net/lists/netdev/msg483627.html
Just saw it and responded to Dave.
@@ -356,6 +358,53 @@ int rds_message_cop
On 2/14/2018 11:02 AM, David Miller wrote:
From: Sowmini Varadhan
Date: Wed, 14 Feb 2018 14:01:10 -0500
On (02/14/18 10:50), Santosh Shilimkar wrote:
generic comment and please update it where it is applicable
in terms of variable names, notifiers etc.
RDS support true zero copy already with
From: Jeff Kirsher
Date: Wed, 14 Feb 2018 09:45:27 -0800
> This patch series enables the new mqprio hardware offload mechanism
> creating traffic classes on VFs for XL710 devices. The parameters
> needed to configure these traffic classes/queue channels are provides
> by the user via the tc tool.
From: Tom Herbert
Date: Wed, 14 Feb 2018 09:22:42 -0800
> In kcm_attach strp_done is called when sk_user_data is already
> set to fail the attach. strp_done needs the strp to be stopped and
> warns if it isn't. Call strp_stop in this case to eliminate the
> warning message.
>
> Reported-by: syzb
From: Daniel Schultz
Date: Wed, 14 Feb 2018 17:07:11 +0100
> From: Wadim Egorov
>
> The DP83867 has a muxing option for the CLK_OUT pin. It is possible
> to set CLK_OUT for different channels.
> Create a binding to select a specific clock for CLK_OUT pin.
>
> Signed-off-by: Wadim Egorov
> Sig
From: Daniel Schultz
Date: Wed, 14 Feb 2018 17:07:12 +0100
> From: Wadim Egorov
>
> Add documentation of ti,clk-output-sel which can be used to select
> a specific clock for CLK_OUT.
>
> Signed-off-by: Wadim Egorov
> Signed-off-by: Daniel Schultz
> ---
> Changes:
> v2:
> -
>
1 - 100 of 290 matches
Mail list logo
