Re: [jclouds-labs] this closes JCLOUDS-737 (#109)

nope should be there --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/109#issuecomment-61598373

Re: [jclouds-labs] this closes JCLOUDS-737 (#109)

Thx, do I need to backport it to 1.8.x? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/109#issuecomment-61598179

Re: [jclouds-labs-google] Fix some obvious bugs in google-cloud-storage. (#76)

[jclouds » jclouds-labs-google #1618](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1618/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jc

Re: [jclouds-labs-google] Fix some obvious bugs in google-cloud-storage. (#76)

> @@ -44,31 +44,31 @@ > public abstract String etag(); > public abstract String name(); > public abstract String bucket(); > - public abstract Long generation(); > - public abstract Long metageneration(); > + public abstract long generation(); ps this is sooo much nicer than havi

Re: [jclouds-labs-google] Fix some obvious bugs in google-cloud-storage. (#76)

> @@ -483,6 +482,6 @@ GCSObject copyObject(@PathParam("destinationBucket") > String destinationBucket, > @OAuthScopes(STORAGE_FULLCONTROL_SCOPE) > @MapBinder(MultipartUploadBinder.class) > GCSObject multipartUpload(@PathParam("bucket") String bucketName, > -@BinderParam(Bin

Re: [jclouds-labs-google] Fix some obvious bugs in google-cloud-storage. (#76)

[jclouds » jclouds-labs-google #1617](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1617/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jc

Re: [jclouds-labs-google] Fix some obvious bugs in google-cloud-storage. (#76)

> @@ -44,31 +44,31 @@ > public abstract String etag(); > public abstract String name(); > public abstract String bucket(); > - public abstract Long generation(); > - public abstract Long metageneration(); > + public abstract long generation(); lots of oops here :P --- Reply to t

Re: [jclouds-labs-google] Fix some obvious bugs in google-cloud-storage. (#76)

> @@ -105,9 +104,10 @@ protected GCSBlobStore(BlobStoreContext context, > BlobUtils blobUtils, Supplier > @Override > public PageSet list() { > - return new Function, > org.jclouds.blobstore.domain.PageSet>() { > - public org.jclouds.blobstore.domain.PageSet StorageMetadata

Jenkins build is back to normal : jclouds » jclouds-labs-google #1617

See

Re: [jclouds-labs-google] Fix some obvious bugs in google-cloud-storage. (#76)

> @Override public R bindToRequest(R request, > Map postParams) { >ObjectTemplate template = (ObjectTemplate) postParams.get("template"); >Payload payload = (Payload) postParams.get("payload"); > > - String contentType = checkNotNull(template.cacheControl(), > "content

Re: [jclouds-labs-google] Fix some obvious bugs in google-cloud-storage. (#76)

[jclouds-labs-google-pull-requests #214](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/214/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/76#issuecomment-61594153

Build failed in Jenkins: jclouds » jclouds-labs-google #1616

See Changes: [Adrian Cole] JCLOUDS-458 Fix some obvious bugs in google-cloud-storage. -- [...truncated 1447 lines...] [pool-1-thread-1] Test testPatchBucketWithOptionsResp

Re: [jclouds-labs-google] Fix some obvious bugs in google-cloud-storage. (#76)

[jclouds » jclouds-labs-google #1616](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1616/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https:

Re: [jclouds-labs-google] Fix some obvious bugs in google-cloud-storage. (#76)

[jclouds-labs-google-pull-requests #213](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/213/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/76#issuecomment-61593792

Re: [jclouds-labs-google] Fix some obvious bugs in google-cloud-storage. (#76)

[jclouds-labs-google-pull-requests #212](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/212/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/76#issuecom

Re: [jclouds-labs-google] Fix some obvious bugs in google-cloud-storage. (#76)

[jclouds » jclouds-labs-google #1615](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1615/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https:

Build failed in Jenkins: jclouds » jclouds-labs-google #1615

See Changes: [Adrian Cole] JCLOUDS-458 Fix some obvious bugs in google-cloud-storage. -- [...truncated 1451 lines...] Test suite progress: tests succeeded: 34, failed: 0, s

Re: [jclouds-labs-google] Fix some obvious bugs in google-cloud-storage. (#76)

[jclouds-labs-google-pull-requests #211](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/211/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/76#issuecom

Re: [jclouds-labs-google] Fix some obvious bugs in google-cloud-storage. (#76)

After this change, live tests are better, but still not great. ``` Failed tests: GCSBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutIncorrectContentMD5:271 null BucketAccessControlsApiLiveTest.testCreateBucketAcl:49->createBucket:43 » HttpResponse BucketApiLiveTest.testCreateBucke

[jclouds-labs-google] Fix some obvious bugs in google-cloud-storage. (#76)

More work to do, as still many live tests fail. google cloud storage is not in as good shape as google compute engine. Needs more non-live tests, particularly parse tests. You can merge this Pull Request by running: git pull https://github.com/adriancole/jclouds-labs-google adrian.google-clou

Re: [jclouds-labs] JCLOUDS-763 Remove jclouds-representations and jclouds-management. (#110)

[jclouds » jclouds-labs #1859](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1859/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pul

Jenkins build is back to stable : jclouds » jclouds-labs #1859

See

Re: [jclouds-labs-google] Cleanup ListPage in google apis. (#75)

[jclouds » jclouds-labs-google #1614](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1614/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jc

Re: [jclouds-labs] JCLOUDS-763 Remove jclouds-representations and jclouds-management. (#110)

[jclouds-labs-pull-requests #382](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/382/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/110#issuecomment-61591434

[jira] [Reopened] (JCLOUDS-458) Google Cloud Storage support

[ https://issues.apache.org/jira/browse/JCLOUDS-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Cole reopened JCLOUDS-458: - Assignee: Adrian Cole (was: Bhathiya Supun) This is still in labs, so is not complete > Googl

[jira] [Updated] (JCLOUDS-458) Google Cloud Storage support

[ https://issues.apache.org/jira/browse/JCLOUDS-458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Cole updated JCLOUDS-458: Fix Version/s: (was: 1.8.1) 1.8.2 > Google Cloud Storage support > -

Re: [jclouds-labs-google] Cleanup ListPage in google apis. (#75)

[jclouds-labs-google-pull-requests #210](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/210/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/75#issuecomment-61591225

[jclouds-labs] JCLOUDS-763 Remove jclouds-representations and jclouds-management. (#110)

https://issues.apache.org/jira/browse/JCLOUDS-763 You can merge this Pull Request by running: git pull https://github.com/adriancole/jclouds-labs adrian.moreremove Or you can view, comment on it, or merge it online at: https://github.com/jclouds/jclouds-labs/pull/110 -- Commit Summary --

[jira] [Commented] (JCLOUDS-763) Remove jclouds-representations and jclouds-management from labs

[ https://issues.apache.org/jira/browse/JCLOUDS-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14195693#comment-14195693 ] Adrian Cole commented on JCLOUDS-763: - https://github.com/jclouds/jclouds-labs/pull/1

[jclouds-labs-google] Cleanup ListPage in google apis. (#75)

Be consistent, but recognize that google storage has a list of prefixes, where google compute engine does not. You can merge this Pull Request by running: git pull https://github.com/adriancole/jclouds-labs-google adrian.clean-listpage Or you can view, comment on it, or merge it online at:

Jenkins build is still unstable: jclouds » jclouds-labs #1858

See

[jira] [Resolved] (JCLOUDS-737) Docker bindings needs upgrade to Docker API 1.4

[ https://issues.apache.org/jira/browse/JCLOUDS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Cole resolved JCLOUDS-737. - Resolution: Fixed thanks, [~andreaturli] > Docker bindings needs upgrade to Docker API 1.4 > --

[jira] [Updated] (JCLOUDS-737) Docker bindings needs upgrade to Docker API 1.4

[ https://issues.apache.org/jira/browse/JCLOUDS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Cole updated JCLOUDS-737: Fix Version/s: 1.8.2 > Docker bindings needs upgrade to Docker API 1.4 > -

Re: [jclouds-labs] this closes JCLOUDS-737 (#109)

merged. thx dude! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/109#issuecomment-61588957

[jira] [Commented] (JCLOUDS-737) Docker bindings needs upgrade to Docker API 1.4

[ https://issues.apache.org/jira/browse/JCLOUDS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14195664#comment-14195664 ] ASF subversion and git services commented on JCLOUDS-737: - Commit

[jira] [Commented] (JCLOUDS-737) Docker bindings needs upgrade to Docker API 1.4

[ https://issues.apache.org/jira/browse/JCLOUDS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14195652#comment-14195652 ] ASF subversion and git services commented on JCLOUDS-737: - Commit

Re: [jclouds-labs-google] ProjectApi Live Test Fix. (#74)

Closed #74. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/74#event-187760298

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> and.. done. 5200 less lines! Yay!!! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/73#issuecomment-61570813

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

@eamonnmcmanus developers of GCE thank you very much for auto! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/73#issuecomment-61568133

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

and.. done. 5200 less lines! --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/73#issuecomment-61567954

[jira] [Commented] (JCLOUDS-750) Replace hand-written domain classes with Auto-Value ones

[ https://issues.apache.org/jira/browse/JCLOUDS-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14195344#comment-14195344 ] ASF subversion and git services commented on JCLOUDS-750: - Commit

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

[jclouds » jclouds-labs-google #1612](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1612/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jc

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

[jclouds-labs-google-pull-requests #209](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/209/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/73#issuecomment-61564568

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

ok all good. will merge (including @danbroudy fix) on green! Thanks for the reviews. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/73#issuecomment-61564331

Re: [jclouds-labs-google] ProjectApi Live Test Fix. (#74)

Sounds good. Do with it what you will. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/74#issuecomment-61563845

Re: [jclouds-labs-google] ProjectApi Live Test Fix. (#74)

@danbroudy I will cherry-pick this into #73, then merge into master --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/74#issuecomment-61563497

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> @@ -31,7 +31,7 @@ > @Test(groups = "unit") done --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/73/files#r19772892

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> > import org.jclouds.googlecomputeengine.domain.Firewall; > import org.jclouds.net.domain.IpPermission; > import org.jclouds.net.domain.IpProtocol; > import org.testng.annotations.Test; > > -import com.google.common.collect.Range; > +import com.google.common.collect.ImmutableList; > >

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> @@ -64,7 +64,7 @@ > Project get(@PathParam("project") String projectName); > > /** > -* Sets metadata common to all instances within the specified project > using the data included in the request. > +* Lists metadata common to all instances within the specified project > using

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> - .unhealthyThreshold(in.getUnhealthyThreshold().orNull()) > - .healthyThreshold(in.getHealthyThreshold().orNull()); > - } > + /** An unhealthy VM will be marked healthy after this many consecutive > successes. */ > + public abstract int healthyThreshold(

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> > - public Builder toBuilder() { > - return new Builder().fromSnapshot(this); > + @SerializedNames({ "id", "selfLink", "name", "description", "diskSizeGb", > "status", "sourceDisk", "sourceDiskId" }) > + public static Snapshot create(String id, URI selfLink, String name, > String d

Re: [jclouds-labs-google] ProjectApi Live Test Fix. (#74)

[jclouds » jclouds-labs-google #1611](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1611/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jc

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

[jclouds » jclouds-labs-google #1610](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1610/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jc

Re: [jclouds-labs-google] ProjectApi Live Test Fix. (#74)

[jclouds-labs-google-pull-requests #208](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/208/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/74#issuecomment-61557264

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

One of the live test failures is addressed in #74 which I just submitted. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/73#issuecomment-61557025

[jclouds-labs-google] ProjectApi Live Test Fix. (#74)

Broken live test ProjectApiLiveTest.testGetProjectWhenNotExists:61 » HttpResponse command: GET ... Failure dues to Google return value change. Updates the project api to have an appropriate fallback. You can merge this Pull Request by running: git pull https://github.com/GoogleCloudPlatform/

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

[jclouds-labs-google-pull-requests #207](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/207/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/73#issuecomment-61556923

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> > import org.jclouds.googlecomputeengine.domain.Firewall; > import org.jclouds.net.domain.IpPermission; > import org.jclouds.net.domain.IpProtocol; > import org.testng.annotations.Test; > > -import com.google.common.collect.Range; > +import com.google.common.collect.ImmutableList; > >

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

Live test results so far ``` Results : Failed tests: InstanceApiLiveTest.testDeleteInstance:227->BaseGoogleComputeEngineApiLiveTest.assertZoneOperationDoneSucessfully:111->BaseGoogleComputeEngineApiLiveTest.waitZoneOperationDone:118->BaseGoogleComputeEngineApiLiveTest.waitOperationDone:166 »

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> +import org.jclouds.javax.annotation.Nullable; > + > +import com.google.common.collect.ImmutableList; > +import com.google.common.collect.ImmutableMap; > + > +public final class NullSafeCopies { > + > + public static Map copyOf(@Nullable Map map) { > + return map != null ? ImmutableMap.co

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> - .unhealthyThreshold(in.getUnhealthyThreshold().orNull()) > - .healthyThreshold(in.getHealthyThreshold().orNull()); > - } > + /** An unhealthy VM will be marked healthy after this many consecutive > successes. */ > + public abstract int healthyThreshold(

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> + > +import java.net.URI; > +import java.util.List; > +import java.util.Map; > + > +import > org.jclouds.googlecomputeengine.domain.Instance.NetworkInterface.AccessConfig; > +import > org.jclouds.googlecomputeengine.domain.Instance.NetworkInterface.AccessConfig.Type; > +import org.jclouds.googl

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> +import org.jclouds.javax.annotation.Nullable; > +import org.jclouds.json.SerializedNames; > + > +import com.google.auto.value.AutoValue; > + > +/** Container for network, IPv4 range and optional gateway, for creation > caching */ > +@AutoValue > +public abstract class NetworkAndAddressRange { >

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> @@ -113,18 +102,15 @@ public > GoogleComputeEngineServiceAdapter(GoogleComputeEngineApi api, > > @Named(OPERATION_COMPLETE_TIMEOUT) Long operationCompleteCheckTimeout, > @Memoized Supplier extends Location

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

More of a scan than a thorough review, but just a few minor questions from that. Seeing as this is work in progress, +1 - looks good to me --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/73#issuecomment-61553247

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> > import org.jclouds.googlecomputeengine.domain.Firewall; > import org.jclouds.net.domain.IpPermission; > import org.jclouds.net.domain.IpProtocol; > import org.testng.annotations.Test; > > -import com.google.common.collect.Range; > +import com.google.common.collect.ImmutableList; > >

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> @@ -31,7 +31,7 @@ > @Test(groups = "unit") Add test name? --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/73/files#r19767630

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> +import org.jclouds.javax.annotation.Nullable; > + > +import com.google.common.collect.ImmutableList; > +import com.google.common.collect.ImmutableMap; > + > +public final class NullSafeCopies { > + > + public static Map copyOf(@Nullable Map map) { > + return map != null ? ImmutableMap.co

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> @@ -64,7 +64,7 @@ > Project get(@PathParam("project") String projectName); > > /** > -* Sets metadata common to all instances within the specified project > using the data included in the request. > +* Lists metadata common to all instances within the specified project > using

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> + > +import java.net.URI; > +import java.util.List; > +import java.util.Map; > + > +import > org.jclouds.googlecomputeengine.domain.Instance.NetworkInterface.AccessConfig; > +import > org.jclouds.googlecomputeengine.domain.Instance.NetworkInterface.AccessConfig.Type; > +import org.jclouds.googl

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> > - public Builder toBuilder() { > - return new Builder().fromSnapshot(this); > + @SerializedNames({ "id", "selfLink", "name", "description", "diskSizeGb", > "status", "sourceDisk", "sourceDiskId" }) > + public static Snapshot create(String id, URI selfLink, String name, > String d

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> - .unhealthyThreshold(in.getUnhealthyThreshold().orNull()) > - .healthyThreshold(in.getHealthyThreshold().orNull()); > - } > + /** An unhealthy VM will be marked healthy after this many consecutive > successes. */ > + public abstract int healthyThreshold(

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> > - for (Rule rule : fw.getAllowed()) { > - if (!rule.getPorts().isEmpty()) { > -for (Range r : rule.getPorts().asRanges()) { > - IpPermission.Builder builder = populateBuilder(fw, > rule.getIpProtocol()); > - builder.fromPort(r.lowerEndpoin

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> +import org.jclouds.javax.annotation.Nullable; > +import org.jclouds.json.SerializedNames; > + > +import com.google.auto.value.AutoValue; > + > +/** Container for network, IPv4 range and optional gateway, for creation > caching */ > +@AutoValue > +public abstract class NetworkAndAddressRange { >

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

> @@ -113,18 +102,15 @@ public > GoogleComputeEngineServiceAdapter(GoogleComputeEngineApi api, > > @Named(OPERATION_COMPLETE_TIMEOUT) Long operationCompleteCheckTimeout, > @Memoized Supplier extends Location

Jenkins build is still unstable: jclouds » jclouds-labs #1857

See

Re: [jclouds-labs] this closes JCLOUDS-737 (#109)

[jclouds » jclouds-labs #1857](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1857/) UNSTABLE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/

Re: [jclouds-labs] this closes JCLOUDS-737 (#109)

[jclouds-labs-pull-requests #381](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/381/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/109#issuecomment-61530448

Jenkins build is still unstable: jclouds » jclouds-labs #1856

See

Re: [jclouds-labs] this closes JCLOUDS-737 (#109)

[jclouds » jclouds-labs #1856](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1856/) UNSTABLE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

[jclouds » jclouds-labs-google #1609](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1609/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jc

Re: [jclouds-labs] this closes JCLOUDS-737 (#109)

[jclouds-labs-pull-requests #380](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/380/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/109#issuecomment-61528147

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

[jclouds-labs-google-pull-requests #206](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/206/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/73#issuecomment-61527469

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

[jclouds » jclouds-labs-google #1608](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-google/1608/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jc

Re: [jclouds-labs] this closes JCLOUDS-737 (#109)

LGTM on green. Make sure the api metadata reflects latest change to use client certificate auth. --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/109#issuecomment-61522577

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

I will run live tests again in a bit. Here were the results before this change: ```java Failed tests: GoogleComputeEngineServiceLiveTest>BaseComputeServiceLiveTest.testCreateAndRunAService:706->BaseComputeServiceLiveTest.createAndRunAServiceInGroup:723 » RunNodes ProjectApiLiveTest.testGetPr

Re: [jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

[jclouds-labs-google-pull-requests #205](https://jclouds.ci.cloudbees.com/job/jclouds-labs-google-pull-requests/205/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs-google/pull/73#issuecomment-61522640

[jclouds-labs-google] Convert GoogleComputeEngine to AutoValue + general cleanup. (#73)

Lots of inconsistencies scrubbed as a part of this, which took about 20 hours to complete. You can merge this Pull Request by running: git pull https://github.com/adriancole/jclouds-labs-google adrian.auto-gce2 Or you can view, comment on it, or merge it online at: https://github.com/jcloud

Re: [jclouds-labs] this closes JCLOUDS-737 (#109)

[jclouds » jclouds-labs #1855](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1855/) UNSTABLE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/

Jenkins build is unstable: jclouds » jclouds-labs #1855

See

Re: [jclouds-labs] this closes JCLOUDS-737 (#109)

[jclouds-labs-pull-requests #379](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/379/) UNSTABLE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/109#issuecomment-61515797

Build failed in Jenkins: jclouds » jclouds-labs #1854

See Changes: [Andrea Turli] JCLOUDS-737 update docker to support v1.3 -- [...truncated 758 lines...] Starting test testWithId(org.jclouds.docker.DockerApiMetadataTest) Starting tes

Re: [jclouds-labs] this closes JCLOUDS-737 (#109)

[jclouds » jclouds-labs #1854](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1854/) FAILURE Looks like there's a problem with this pull request [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/j

Re: [jclouds-labs] this closes JCLOUDS-737 (#109)

[jclouds-labs-pull-requests #378](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/378/) FAILURE Looks like there's a problem with this pull request --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/109#issuecomment-61514817

Re: [jclouds-labs] this closes JCLOUDS-737 (#109)

> @@ -83,7 +65,7 @@ > @GET > @Path("/containers/json") > @Fallback(Fallbacks.EmptySetOnNotFoundOr404.class) > - Set listContainers(ListContainerOptions options); > + Set listContainers(ListContainerOptions options); Please switch this to return a List (ex. s/Set/List/g in this file

Re: [jclouds-labs] this closes JCLOUDS-737 (#109)

> @@ -37,4 +46,15 @@ protected void bindErrorHandlers() { > > bind(HttpErrorHandler.class).annotatedWith(ClientError.class).to(DockerErrorHandler.class); > > bind(HttpErrorHandler.class).annotatedWith(ServerError.class).to(DockerErrorHandler.class); > } > + > + @Override > +

Re: [jclouds-labs] this closes JCLOUDS-737 (#109)

[jclouds » jclouds-labs #1853](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1853/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pul

Re: [jclouds-labs] this closes JCLOUDS-737 (#109)

[jclouds-labs-pull-requests #377](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/377/) SUCCESS This pull request looks good --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/109#issuecomment-61508792

Jenkins build is back to normal : jclouds » jclouds-labs #1852

See

Re: [jclouds-labs] this closes JCLOUDS-737 (#109)

[jclouds » jclouds-labs #1852](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1852/) SUCCESS This pull request looks good [(what's this?)](https://www.cloudbees.com/what-is-buildhive) --- Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pul

  1   2   >