nope should be there
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/109#issuecomment-61598373
Thx, do I need to backport it to 1.8.x?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/109#issuecomment-61598179
merged. thx dude!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/109#issuecomment-61588957
[jclouds » jclouds-labs
#1857](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1857/)
UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/
[jclouds-labs-pull-requests
#381](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/381/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/109#issuecomment-61530448
[jclouds » jclouds-labs
#1856](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1856/)
UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/
[jclouds-labs-pull-requests
#380](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/380/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/109#issuecomment-61528147
LGTM on green. Make sure the api metadata reflects latest change to use client
certificate auth.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/109#issuecomment-61522577
[jclouds » jclouds-labs
#1855](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1855/)
UNSTABLE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/
[jclouds-labs-pull-requests
#379](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/379/)
UNSTABLE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/109#issuecomment-61515797
[jclouds » jclouds-labs
#1854](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1854/)
FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/j
[jclouds-labs-pull-requests
#378](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/378/)
FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/109#issuecomment-61514817
> @@ -83,7 +65,7 @@
> @GET
> @Path("/containers/json")
> @Fallback(Fallbacks.EmptySetOnNotFoundOr404.class)
> - Set listContainers(ListContainerOptions options);
> + Set listContainers(ListContainerOptions options);
Please switch this to return a List (ex. s/Set/List/g in this file
> @@ -37,4 +46,15 @@ protected void bindErrorHandlers() {
>
> bind(HttpErrorHandler.class).annotatedWith(ClientError.class).to(DockerErrorHandler.class);
>
> bind(HttpErrorHandler.class).annotatedWith(ServerError.class).to(DockerErrorHandler.class);
> }
> +
> + @Override
> +
[jclouds » jclouds-labs
#1853](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1853/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pul
[jclouds-labs-pull-requests
#377](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/377/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/109#issuecomment-61508792
[jclouds » jclouds-labs
#1852](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1852/)
SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pul
> + return images;
> + }
> +
> + public String getDriver() {
> + return driver;
> + }
> +
> + public String getExecutionDriver() {
> + return executionDriver;
> + }
> +
> + public String getKernelVersion() {
> + return kernelVersion;
> + }
> +
> + public int getD
> + * http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the L
> public static Image create(String id, String parent, String created,
> String container, String dockerVersion,
> String architecture, String os, long size, long virtualSize,
> List repoTags) {
>return new AutoValue_Image(id, parent, created, container,
> dockerVersion, ar
> + public abstract String status();
> +
> + @SerializedNames({"Id", "Names", "Created", "Image", "Command", "Ports",
> "Status"})
> + public static ContainerSummary create(String id, List names,
> String created, String image, String command, List ports, String
> status) {
> + return
> @@ -37,4 +46,15 @@ protected void bindErrorHandlers() {
>
> bind(HttpErrorHandler.class).annotatedWith(ClientError.class).to(DockerErrorHandler.class);
>
> bind(HttpErrorHandler.class).annotatedWith(ServerError.class).to(DockerErrorHandler.class);
> }
> +
> + @Override
> +
[jclouds-labs-pull-requests
#376](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/376/)
SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/109#issuecomment-61502209
> import javax.inject.Named;
>
> import static com.google.common.base.Preconditions.checkNotNull;
> import static com.google.common.collect.Iterables.get;
> +import java.util.Map;
maybe just do a format imports? I think there is some junk in this commit.
---
Reply to this email directly or v
>this.providerMetadata = checkNotNull(providerMetadata,
> "providerMetadata");
>this.toPortableStatus = checkNotNull(toPortableStatus,
> "toPortableStatus cannot be null");
>this.nodeNamingConvention = checkNotNull(namingConvention,
> "namingConvention").createWithoutPref
> @@ -17,12 +17,15 @@
> package org.jclouds.docker.compute.config;
>
> import com.google.common.base.Function;
> +import com.google.inject.Scopes;
looks like a mistake?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/109/files#r19740393
> @@ -69,13 +69,13 @@ protected Builder() {
> .identityName("user")
> .credentialName("password")
>
> .documentation(URI.create("https://docs.docker.com/reference/api/docker_remote_api/";))
> - .version("1.12")
> -
> @@ -16,22 +16,34 @@
> */
> package org.jclouds.docker;
>
> -import org.jclouds.docker.features.RemoteApi;
> +import org.jclouds.docker.features.ContainerApi;
> +import org.jclouds.docker.features.ImageApi;
> +import org.jclouds.docker.features.MiscApi;
> import org.jclouds.rest.annotations.
nit: maybe a better commit name? :) That way lazy folks don't have to read
JCLOUDS-737 to figure out what it is.
ex. "JCLOUDS-737 update docker to do X"
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/109#issuecomment-61496892
[jclouds » jclouds-labs
#1851](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1851/)
FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/j
[jclouds-labs-pull-requests
#375](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/375/)
FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/109#issuecomment-61496350
cc @adriancole could please review it?
You can merge this Pull Request by running:
git pull https://github.com/andreaturli/jclouds-labs master
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs/pull/109
-- Commit Summary --
* this closes JCLOUD
32 matches
Mail list logo
