[I] bug: nacos node failure should not corrupt in-memory data [apisix]
zuiyangqingzhou opened a new issue, #11252: URL: https://github.com/apache/apisix/issues/11252 ### Current Behavior https://github.com/apache/apisix/blob/master/apisix/discovery/nacos/init.lua#L354-L358 The above code logic only determines whether the MD5 value of the new data is equal to that of the data in memory, but does not verify that the new data obtained is empty. Because if an exception occurs in the nacos service, the new data obtained may be empty, causing the data in memory to be updated incorrectly. ### Expected Behavior nacos node failure should not corrupt in-memory data ### Error Logs _No response_ ### Steps to Reproduce 1. start apisix normally and configure nacos service discovery 2. you need to set the nacos service as a failure while the service is running. (Note that nacos services do not require authentication) ### Environment - APISIX version (run `apisix version`): - Operating system (run `uname -a`): - OpenResty / Nginx version (run `openresty -V` or `nginx -V`): - etcd version, if relevant (run `curl http://127.0.0.1:9090/v1/server_info`): - APISIX Dashboard version, if relevant: - Plugin runner version, for issues related to plugin runners: - LuaRocks version, for installation issues (run `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] bug: nacos node failure should not corrupt in-memory data [apisix]
github-actions[bot] closed issue #11252: bug: nacos node failure should not corrupt in-memory data URL: https://github.com/apache/apisix/issues/11252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] bug: nacos node failure should not corrupt in-memory data [apisix]
github-actions[bot] commented on issue #11252: URL: https://github.com/apache/apisix/issues/11252#issuecomment-298495 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] bug: nacos node failure should not corrupt in-memory data [apisix]
github-actions[bot] commented on issue #11252: URL: https://github.com/apache/apisix/issues/11252#issuecomment-2849122452 This issue has been marked as stale due to 350 days of inactivity. It will be closed in 2 weeks if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the d...@apisix.apache.org list. Thank you for your contributions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[I] bug: nacos node failure should not corrupt in-memory data [apisix]
zuiyangqingzhou opened a new issue, #11252: URL: https://github.com/apache/apisix/issues/11252 ### Current Behavior https://github.com/apache/apisix/blob/master/apisix/discovery/nacos/init.lua#L354-L358 The above code logic only determines whether the MD5 value of the new data is equal to that of the data in memory, but does not verify that the new data obtained is empty. Because if an exception occurs in the nacos service, the new data obtained may be empty, causing the data in memory to be updated incorrectly. ### Expected Behavior nacos node failure should not corrupt in-memory data ### Error Logs _No response_ ### Steps to Reproduce 1. start apisix normally and configure nacos service discovery 2. you need to set the nacos service as a failure while the service is running. (Note that nacos services do not require authentication) ### Environment - APISIX version (run `apisix version`): - Operating system (run `uname -a`): - OpenResty / Nginx version (run `openresty -V` or `nginx -V`): - etcd version, if relevant (run `curl http://127.0.0.1:9090/v1/server_info`): - APISIX Dashboard version, if relevant: - Plugin runner version, for issues related to plugin runners: - LuaRocks version, for installation issues (run `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
