kayx23 opened a new issue, #12954:
URL: https://github.com/apache/apisix/issues/12954
### Description
PR https://github.com/apache/apisix/pull/12861 introduces two parameters
(`keepalive_timeout` and `keepalive_pool`) to rate limiting plugins
(`limit-count`, `limit-conn`, `limit-req`).
The parameter names, `keepalive_timeout` and `keepalive_pool`, are not very
consistent with the rest of the Redis related parameters, which are prefixed by
`redis_`.
Additionally, there was a discussion for the `ai-rate-limiting` plugin to
support Redis, and the parameter controlling the redis keepalive timeout shall
be named `redis_keepalive_timeout`.
Feature added by https://github.com/apache/apisix/pull/12861 is about to be
released with 3.15.0. Given the above considerations, it would be better to
rename `keepalive_timeout` and `keepalive_pool` to `redis_keepalive_timeout`
and `redis_keepalive_pool` before the release for improved clarity and to
prevent a future breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
