Re: [PR] feat(schema-form): add enum and description support to schema parser [apisix-dashboard]
ShreyasGhodke commented on PR #3354: URL: https://github.com/apache/apisix-dashboard/pull/3354#issuecomment-4124158188 Thank you for the clarification! @Baoyuantop That makes sense — I understand that PRs should focus on more complete and concrete changes. I’ll continue the discussion and proposal in the related issue and work toward more meaningful, self-contained contributions in future PRs. Appreciate the guidance! -SG -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(schema-form): add enum and description support to schema parser [apisix-dashboard]
Baoyuantop closed pull request #3354: feat(schema-form): add enum and description support to schema parser URL: https://github.com/apache/apisix-dashboard/pull/3354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(schema-form): add enum and description support to schema parser [apisix-dashboard]
Baoyuantop commented on PR #3354: URL: https://github.com/apache/apisix-dashboard/pull/3354#issuecomment-4124126606 Hi @ShreyasGhodke, if you're simply discussing solutions, you can do so on an existing issue or an issue you created, rather than creating this PR. The content of this PR is incomplete for the current project and will cause confusion for maintainers. I will close this PR; we can continue the discussion in the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] feat(schema-form): add enum and description support to schema parser [apisix-dashboard]
ShreyasGhodke commented on PR #3354: URL: https://github.com/apache/apisix-dashboard/pull/3354#issuecomment-4110774496 Hi maintainers, This PR builds on the earlier schema parsing utility by adding enum and description support, which are commonly used in plugin schemas for form rendering. I’m currently exploring how this can be extended further toward a reusable SchemaForm system aligned with the ongoing discussions around #3274. Any feedback or suggestions would be greatly appreciated. Thank you! - SG -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] feat(schema-form): add enum and description support to schema parser [apisix-dashboard]
ShreyasGhodke opened a new pull request, #3354: URL: https://github.com/apache/apisix-dashboard/pull/3354 **Why submit this pull request?** * [ ] Bugfix * [x] New feature provided * [ ] Improve performance * [ ] Backport patches **What changes will this PR take into?** This PR extends the existing schema parsing utility by adding support for: * enum fields (mapped for select-type UI rendering) * description extraction for better UI labels and help text These enhancements improve the usability of schema-driven form generation and move the implementation closer to a complete SchemaForm system for plugin configuration. **Related issues** N/A **Checklist:** * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
