Re: [PR] fix(ai-proxy): remove `passthrough` [apisix]
shreemaan-abhishek merged PR #12014: URL: https://github.com/apache/apisix/pull/12014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] fix(ai-proxy): remove `passthrough` [apisix]
nic-6443 commented on code in PR #12014:
URL: https://github.com/apache/apisix/pull/12014#discussion_r1976553009
##
t/plugin/ai-proxy.t:
##
@@ -46,26 +46,6 @@ add_block_preprocessor(sub {
default_type 'application/json';
-location /anything {
Review Comment:
miss this one
https://github.com/apache/apisix/blob/88164f47ead10965c4c9e9a8a3368ce20f6b022c/t/plugin/ai-proxy.openai-compatible.t#L49-L67
##
t/plugin/ai-proxy.t:
##
@@ -46,26 +46,6 @@ add_block_preprocessor(sub {
default_type 'application/json';
-location /anything {
Review Comment:
miss this one
https://github.com/apache/apisix/blob/88164f47ead10965c4c9e9a8a3368ce20f6b022c/t/plugin/ai-proxy.openai-compatible.t#L49-L67
@shreemaan-abhishek
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] fix(ai-proxy): remove `passthrough` [apisix]
shreemaan-abhishek opened a new pull request, #12014: URL: https://github.com/apache/apisix/pull/12014 ### Description During development of `ai-proxy` this feature went un-noticed during back and forths of code review and it was found that it doesn't work now. So we can remove it for now and maybe add it later with full functionality. ### Checklist - [x] I have explained the need for this PR and the problem it solves - [x] I have explained the changes or the new features added to this PR - [x] I have added tests corresponding to this change - [x] I have updated the documentation to reflect this change - [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
