Re: [PR] fix(opentelemetry): remove plugin attr set_ngx_var [apisix]

2025-07-15 Thread via GitHub 


Baoyuantop merged PR #12411:
URL: https://github.com/apache/apisix/pull/12411


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] fix(opentelemetry): remove plugin attr set_ngx_var [apisix]

2025-07-15 Thread via GitHub 


AlinsRan commented on PR #12411:
URL: https://github.com/apache/apisix/pull/12411#issuecomment-3072398124

   This seems to be a break change, have we discussed it on the mailing list?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

[PR] fix(opentelemetry): remove plugin attr set_ngx_var [apisix]

2025-07-08 Thread via GitHub 


Baoyuantop opened a new pull request, #12411:
URL: https://github.com/apache/apisix/pull/12411

   ### Description
   
   We changed the attribute of the Opentelemetry plugin to metadata in PR 
https://github.com/apache/apisix/pull/11940. After that, users can set the 
`set_ngx_var` property in metadata. However, the generated template file still 
relies on the `set_ngx_var` property from the plugin attribute to predefine 
variables 
https://github.com/apache/apisix/blob/master/apisix/cli/ops.lua#L553-L556, 
which will confuse users. This PR removes this judgment and allows this 
property to be controlled in metadata only.
   
    Which issue(s) this PR fixes:
   
   Fixes #12402
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [x] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [ ] I have updated the documentation to reflect this change
   - [ ] I have verified that this change is backward compatible (If not, 
please discuss on the [APISIX mailing 
list](https://github.com/apache/apisix/tree/master#community) first)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]