Re: [I] fix(ux): no confirmation dialog when deleting a plugin from form [apisix-dashboard]
moonming commented on issue #3342: URL: https://github.com/apache/apisix-dashboard/issues/3342#issuecomment-4932691935 This was fixed by #3391 (`c8d3466`) and I verified the coverage on current `master` (`9979b31`): The confirmation now lives in the single shared card component — `src/components/form-slice/FormItemPlugins/PluginCard.tsx` wraps the delete action in `modals.openConfirmModal(...)`. Since every surface renders plugin cards through `PluginCard` (via `PluginCardList`), the confirm dialog applies to all of them: - Routes / Services / Consumers / Credentials / Plugin Configs / Global Rules form sections - the Plugin Metadata page (where confirm precedes an immediate API `DELETE`) The regression suite added in #3391 pins both paths (`e2e/tests/regression/form.plugin-delete-confirmation.spec.ts`: dialog required, chip survives cancel, confirm removes). This can be closed. One small follow-up worth a separate cleanup: the plugin-card confirm modal's wording/styling differs slightly from `DeleteResourceBtn`'s (not centered, no bold target name) — unifying them into one shared delete-confirm helper would keep the UX consistent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] fix(ux): no confirmation dialog when deleting a plugin from form [apisix-dashboard]
Baoyuantop commented on issue #3342: URL: https://github.com/apache/apisix-dashboard/issues/3342#issuecomment-4140561234 I think we can close this now, unless anyone disagrees with me, in which case feel free to continue commenting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] fix(ux): no confirmation dialog when deleting a plugin from form [apisix-dashboard]
vanshaj2023 commented on issue #3342: URL: https://github.com/apache/apisix-dashboard/issues/3342#issuecomment-4130422659 Hi @Baoyuantop, Thanks for the clarification. Do we have to keep this issue open to fix later, or should we just close the issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] fix(ux): no confirmation dialog when deleting a plugin from form [apisix-dashboard]
Baoyuantop commented on issue #3342: URL: https://github.com/apache/apisix-dashboard/issues/3342#issuecomment-4118651884 I don’t think this feature is necessary. Since we’re currently on the data creation page rather than the edit page, removing the plugin simply deletes it from the data being created—it has no impact on active configurations. Therefore, there’s no need for this additional confirmation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] fix(ux): no confirmation dialog when deleting a plugin from form [apisix-dashboard]
vanshaj2023 commented on issue #3342: URL: https://github.com/apache/apisix-dashboard/issues/3342#issuecomment-4113647114 Hi @Jaswanth-arjun , I just say wait for maintainers confirmation then fix the issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] fix(ux): no confirmation dialog when deleting a plugin from form [apisix-dashboard]
Jaswanth-arjun commented on issue #3342: URL: https://github.com/apache/apisix-dashboard/issues/3342#issuecomment-4108447308 Hlo @vanshaj2023 it mean the current issue #3342 not assigned to me?where i already submitted PR #3345. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] fix(ux): no confirmation dialog when deleting a plugin from form [apisix-dashboard]
vanshaj2023 commented on issue #3342: URL: https://github.com/apache/apisix-dashboard/issues/3342#issuecomment-4108218319 Hi @Baoyuantop Please review this issue. I think we must add confirmation here. Do I start working and submit a pr regarding this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] fix(ux): no confirmation dialog when deleting a plugin from form [apisix-dashboard]
Jaswanth-arjun commented on issue #3342: URL: https://github.com/apache/apisix-dashboard/issues/3342#issuecomment-4105396541 Thank you @vanshaj2023 for your guidence, As a beginer i dont know full details about how to contribute,As i fixed already bug what should i do now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] fix(ux): no confirmation dialog when deleting a plugin from form [apisix-dashboard]
utkarshsingh1102 commented on issue #3342: URL: https://github.com/apache/apisix-dashboard/issues/3342#issuecomment-4105298561 Hi @vanshaj2023 , I’d like to take up issue #3342 (missing confirmation dialog when deleting a plugin from the form). My proposed approach: Introduce a confirmation modal in PluginCard.tsx using modals.openConfirmModal Extract a handleDelete function to trigger the modal Ensure onDelete?.(name) is only executed inside onConfirm Keep the modal configuration consistent with DeleteResourceBtn (same confirmProps and i18n keys like info.delete.title, info.delete.content, etc.) This will align plugin deletion UX with existing resource deletion behavior and prevent accidental removals. Please let me know if this approach works or if you'd prefer any adjustments before I proceed. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] fix(ux): no confirmation dialog when deleting a plugin from form [apisix-dashboard]
vanshaj2023 commented on issue #3342: URL: https://github.com/apache/apisix-dashboard/issues/3342#issuecomment-4103514192 Hi @Jaswanth-arjun , Thanks for the pr. But it is not the right way of contribution you have to first wait for the reply or assignment then start working. Please read contribution.md. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] fix(ux): no confirmation dialog when deleting a plugin from form [apisix-dashboard]
Jaswanth-arjun commented on issue #3342: URL: https://github.com/apache/apisix-dashboard/issues/3342#issuecomment-4103084171 Hi @vanshaj2023 , I have worked on this issue and opened a PR: https://github.com/apache/apisix-dashboard/pull/3345 This PR adds a confirmation dialog before deleting a plugin to prevent accidental removal and aligns with existing UX patterns. Please review when possible. Thanks! https://github.com/user-attachments/assets/9fad2322-b54a-4b52-a90c-084dcdee747f"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] fix(ux): no confirmation dialog when deleting a plugin from form [apisix-dashboard]
Jaswanth-arjun commented on issue #3342: URL: https://github.com/apache/apisix-dashboard/issues/3342#issuecomment-4103055929 Hi @vanshaj2023, I would like to work on this issue. I am planning to add a confirmation dialog before deleting a plugin, similar to DeleteResourceBtn using modals.openConfirmModal, to ensure consistent UX across the dashboard. Please let me know if this approach is fine or if any specific behavior is expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] fix(ux): no confirmation dialog when deleting a plugin from form [apisix-dashboard]
Jaswanth-arjun commented on issue #3342: URL: https://github.com/apache/apisix-dashboard/issues/3342#issuecomment-4103019054 hi @vanshaj2023 for me not showing any select plugins option as shown in image could you please help me to achieve this https://github.com/user-attachments/assets/0168c5bb-a586-404b-ba21-d26c9a42ee58"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [I] fix(ux): no confirmation dialog when deleting a plugin from form [apisix-dashboard]
vanshaj2023 commented on issue #3342: URL: https://github.com/apache/apisix-dashboard/issues/3342#issuecomment-4101389681 Hi @Baoyuantop , I noticed that clicking Delete on a plugin card immediately removes it with no confirmation, which can cause accidental data loss. Would you like me to fix this? I can wrap the delete call in `modals.openConfirmModal`, same pattern already used in `DeleteResourceBtn.tsx`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
