Re: [PR] docs(ai-proxy): clarify logging options apply to structured access logs not error.log [apisix]
Baoyuantop merged PR #13187: URL: https://github.com/apache/apisix/pull/13187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs(ai-proxy): clarify logging options apply to structured access logs not error.log [apisix]
kayx23 commented on code in PR #13187: URL: https://github.com/apache/apisix/pull/13187#discussion_r3062002029 ## docs/en/latest/plugins/ai-proxy-multi.md: ## @@ -37,7 +37,7 @@ description: The ai-proxy-multi Plugin extends the capabilities of ai-proxy with The `ai-proxy-multi` Plugin simplifies access to LLM and embedding models by transforming Plugin configurations into the designated request format for OpenAI, DeepSeek, Azure, AIMLAPI, Anthropic, OpenRouter, Gemini, Vertex AI, and other OpenAI-compatible APIs. It extends the capabilities of [`ai-proxy`](./ai-proxy.md) with load balancing, retries, fallbacks, and health checks. -In addition, the Plugin also supports logging LLM request information in the access log, such as token usage, model, time to the first response, and more. +In addition, the Plugin also supports logging LLM request information in the access log, such as token usage, model, time to the first response, and more. These log entries are also consumed by logging plugins such as `http-logger` and `kafka-logger`. These options do not affect `error.log`. Review Comment: ```suggestion In addition, the Plugin also supports logging LLM request information in the access log, such as token usage, model, time to the first response, and more. These log entries are also consumed by logging plugins such as `http-logger` and `kafka-logger`, and do not affect error log. ``` ## docs/zh/latest/plugins/ai-proxy-multi.md: ## @@ -37,7 +37,7 @@ description: ai-proxy-multi 插件通过负载均衡、重试、故障转移和 `ai-proxy-multi` 插件通过将插件配置转换为 OpenAI、DeepSeek、Azure、AIMLAPI、Anthropic、OpenRouter、Gemini、Vertex AI 和其他 OpenAI 兼容 API 的指定请求格式，简化了对 LLM 和嵌入模型的访问。它通过负载均衡、重试、故障转移和健康检查扩展了 [`ai-proxy`](./ai-proxy.md) 的功能。 -此外，该插件还支持在访问日志中记录 LLM 请求信息，如令牌使用量、模型、首次响应时间等。 +此外，该插件还支持在访问日志中记录 LLM 请求信息，如令牌使用量、模型、首次响应时间等。这些日志条目也会被 `http-logger`、`kafka-logger` 等日志插件消费。这些选项不影响 `error.log`。 Review Comment: ```suggestion 此外，该插件还支持在访问日志中记录 LLM 请求信息，如令牌使用量、模型、首次响应时间等。这些日志条目也会被 `http-logger`、`kafka-logger` 等日志插件消费，但不影响 `error.log`。 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs(ai-proxy): clarify logging options apply to structured access logs not error.log [apisix]
janiussyafiq commented on code in PR #13187: URL: https://github.com/apache/apisix/pull/13187#discussion_r3061973623 ## docs/en/latest/plugins/ai-proxy-multi.md: ## @@ -74,8 +74,8 @@ In addition, the Plugin also supports logging LLM request information in the acc | instances.options | object | False| | | Model configurations. In addition to `model`, you can configure additional parameters and they will be forwarded to the upstream LLM service in the request body. For instance, if you are working with OpenAI, DeepSeek, or AIMLAPI, you can configure additional parameters such as `max_tokens`, `temperature`, `top_p`, and `stream`. See your LLM provider's API documentation for more available options. | | instances.options.model | string | False| | | Name of the LLM model, such as `gpt-4` or `gpt-3.5`. See your LLM provider's API documentation for more available models. | | logging | object | False| | | Logging configurations. | Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs(ai-proxy): clarify logging options apply to structured access logs not error.log [apisix]
kayx23 commented on code in PR #13187: URL: https://github.com/apache/apisix/pull/13187#discussion_r3061941666 ## docs/en/latest/plugins/ai-proxy-multi.md: ## @@ -74,8 +74,8 @@ In addition, the Plugin also supports logging LLM request information in the acc | instances.options | object | False| | | Model configurations. In addition to `model`, you can configure additional parameters and they will be forwarded to the upstream LLM service in the request body. For instance, if you are working with OpenAI, DeepSeek, or AIMLAPI, you can configure additional parameters such as `max_tokens`, `temperature`, `top_p`, and `stream`. See your LLM provider's API documentation for more available options. | | instances.options.model | string | False| | | Name of the LLM model, such as `gpt-4` or `gpt-3.5`. See your LLM provider's API documentation for more available models. | | logging | object | False| | | Logging configurations. | Review Comment: The information should perhaps be added here (parent) if it's applicable to all the parameters within? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs(ai-proxy): clarify logging options apply to structured access logs not error.log [apisix]
kayx23 commented on code in PR #13187: URL: https://github.com/apache/apisix/pull/13187#discussion_r3057073680 ## docs/en/latest/plugins/ai-proxy-multi.md: ## @@ -37,7 +37,7 @@ description: The ai-proxy-multi Plugin extends the capabilities of ai-proxy with The `ai-proxy-multi` Plugin simplifies access to LLM and embedding models by transforming Plugin configurations into the designated request format for OpenAI, DeepSeek, Azure, AIMLAPI, Anthropic, OpenRouter, Gemini, Vertex AI, and other OpenAI-compatible APIs. It extends the capabilities of [`ai-proxy`](./ai-proxy.md) with load balancing, retries, fallbacks, and health checks. -In addition, the Plugin also supports logging LLM request information in the access log, such as token usage, model, time to the first response, and more. +In addition, the Plugin also supports appending LLM request information to structured access log entries, such as token usage, model, time to the first response, and more. These structured entries are consumed by logging plugins such as `http-logger` and `kafka-logger`, and are separate from the debug messages written to `error.log`. Review Comment: Sure, as long as it reads well. The same idea applies to the parameter description as well. Please make sure they are adjusted accordingly. I think the intention of this PR is just to clarify error log is not affected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs(ai-proxy): clarify logging options apply to structured access logs not error.log [apisix]
kayx23 commented on code in PR #13187: URL: https://github.com/apache/apisix/pull/13187#discussion_r3057073680 ## docs/en/latest/plugins/ai-proxy-multi.md: ## @@ -37,7 +37,7 @@ description: The ai-proxy-multi Plugin extends the capabilities of ai-proxy with The `ai-proxy-multi` Plugin simplifies access to LLM and embedding models by transforming Plugin configurations into the designated request format for OpenAI, DeepSeek, Azure, AIMLAPI, Anthropic, OpenRouter, Gemini, Vertex AI, and other OpenAI-compatible APIs. It extends the capabilities of [`ai-proxy`](./ai-proxy.md) with load balancing, retries, fallbacks, and health checks. -In addition, the Plugin also supports logging LLM request information in the access log, such as token usage, model, time to the first response, and more. +In addition, the Plugin also supports appending LLM request information to structured access log entries, such as token usage, model, time to the first response, and more. These structured entries are consumed by logging plugins such as `http-logger` and `kafka-logger`, and are separate from the debug messages written to `error.log`. Review Comment: Sure, as long as it reads well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs(ai-proxy): clarify logging options apply to structured access logs not error.log [apisix]
janiussyafiq commented on code in PR #13187: URL: https://github.com/apache/apisix/pull/13187#discussion_r3056878216 ## docs/en/latest/plugins/ai-proxy-multi.md: ## @@ -37,7 +37,7 @@ description: The ai-proxy-multi Plugin extends the capabilities of ai-proxy with The `ai-proxy-multi` Plugin simplifies access to LLM and embedding models by transforming Plugin configurations into the designated request format for OpenAI, DeepSeek, Azure, AIMLAPI, Anthropic, OpenRouter, Gemini, Vertex AI, and other OpenAI-compatible APIs. It extends the capabilities of [`ai-proxy`](./ai-proxy.md) with load balancing, retries, fallbacks, and health checks. -In addition, the Plugin also supports logging LLM request information in the access log, such as token usage, model, time to the first response, and more. +In addition, the Plugin also supports appending LLM request information to structured access log entries, such as token usage, model, time to the first response, and more. These structured entries are consumed by logging plugins such as `http-logger` and `kafka-logger`, and are separate from the debug messages written to `error.log`. Review Comment: agreed. should we keep the first sentence from before, and just add the additional sentence explicitly mentioning the logging plugins and error.log? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs(ai-proxy): clarify logging options apply to structured access logs not error.log [apisix]
kayx23 commented on code in PR #13187: URL: https://github.com/apache/apisix/pull/13187#discussion_r3056814604 ## docs/en/latest/plugins/ai-proxy-multi.md: ## @@ -37,7 +37,7 @@ description: The ai-proxy-multi Plugin extends the capabilities of ai-proxy with The `ai-proxy-multi` Plugin simplifies access to LLM and embedding models by transforming Plugin configurations into the designated request format for OpenAI, DeepSeek, Azure, AIMLAPI, Anthropic, OpenRouter, Gemini, Vertex AI, and other OpenAI-compatible APIs. It extends the capabilities of [`ai-proxy`](./ai-proxy.md) with load balancing, retries, fallbacks, and health checks. -In addition, the Plugin also supports logging LLM request information in the access log, such as token usage, model, time to the first response, and more. +In addition, the Plugin also supports appending LLM request information to structured access log entries, such as token usage, model, time to the first response, and more. These structured entries are consumed by logging plugins such as `http-logger` and `kafka-logger`, and are separate from the debug messages written to `error.log`. Review Comment: The access log here meant: https://github.com/user-attachments/assets/40d9161b-5ac0-4406-93fb-3f451032ec37"; /> I think this update has tweaked the original meaning a bit. The sentence could be updated to cover both the access logs and usage with loggers. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs(ai-proxy): clarify logging options apply to structured access logs not error.log [apisix]
kayx23 commented on code in PR #13187: URL: https://github.com/apache/apisix/pull/13187#discussion_r3056814604 ## docs/en/latest/plugins/ai-proxy-multi.md: ## @@ -37,7 +37,7 @@ description: The ai-proxy-multi Plugin extends the capabilities of ai-proxy with The `ai-proxy-multi` Plugin simplifies access to LLM and embedding models by transforming Plugin configurations into the designated request format for OpenAI, DeepSeek, Azure, AIMLAPI, Anthropic, OpenRouter, Gemini, Vertex AI, and other OpenAI-compatible APIs. It extends the capabilities of [`ai-proxy`](./ai-proxy.md) with load balancing, retries, fallbacks, and health checks. -In addition, the Plugin also supports logging LLM request information in the access log, such as token usage, model, time to the first response, and more. +In addition, the Plugin also supports appending LLM request information to structured access log entries, such as token usage, model, time to the first response, and more. These structured entries are consumed by logging plugins such as `http-logger` and `kafka-logger`, and are separate from the debug messages written to `error.log`. Review Comment: The access log here meant: https://github.com/user-attachments/assets/40d9161b-5ac0-4406-93fb-3f451032ec37"; /> I think this update has tweaked the original meaning a bit. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs(ai-proxy): clarify logging options apply to structured access logs not error.log [apisix]
Baoyuantop commented on code in PR #13187: URL: https://github.com/apache/apisix/pull/13187#discussion_r3056555916 ## docs/en/latest/plugins/ai-proxy.md: ## @@ -37,7 +37,7 @@ description: The ai-proxy Plugin simplifies access to LLM and embedding models p The `ai-proxy` Plugin simplifies access to LLM and embedding models by transforming Plugin configurations into the designated request format. It supports the integration with OpenAI, DeepSeek, Azure, AIMLAPI, Anthropic, OpenRouter, Gemini, Vertex AI, and other OpenAI-compatible APIs. -In addition, the Plugin also supports logging LLM request information in the access log, such as token usage, model, time to the first response, and more. +In addition, the Plugin also supports appending LLM request information to structured access log entries, such as token usage, model, time to the first response, and more. These structured entries are consumed by logging plugins such as `http-logger` and `kafka-logger`, and are separate from the debug messages written to `error.log` Review Comment: ```suggestion In addition, the Plugin also supports appending LLM request information to structured access log entries, such as token usage, model, time to the first response, and more. These structured entries are consumed by logging plugins such as `http-logger` and `kafka-logger`, and are separate from the debug messages written to `error.log`. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
