Re: [PR] docs: fix description error in upgrade doc [apisix-ingress-controller]
juzhiyuan merged PR #2440: URL: https://github.com/apache/apisix-ingress-controller/pull/2440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs: fix description error in upgrade doc [apisix-ingress-controller]
kayx23 commented on PR #2440: URL: https://github.com/apache/apisix-ingress-controller/pull/2440#issuecomment-3067971676 @juzhiyuan / @bzp2010 please review again the updated content -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs: fix description error in upgrade doc [apisix-ingress-controller]
kayx23 commented on code in PR #2440: URL: https://github.com/apache/apisix-ingress-controller/pull/2440#discussion_r2203806907 ## docs/en/latest/upgrade-guide.md: ## @@ -197,10 +197,10 @@ Ingress annotations used in version 1.x.x are not fully supported in 2.0.0. If y ### Summary -| Category | Description | -| | | -| Architecture | The `mock-etcd` component has been removed. Configuration is now centralized through the Controller. | -| Configuration| Static configuration fields have been removed. Use `GatewayProxy` CRD to configure the data plane. | -| Data Plane | Requires APISIX version 3.13.0 running in `standalone` mode. | -| API | Some fields in `Ingress Annotations` and `ApisixUpstream` are not yet supported. | -| Upgrade Strategy | Blue-green deployment or canary release is recommended before full switchover. | +| Category | Description | +| | - | +| Architecture | The `mock-etcd` component has been removed. Configuration is now centralized through the Controller. | +| Configuration| Static configuration fields have been removed. Use `GatewayProxy` CRD to configure the data plane.| +| Data Plane | The Admin API configuration method is still supported, and support for the Standalone API-driven mode introduced in APISIX 3.13+. | Review Comment: ```suggestion | Data Plane | The Admin API configuration method is still supported. Support for the Standalone API-driven mode was introduced in APISIX 3.13.0 and later. | ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs: fix description error in upgrade doc [apisix-ingress-controller]
AlinsRan commented on code in PR #2440: URL: https://github.com/apache/apisix-ingress-controller/pull/2440#discussion_r2203766005 ## docs/en/latest/upgrade-guide.md: ## @@ -64,7 +64,7 @@ etcdserver: # Controller-Only Configuration Source -In 2.0.0, all data plane configurations must originate from the Ingress Controller. Configurations via Admin API or any external methods are no longer supported and will be ignored or may cause errors. +In APISIX Ingress Controller 2.0.0, a full-sync mode is used. All Data Plane configurations must originate from the Ingress Controller. Any additional route configurations made via the Admin API or other external methods will be ignored. Review Comment: > Manual Admin API operations outside of the ingress controller will be overridden by regular full updates. We used to allow those user-created resources to co-exist with those created by the ingress controller, which was frankly a mistake in itself. That's right, I changed the description, please check again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs: fix description error in upgrade doc [apisix-ingress-controller]
bzp2010 commented on code in PR #2440: URL: https://github.com/apache/apisix-ingress-controller/pull/2440#discussion_r2203706054 ## docs/en/latest/upgrade-guide.md: ## @@ -64,7 +64,7 @@ etcdserver: # Controller-Only Configuration Source -In 2.0.0, all data plane configurations must originate from the Ingress Controller. Configurations via Admin API or any external methods are no longer supported and will be ignored or may cause errors. +In APISIX Ingress Controller 2.0.0, a full-sync mode is used. All Data Plane configurations must originate from the Ingress Controller. Any additional route configurations made via the Admin API or other external methods will be ignored. Review Comment: This is ambiguous and should be edited. > Any additional route configurations made via the Admin API or other external methods will be ignored. Manual Admin API operations outside of the ingress controller will be overridden by regular full updates. We used to allow those user-created resources to co-exist with those created by the ingress controller, which was frankly a mistake in itself. The description should be made clearer to clarify that both Admin API and standalone mode are supported. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs: fix description error in upgrade doc [apisix-ingress-controller]
juzhiyuan commented on code in PR #2440: URL: https://github.com/apache/apisix-ingress-controller/pull/2440#discussion_r2203675383 ## docs/en/latest/upgrade-guide.md: ## @@ -64,7 +64,7 @@ etcdserver: # Controller-Only Configuration Source -In 2.0.0, all data plane configurations must originate from the Ingress Controller. Configurations via Admin API or any external methods are no longer supported and will be ignored or may cause errors. +In APISIX Ingress Controller 2.0.0, a full-sync mode is used. All Data Plane configurations must originate from the Ingress Controller. Any additional route configurations made via the Admin API or other external methods will be ignored. Review Comment: Maybe this is outdated. @AlinsRan, please confirm and update the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs: fix description error in upgrade doc [apisix-ingress-controller]
juzhiyuan commented on code in PR #2440: URL: https://github.com/apache/apisix-ingress-controller/pull/2440#discussion_r2203674955 ## docs/en/latest/upgrade-guide.md: ## @@ -64,7 +64,7 @@ etcdserver: # Controller-Only Configuration Source -In 2.0.0, all data plane configurations must originate from the Ingress Controller. Configurations via Admin API or any external methods are no longer supported and will be ignored or may cause errors. +In APISIX Ingress Controller 2.0.0, a full-sync mode is used. All Data Plane configurations must originate from the Ingress Controller. Any additional route configurations made via the Admin API or other external methods will be ignored. Review Comment: > All Data Plane configurations must originate from the Ingress Controller. Any additional route configurations made via the Admin API or other external methods will be ignored. I'm still confused by this. Ingress Controller 2.0 supports both Standalone and Admin API mode, so why `Any additional route configurations made via the Admin API or other external methods will be ignored.`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
