Re: [PR] docs: sync AI plugins in config.yaml.example [apisix]
Baoyuantop commented on PR #13109: URL: https://github.com/apache/apisix/pull/13109#issuecomment-4293725109 I'm closing this PR due to prolonged lack of response. Thank you for your contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs: sync AI plugins in config.yaml.example [apisix]
Baoyuantop closed pull request #13109: docs: sync AI plugins in config.yaml.example URL: https://github.com/apache/apisix/pull/13109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs: sync AI plugins in config.yaml.example [apisix]
Baoyuantop commented on PR #13109: URL: https://github.com/apache/apisix/pull/13109#issuecomment-4167188729 Hi @saudademjj, following up on the previous review comments. Please let us know if you have any updates. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs: sync AI plugins in config.yaml.example [apisix]
Baoyuantop commented on PR #13109: URL: https://github.com/apache/apisix/pull/13109#issuecomment-4139867066 Hi @saudademjj, please do not make any further changes to the t/cli/test_etcd_sync_event_handle.sh file, or explain the purpose of your current changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs: sync AI plugins in config.yaml.example [apisix]
Baoyuantop commented on PR #13109: URL: https://github.com/apache/apisix/pull/13109#issuecomment-4131920311 Hi @saudademjj, it looks like there are some unrelated code changes in the PR. Could you confirm if they're necessary? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] docs: sync AI plugins in config.yaml.example [apisix]
Baoyuantop commented on code in PR #13109:
URL: https://github.com/apache/apisix/pull/13109#discussion_r2985964534
##
t/cli/test_etcd_sync_event_handle.sh:
##
@@ -19,6 +19,17 @@
. ./t/cli/common.sh
+clean_up() {
Review Comment:
Why is this section needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
