Re: [PR] feat(wolf): improve the error message when requesting to wolf failed [apisix]
Baoyuantop commented on PR #12238: URL: https://github.com/apache/apisix/pull/12238#issuecomment-3030324083 Hi @gaoxingliang, can you get CI to pass? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat(wolf): improve the error message when requesting to wolf failed [apisix]
gaoxingliang commented on PR #12238: URL: https://github.com/apache/apisix/pull/12238#issuecomment-2899783771 Hi @moonming, this pr provides the ability to hide the wolf existence for user. previous version doesn't provide this ability. that's to say: if a user provides a wrong username or password, or any other error encountered, the user will receive a message: `request to wolf failed`. This pr provides a setting to customize this message eg, you can set it to : 'auth fail encountered.' Or do you mean I need to set the default error message to some other error instead of previous `request to wolf...`? I set it as default to keep compabalility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] feat(wolf): improve the error message when requesting to wolf failed [apisix]
moonming commented on PR #12238: URL: https://github.com/apache/apisix/pull/12238#issuecomment-2896931808 @gaoxingliang thanks for this PR. I have a question, is it necessary to let the client know about the existence of the Wolf plugin? Of course, this was not introduced by this PR. Is just log local error ok? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
