Re: [PR] fix(plugin): add confirmation dialog before deleting plugin card [apisix-dashboard]

2026-03-22 Thread via GitHub 


Jaswanth-arjun commented on PR #3345:
URL: 
https://github.com/apache/apisix-dashboard/pull/3345#issuecomment-4108429677

   Hi @Baoyuantop actually i am fixing bugs which are i seen in issues tab 
#3342 
   and my PR was #3345 ,Thank you for your suggestion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] fix(plugin): add confirmation dialog before deleting plugin card [apisix-dashboard]

2026-03-22 Thread via GitHub 


Baoyuantop commented on PR #3345:
URL: 
https://github.com/apache/apisix-dashboard/pull/3345#issuecomment-4107794675

   I don’t think this feature is necessary. Since we’re currently on the data 
creation page rather than the edit page, removing the plugin simply deletes it 
from the data being created—it has no impact on active configurations. 
Therefore, there’s no need for this additional confirmation.
   
   Hi @Jaswanth-arjun, before submitting a contribution, please create an issue 
describing your problem or request. Once the community has reviewed and 
approved it, submit a pull request to complete the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]