Re: [PR] fix: Fixed Dockerfiles to be able to run in Openshift without anyuid [apisix-docker]
shreemaan-abhishek commented on PR #617: URL: https://github.com/apache/apisix-docker/pull/617#issuecomment-4776593722 Hey @vgeorgiev69 and @kevinfoote. This is included in docker images for v3.17.0 (check the release branch: https://github.com/apache/apisix-docker/tree/release/apisix-3.17.0), we don't publish changelogs for apisix-docker. If you face any issues please let us know, thanks 🙏🏼 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Fixed Dockerfiles to be able to run in Openshift without anyuid [apisix-docker]
vgeorgiev69 commented on PR #617: URL: https://github.com/apache/apisix-docker/pull/617#issuecomment-4728098408 > I'm also wondering on the ETA when this will get picked up into release. Looking at the notes for upcoming 3.17 I did not see anything that indicated this was pulled in. Can anyone on the apisix crew shed some light ? This was not introduced in 3.17 either, so I'm guessing it's a separate release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Fixed Dockerfiles to be able to run in Openshift without anyuid [apisix-docker]
kevinfoote commented on PR #617: URL: https://github.com/apache/apisix-docker/pull/617#issuecomment-4675315122 I'm also wondering on the ETA when this will get picked up into release. Looking at the notes for 3.17 I did not see anything that indicated this was pulled in. Can anyone on the apisix crew shed some light ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Fixed Dockerfiles to be able to run in Openshift without anyuid [apisix-docker]
vgeorgiev69 commented on PR #617: URL: https://github.com/apache/apisix-docker/pull/617#issuecomment-4508774060 Hello there, is there any ETA of when this would be introduced in the newer versions? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Fixed Dockerfiles to be able to run in Openshift without anyuid [apisix-docker]
shreemaan-abhishek merged PR #617: URL: https://github.com/apache/apisix-docker/pull/617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Fixed Dockerfiles to be able to run in Openshift without anyuid [apisix-docker]
shreemaan-abhishek commented on code in PR #617: URL: https://github.com/apache/apisix-docker/pull/617#discussion_r3050118934 ## redhat/Dockerfile: ## @@ -35,11 +35,19 @@ WORKDIR /usr/local/apisix ENV PATH=$PATH:/usr/local/openresty/luajit/bin:/usr/local/openresty/nginx/sbin:/usr/local/openresty/bin +RUN groupadd --system --gid 636 apisix \ +&& useradd --system --gid apisix --no-create-home --shell /usr/sbin/nologin --uid 636 apisix \ +&& chown -R apisix:0 /usr/local/apisix \ +&& chgrp -R 0 /usr/local/apisix \ Review Comment: the line above this already changes the group to 0, so you can remove this now (from all three Dockerfiles) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Fixed Dockerfiles to be able to run in Openshift without anyuid [apisix-docker]
shreemaan-abhishek commented on code in PR #617: URL: https://github.com/apache/apisix-docker/pull/617#discussion_r3050116485 ## redhat/Dockerfile: ## @@ -35,11 +35,19 @@ WORKDIR /usr/local/apisix ENV PATH=$PATH:/usr/local/openresty/luajit/bin:/usr/local/openresty/nginx/sbin:/usr/local/openresty/bin +RUN groupadd --system --gid 636 apisix \ +&& useradd --system --gid apisix --no-create-home --shell /usr/sbin/nologin --uid 636 apisix \ +&& chown -R apisix:0 /usr/local/apisix \ +&& chgrp -R 0 /usr/local/apisix \ Review Comment: the line above this already changes the group to 0, so you can remove this now (from all three Dockerfiles) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Fixed Dockerfiles to be able to run in Openshift without anyuid [apisix-docker]
shreemaan-abhishek commented on code in PR #617: URL: https://github.com/apache/apisix-docker/pull/617#discussion_r3050116485 ## redhat/Dockerfile: ## @@ -35,11 +35,19 @@ WORKDIR /usr/local/apisix ENV PATH=$PATH:/usr/local/openresty/luajit/bin:/usr/local/openresty/nginx/sbin:/usr/local/openresty/bin +RUN groupadd --system --gid 636 apisix \ +&& useradd --system --gid apisix --no-create-home --shell /usr/sbin/nologin --uid 636 apisix \ +&& chown -R apisix:0 /usr/local/apisix \ +&& chgrp -R 0 /usr/local/apisix \ Review Comment: the line above this already changes the group to 0, so you can remove this now (from all three Dockerfiles) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Fixed Dockerfiles to be able to run in Openshift without anyuid [apisix-docker]
AlinsRan commented on code in PR #617: URL: https://github.com/apache/apisix-docker/pull/617#discussion_r3048887213 ## debian/Dockerfile: ## @@ -53,7 +53,9 @@ ENV PATH=$PATH:/usr/local/openresty/luajit/bin:/usr/local/openresty/nginx/sbin:/ RUN groupadd --system --gid 636 apisix \ && useradd --system --gid apisix --no-create-home --shell /usr/sbin/nologin --uid 636 apisix \ -&& chown -R apisix:apisix /usr/local/apisix +&& chown -R apisix:apisix /usr/local/apisix \ +&& chgrp -R 0 /usr/local/apisix \ Review Comment: The original two commands: 1. `chown -R apisix:apisix /usr/local/apisix` sets the user to `apisix` and the group to `apisix`. 2. `chgrp -R 0 /usr/local/apisix` changes the group to `0` (root). The combined command `chown -R apisix:0` achieves the **exact same result** in one step: owner `apisix`, group `0`. It's cleaner and equivalent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Fixed Dockerfiles to be able to run in Openshift without anyuid [apisix-docker]
sebgott commented on code in PR #617: URL: https://github.com/apache/apisix-docker/pull/617#discussion_r3043935923 ## debian/Dockerfile: ## @@ -53,7 +53,9 @@ ENV PATH=$PATH:/usr/local/openresty/luajit/bin:/usr/local/openresty/nginx/sbin:/ RUN groupadd --system --gid 636 apisix \ && useradd --system --gid apisix --no-create-home --shell /usr/sbin/nologin --uid 636 apisix \ -&& chown -R apisix:apisix /usr/local/apisix +&& chown -R apisix:apisix /usr/local/apisix \ +&& chgrp -R 0 /usr/local/apisix \ Review Comment: Had some time so changed to root group. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Fixed Dockerfiles to be able to run in Openshift without anyuid [apisix-docker]
sebgott commented on code in PR #617: URL: https://github.com/apache/apisix-docker/pull/617#discussion_r3043794164 ## debian/Dockerfile: ## @@ -53,7 +53,9 @@ ENV PATH=$PATH:/usr/local/openresty/luajit/bin:/usr/local/openresty/nginx/sbin:/ RUN groupadd --system --gid 636 apisix \ && useradd --system --gid apisix --no-create-home --shell /usr/sbin/nologin --uid 636 apisix \ -&& chown -R apisix:apisix /usr/local/apisix +&& chown -R apisix:apisix /usr/local/apisix \ +&& chgrp -R 0 /usr/local/apisix \ Review Comment: I just got back from holiday. I will take a look at this today possibly tomorrow as I need to get back into work :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Fixed Dockerfiles to be able to run in Openshift without anyuid [apisix-docker]
Baoyuantop commented on code in PR #617: URL: https://github.com/apache/apisix-docker/pull/617#discussion_r3043411542 ## debian/Dockerfile: ## @@ -53,7 +53,9 @@ ENV PATH=$PATH:/usr/local/openresty/luajit/bin:/usr/local/openresty/nginx/sbin:/ RUN groupadd --system --gid 636 apisix \ && useradd --system --gid apisix --no-create-home --shell /usr/sbin/nologin --uid 636 apisix \ -&& chown -R apisix:apisix /usr/local/apisix +&& chown -R apisix:apisix /usr/local/apisix \ +&& chgrp -R 0 /usr/local/apisix \ Review Comment: @sebgott, please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Fixed Dockerfiles to be able to run in Openshift without anyuid [apisix-docker]
AlinsRan commented on code in PR #617: URL: https://github.com/apache/apisix-docker/pull/617#discussion_r3042705383 ## debian/Dockerfile: ## @@ -53,7 +53,9 @@ ENV PATH=$PATH:/usr/local/openresty/luajit/bin:/usr/local/openresty/nginx/sbin:/ RUN groupadd --system --gid 636 apisix \ && useradd --system --gid apisix --no-create-home --shell /usr/sbin/nologin --uid 636 apisix \ -&& chown -R apisix:apisix /usr/local/apisix +&& chown -R apisix:apisix /usr/local/apisix \ +&& chgrp -R 0 /usr/local/apisix \ Review Comment: `chown -R apisix:0 /usr/local/apisix` How about this?？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Fixed Dockerfiles to be able to run in Openshift without anyuid [apisix-docker]
kevinfoote commented on PR #617: URL: https://github.com/apache/apisix-docker/pull/617#issuecomment-4157963910 @sebgott and crew ❤️ 👍 I have been trying to track down the completion of this for a few days now. Love to see this get merged. I'm pulling the DEV container at the moment and would love to get off that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: Fixed Dockerfiles to be able to run in Openshift without anyuid [apisix-docker]
sebgott commented on PR #617: URL: https://github.com/apache/apisix-docker/pull/617#issuecomment-4133631013 I removed the debian-dev changes as it is used for the :dev tag, judging from the Makefile, which already works without anyuid permissions. I built the redhat image as it is and I am currently running it in my Openshift environment, and I do not need to provide anyuid permissions to apisix, but I will align the Dockerfile with how the debian and ubuntu images are built. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
