Re: [PR] fix: added proper redirection to ingress-controller docs [apisix-website]
Baoyuantop merged PR #1976: URL: https://github.com/apache/apisix-website/pull/1976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: added proper redirection to ingress-controller docs [apisix-website]
ayush00git commented on PR #1976: URL: https://github.com/apache/apisix-website/pull/1976#issuecomment-3669554851 Hey @Baoyuantop I've made the requested changes, please go through the PR and let me know, how to proceed : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: added proper redirection to ingress-controller docs [apisix-website]
ayush00git commented on code in PR #1976: URL: https://github.com/apache/apisix-website/pull/1976#discussion_r2630386819 ## config/downloads.js: ## @@ -27,7 +27,7 @@ module.exports = [ dockerhubPath: 'apisix-ingress-controller', version: '1.6.0', releaseDate: '2022-12-30', Review Comment: > Hi @ayush00git, this needs to be modified as well. Hii @Baoyuantop thanks for the review, i'll quickly make the changes and push the commit : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: added proper redirection to ingress-controller docs [apisix-website]
Baoyuantop commented on code in PR #1976: URL: https://github.com/apache/apisix-website/pull/1976#discussion_r2630379270 ## config/downloads.js: ## @@ -27,7 +27,7 @@ module.exports = [ dockerhubPath: 'apisix-ingress-controller', version: '1.6.0', releaseDate: '2022-12-30', Review Comment: Hi @ayush00git, this needs to be modified as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: added proper redirection to ingress-controller docs [apisix-website]
ayush00git commented on PR #1976: URL: https://github.com/apache/apisix-website/pull/1976#issuecomment-3663765777 Hey, @yzeng25 Thanks for the review! The main intent of this PR was to fix the 404 caused by `firstDocPath` pointing to `/getting-started`, which no longer exists for ingress-controller docs. Changing it to `/overview` resolves the broken link. Regarding the version and releaseDate: I noticed they are outdated, but I wasn’t sure if updating them should be part of this PR or handled separately. I’m happy to update them to the latest release (2.0.0) if that’s preferred. Please let me know how you’d like me to proceed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: added proper redirection to ingress-controller docs [apisix-website]
yzeng25 commented on code in PR #1976: URL: https://github.com/apache/apisix-website/pull/1976#discussion_r2625338690 ## config/downloads.js: ## @@ -27,7 +27,7 @@ module.exports = [ dockerhubPath: 'apisix-ingress-controller', version: '1.6.0', releaseDate: '2022-12-30', Review Comment: ditto ## config/docs.js: ## @@ -19,7 +19,7 @@ module.exports = [ githubRepo: 'apache/apisix-ingress-controller', version: '1.6.0', releaseDate: '2022-12-30', -firstDocPath: '/getting-started', Review Comment: Change in this line was previously made by @SkyeYoung in https://github.com/apache/apisix-website/commit/a9669fdfdf0f6bd7f2c022a24a99c13c6d621e6a , PTAL. ## config/docs.js: ## @@ -19,7 +19,7 @@ module.exports = [ githubRepo: 'apache/apisix-ingress-controller', version: '1.6.0', releaseDate: '2022-12-30', Review Comment: Should these 2 be updated as well? Loop @SkyeYoung @juzhiyuan @AlinsRan https://github.com/apache/apisix-ingress-controller/releases/tag/2.0.0 ```suggestion version: '2.0.0', releaseDate: '2025-12-17', ``` ## config/downloads.js: ## @@ -27,7 +27,7 @@ module.exports = [ dockerhubPath: 'apisix-ingress-controller', version: '1.6.0', releaseDate: '2022-12-30', -firstDocPath: '/getting-started', Review Comment: ditto PTAL @SkyeYoung -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: added proper redirection to ingress-controller docs [apisix-website]
ayush00git commented on PR #1976: URL: https://github.com/apache/apisix-website/pull/1976#issuecomment-3656434390 Hey @yzeng25 @Yilialinn can you review my PR, actually the site redirects to a wrong URL leading to a 404 error, i have made some changes to redirect it to the right URL and now it's working fine. Please give it a look and do guide me through the changes if something is left. Thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
