Re: [PR] fix: ai-proxy-multi health checker creation always fails in timer context due to missing _dns_value #13101 [apisix]
nic-6443 commented on PR #13136: URL: https://github.com/apache/apisix/pull/13136#issuecomment-4676905829 The ai-proxy-multi half of this PR is superseded on master: #13322 made `construct_upstream` fall back to `resolve_endpoint` when the runtime DNS field is nil, and #13441 reworked the whole DNS/health-check path (`_dns_value` is gone, replaced by the plural `_dns_nodes` model), so this diff no longer applies. The healthcheck_manager nil-check part is still worth having though — master still indexes the `construct_upstream` return value without a nil check (`healthcheck_manager.lua` lines 180 and 238), which can produce the per-second error loop when an instance is removed from the route while its checker is in the working pool. I'd suggest rebasing this down to just the healthcheck_manager hardening, plus a test if feasible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: ai-proxy-multi health checker creation always fails in timer context due to missing _dns_value #13101 [apisix]
guilongyang commented on PR #13136: URL: https://github.com/apache/apisix/pull/13136#issuecomment-4272567104 > Hi @guilongyang, I've further refined the relevant code I fixed two test cases -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: ai-proxy-multi health checker creation always fails in timer context due to missing _dns_value #13101 [apisix]
Baoyuantop commented on PR #13136: URL: https://github.com/apache/apisix/pull/13136#issuecomment-4241580855 Hi @guilongyang, I've further refined the relevant code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
