Re: [PR] fix: remove redundant route.Hosts to prevent false diffs in ADC sync [apisix-ingress-controller]
nic-6443 merged PR #2743: URL: https://github.com/apache/apisix-ingress-controller/pull/2743 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: remove redundant route.Hosts to prevent false diffs in ADC sync [apisix-ingress-controller]
nic-6443 commented on PR #2743: URL: https://github.com/apache/apisix-ingress-controller/pull/2743#issuecomment-4234321394 Pushed e2e test fix: replaced 2 direct HTTP assertions with `Eventually` retry in `test/e2e/crds/v2/route.go`. **Root cause**: In APISIX standalone mode, config application via `/apisix/admin/configs` is async (202 response). The Basic test and WebSocket test asserted HTTP status immediately after config push without retry, causing intermittent 404s when APISIX hadn't applied the new config yet. **Fix**: Use `Eventually` with 20s timeout + 1s polling (same pattern as other assertions in the test suite). The previous Benchmark test failure (APISIX 500 on ListServices) was an infrastructure issue — APISIX standalone failed to initialize. This should resolve on re-run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: remove redundant route.Hosts to prevent false diffs in ADC sync [apisix-ingress-controller]
nic-6443 commented on PR #2743: URL: https://github.com/apache/apisix-ingress-controller/pull/2743#issuecomment-4221475610 **CI Status update**: All APISIX E2E Tests ✅ (7/7 jobs passed), all conformance tests ✅, lint ✅, unit tests ✅, CodeQL ✅, license ✅. The only failure is `e2e-test (apisix-standalone)` in the **Benchmark Test** workflow — APISIX returns 500 Internal Server Error on `ListServices` during test scaffold setup. This is an infrastructure issue (APISIX standalone not properly initialized), unrelated to the route.Hosts removal in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: remove redundant route.Hosts to prevent false diffs in ADC sync [apisix-ingress-controller]
nic-6443 commented on PR #2743: URL: https://github.com/apache/apisix-ingress-controller/pull/2743#issuecomment-4221082054 Pushed CI fix: updated `main.js` → `main.cjs` in `apisix-e2e-test.yml` and `benchmark-test.yml` to match the updated `ghcr.io/api7/adc:dev` Docker image layout. The e2e tests should now pass the ADC binary extraction step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] fix: remove redundant route.Hosts to prevent false diffs in ADC sync [apisix-ingress-controller]
nic-6443 commented on PR #2743: URL: https://github.com/apache/apisix-ingress-controller/pull/2743#issuecomment-4219812342 **CI Status**: lint ✅, unit tests ✅, misspell ✅, CRD docs ✅, license check ✅ The e2e test failures are a **pre-existing infrastructure issue** — the ADC dev Docker image (`ghcr.io/api7/adc:dev`) no longer has `main.js` at the container root, causing the "Extract adc binary" step to fail with `Could not find the file main.js in container adc-temp`. This is unrelated to the changes in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
