Re: [PR] fix: update watch_ctx.revision to avoid multiple resyncs [apisix]

2025-03-12 Thread via GitHub


Revolyssup merged PR #12021:
URL: https://github.com/apache/apisix/pull/12021


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] fix: update watch_ctx.revision to avoid multiple resyncs [apisix]

2025-03-11 Thread via GitHub


Revolyssup commented on PR #12021:
URL: https://github.com/apache/apisix/pull/12021#issuecomment-2715326686

   > is it easy to add a test case for this case?
   
   not easy because it requires restarting etcd and deleting data which is 
outside the scope of test cases. I tried mocking etcd related functions and it 
got really complicated so I decided to halt the efforts in that direction. But 
this can be tested manually with reproduction steps.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org