Re: [PR] [Fix] improve metadata service protocol missing error message [dubbo-go]
sonarqubecloud[bot] commented on PR #3364: URL: https://github.com/apache/dubbo-go/pull/3364#issuecomment-4601341210 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3364) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3364&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3364&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3364&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3364&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3364&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3364) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
[PR] fix: improve metadata service protocol missing error message [dubbo-go]
wlgusqkr opened a new pull request, #3364: URL: https://github.com/apache/dubbo-go/pull/3364 ###Description Fixes #3359 (issue) Application-level service discovery fetches metadata through the metadata service URL. When that metadata service protocol is not registered, return an actionable error instead of panicking through MustGet. For dubbo metadata service URLs, the error now explains that the consumer needs to import dubbo.apache.org/dubbo-go/v3/protocol/dubbo. Add a metadata client test to verify the missing protocol path is handled without panic. ### Checklist - [x] I confirm the target branch is `develop` - [x] Code has passed local testing - [x] I have added tests that prove my fix is effective or that my feature works -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
