Re: [PR] [FEAT] delete synthesizer logic [dubbo-go]

2026-06-11 Thread via GitHub 


Alanxtl merged PR #3360:
URL: https://github.com/apache/dubbo-go/pull/3360


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [FEAT] delete synthesizer logic [dubbo-go]

2026-06-01 Thread via GitHub 


sonarqubecloud[bot] commented on PR #3360:
URL: https://github.com/apache/dubbo-go/pull/3360#issuecomment-4598288480

   ## [![Quality Gate 
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
 'Quality Gate 
Passed')](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3360) 
**Quality Gate passed**  
   Issues  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 New 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3360&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png
 '') [0 Accepted 
issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3360&issueStatuses=ACCEPTED)
   
   Measures  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3360&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Coverage on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3360&metric=new_coverage&view=list)
  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png
 '') [0.0% Duplication on New 
Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3360&metric=new_duplicated_lines_density&view=list)
  
 
   
   [See analysis details on SonarQube 
Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3360)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [FEAT] delete synthesizer logic [dubbo-go]

2026-06-01 Thread via GitHub 


Copilot commented on code in PR #3360:
URL: https://github.com/apache/dubbo-go/pull/3360#discussion_r3338059906


##
protocol/rest/config/reader/rest_config_reader.go:
##
@@ -38,11 +38,9 @@ import (
"dubbo.apache.org/dubbo-go/v3/protocol/rest/config"
 )
 
-const REST = "rest"
-
 func init() {
-   extension.SetConfigReaders(REST, NewRestConfigReader)
-   extension.SetDefaultConfigReader(REST, REST)
+   extension.SetConfigReaders(constant.RESTProtocol, NewRestConfigReader)
+   extension.SetDefaultConfigReader(constant.RESTProtocol, 
constant.RESTProtocol)
 }

Review Comment:
   PR description checklist says tests were added, but this change set only 
removes tests (e.g., rest_subscribed_urls_synthesizer_test.go) and does not add 
any new coverage. Please update the PR checklist/description to reflect the 
actual testing changes, or add appropriate tests if new behavior is intended.



##
cluster/router/chain/chain.go:
##
@@ -175,7 +175,7 @@ func NewRouterChain(url *common.URL) (*RouterChain, error) {
 
routerFactories := extension.GetRouterFactories()
if len(routerFactories) == 0 {
-   return nil, perrors.Errorf("No routerFactory exits , create one 
please")
+   return nil, perrors.Errorf("No routerFactory exits, create one 
please")

Review Comment:
   The error message still says "exits" (meaning "leaves") instead of "exists" 
(meaning "is present"). This looks like a typo and may confuse users when 
router factories are not registered.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] [FEAT] delete synthesizer logic [dubbo-go]

2026-06-01 Thread via GitHub 


codecov-commenter commented on PR #3360:
URL: https://github.com/apache/dubbo-go/pull/3360#issuecomment-4591820563

   ## 
[Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/3360?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :x: Patch coverage is `66.7%` with `1 line` in your changes missing 
coverage. Please review.
   :white_check_mark: Project coverage is 52.53%. Comparing base 
([`60d1c2a`](https://app.codecov.io/gh/apache/dubbo-go/commit/60d1c2a949f0ee0da4be3fe09fb79d295491e040?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`7bd9968`](https://app.codecov.io/gh/apache/dubbo-go/commit/7bd9968afd804b43a54b20ed2f4cf8880b296b52?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 814 commits behind head on develop.
   
   | [Files with missing 
lines](https://app.codecov.io/gh/apache/dubbo-go/pull/3360?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 | Patch % | Lines |
   |---|---|---|
   | 
[cluster/router/chain/chain.go](https://app.codecov.io/gh/apache/dubbo-go/pull/3360?src=pr&el=tree&filepath=cluster%2Frouter%2Fchain%2Fchain.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=)
 | 0.00% | [1 Missing :warning: 
](https://app.codecov.io/gh/apache/dubbo-go/pull/3360?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 |
   
   Additional details and impacted files
   
   
   
   ```diff
   @@ Coverage Diff @@
   ##   develop#3360  +/-   ##
   ===
   + Coverage46.76%   52.53%   +5.76% 
   ===
 Files  295  490 +195 
 Lines1717237844   +20672 
   ===
   + Hits  803119881   +11850 
   - Misses828716357+8070 
   - Partials   854 1606 +752 
   ```
   
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/dubbo-go/pull/3360?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:rocket: New features to boost your workflow: 
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]