Re: [PR] Fix CompositeInputStream close handling [dubbo]
RainYuY merged PR #16305: URL: https://github.com/apache/dubbo/pull/16305 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Fix CompositeInputStream close handling [dubbo]
codecov-commenter commented on PR #16305: URL: https://github.com/apache/dubbo/pull/16305#issuecomment-4599735568 ## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/16305?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 58.49%. Comparing base ([`b65573e`](https://app.codecov.io/gh/apache/dubbo/commit/b65573e5ca2ed81383fd2973e32cb3ed185a90a4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d60497c`](https://app.codecov.io/gh/apache/dubbo/commit/d60497c60c92181dc47524d54a2d6888cc533224?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: **Current head d60497c differs from pull request most recent head bbde4be** Please [upload](https://docs.codecov.com/docs/codecov-uploader) reports for the commit bbde4be to get more accurate results. Additional details and impacted files ```diff @@ Coverage Diff @@ ##3.3 #16305 +/- ## - Coverage 60.80% 58.49% -2.32% + Complexity11766 15 -11751 Files 1953 1953 Lines 8918889177 -11 Branches 1345413373 -81 - Hits 5423552166-2069 - Misses2939131282+1891 - Partials 5562 5729 +167 ``` | [Flag](https://app.codecov.io/gh/apache/dubbo/pull/16305/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [integration-tests-java21](https://app.codecov.io/gh/apache/dubbo/pull/16305/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [integration-tests-java8](https://app.codecov.io/gh/apache/dubbo/pull/16305/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [samples-tests-java21](https://app.codecov.io/gh/apache/dubbo/pull/16305/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [samples-tests-java8](https://app.codecov.io/gh/apache/dubbo/pull/16305/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unit-tests-java11](https://app.codecov.io/gh/apache/dubbo/pull/16305/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unit-tests-java17](https://app.codecov.io/gh/apache/dubbo/pull/16305/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unit-tests-java21](https://app.codecov.io/gh/apache/dubbo/pull/16305/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.49% <100.00%> (+<0.01%)` | :arrow_up: | | [unit-tests-java25](https://app.codecov.io/gh/apache/dubbo/pull/16305/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unit-tests-java8](https://app.codecov.io/gh/apache/dubbo/pull/16305/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo/pull/16305?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle
Re: [PR] Fix CompositeInputStream close handling [dubbo]
skt-shinyruo commented on PR #16305: URL: https://github.com/apache/dubbo/pull/16305#issuecomment-4599678658 Thanks for reviewing! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] Fix CompositeInputStream close handling [dubbo]
zrlw commented on PR #16305: URL: https://github.com/apache/dubbo/pull/16305#issuecomment-4599560700 Hope this one will be approved by 2+ committers, https://github.com/apache/dubbo/pull/16118 did the same thing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
