Re: [PR] test(triple): allow invalid stream send close errors [dubbo-go]
Copilot commented on code in PR #3379:
URL: https://github.com/apache/dubbo-go/pull/3379#discussion_r3384845174
##
protocol/triple/triple_protocol/triple_ext_test.go:
##
@@ -1681,7 +1681,10 @@ func TestStreamForServer(t *testing.T) {
assert.Nil(t, stream.Send(&pingv1.SumRequest{Number: 1}))
res := triple.NewResponse(&pingv1.SumResponse{})
err = stream.CloseAndReceive(res)
- assert.Nil(t, err)
+ if err != nil {
+ assert.Equal(t, triple.CodeUnknown, triple.CodeOf(err))
+ assert.True(t, strings.Contains(err.Error(), "write
envelope"))
Review Comment:
`assert.Equal` in this repo uses the signature `Equal(tb, got, want ...)`
(see internal/assert). Here the arguments are reversed, which makes failures
harder to read and is inconsistent with the surrounding tests (e.g., the next
subtest uses `assert.Equal(t, triple.CodeOf(err), triple.CodeUnknown)`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
-
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
Re: [PR] test(triple): allow invalid stream send close errors [dubbo-go]
AlexStocks merged PR #3379: URL: https://github.com/apache/dubbo-go/pull/3379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] test(triple): allow invalid stream send close errors [dubbo-go]
leno23 commented on PR #3379: URL: https://github.com/apache/dubbo-go/pull/3379#issuecomment-4655856903 I checked the failed Integration Test run. The failure is in the integration sample `generic`, where the Go client cannot connect to `127.0.0.1:50052` after the sample server startup (`connect: connection refused`, followed by `Some generic call tests failed`). This PR now only changes `protocol/triple/triple_protocol/triple_ext_test.go` and does not touch the generic sample, integration scripts, or runtime code. I tried to rerun the failed job, but GitHub requires repository admin permission for reruns from my account. Could a maintainer rerun the failed Integration Test job? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] test(triple): allow invalid stream send close errors [dubbo-go]
codecov-commenter commented on PR #3379: URL: https://github.com/apache/dubbo-go/pull/3379#issuecomment-4655837070 ## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/3379?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 52.53%. Comparing base ([`60d1c2a`](https://app.codecov.io/gh/apache/dubbo-go/commit/60d1c2a949f0ee0da4be3fe09fb79d295491e040?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7ef6b73`](https://app.codecov.io/gh/apache/dubbo-go/commit/7ef6b73d2ea4f96bf71c0ef0fc1eb4b9478ee17c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 821 commits behind head on develop. Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop#3379 +/- ## === + Coverage46.76% 52.53% +5.77% === Files 295 492 +197 Lines1717237873 +20701 === + Hits 803119898 +11867 - Misses828716370+8083 - Partials 854 1605 +751 ``` [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/dubbo-go/pull/3379?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :rocket: New features to boost your workflow: - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] test(triple): allow invalid stream send close errors [dubbo-go]
sonarqubecloud[bot] commented on PR #3379: URL: https://github.com/apache/dubbo-go/pull/3379#issuecomment-4655782249 ## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3379) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3379&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3379&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3379&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3379&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3379&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3379) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
Re: [PR] test(triple): allow invalid stream send close errors [dubbo-go]
leno23 commented on PR #3379: URL: https://github.com/apache/dubbo-go/pull/3379#issuecomment-4655775137 Updated this PR based on the review. It no longer changes Alt-Svc/HTTP3 negotiation. The diff is now limited to the failing stream test: after the server intentionally sends a non-proto message and that send fails, the client CloseAndReceive path may return the observed CodeUnknown write-envelope error instead of always completing nil. Local validation: go test ./protocol/triple/triple_protocol -run 'TestStreamForServer/client-stream-conn|TestAltSvcHandlerNegotiation|TestNewAltSvcHandler' and git diff --check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] - To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
