Re: [PR] IGNITE-25156 Make BinarySchemaRegistry package private [ignite]
sonarqubecloud[bot] commented on PR #12007: URL: https://github.com/apache/ignite/pull/12007#issuecomment-2821246333 ## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12007) **Quality Gate failed** Failed conditions  [4 New Code Smells](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12007) (required ≤ 1) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12007) ##  Catch issues before they fail your Quality Gate with our IDE extension  [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-25156 Make BinarySchemaRegistry package private [ignite]
nizhikov merged PR #12007: URL: https://github.com/apache/ignite/pull/12007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-25156 Make BinarySchemaRegistry package private [ignite]
maksaska commented on code in PR #12007:
URL: https://github.com/apache/ignite/pull/12007#discussion_r2050949668
##
modules/core/src/main/java/org/apache/ignite/internal/processors/platform/utils/PlatformUtils.java:
##
@@ -1114,27 +1113,9 @@ public static String getFullStackTrace(Throwable
throwable) {
public static int[] getSchema(CacheObjectBinaryProcessorImpl cacheObjProc,
int typeId, int schemaId) {
Review Comment:
Yes, moved to BinaryUtils
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] IGNITE-25156 Make BinarySchemaRegistry package private [ignite]
nizhikov commented on code in PR #12007:
URL: https://github.com/apache/ignite/pull/12007#discussion_r2047192510
##
modules/core/src/main/java/org/apache/ignite/internal/processors/platform/utils/PlatformUtils.java:
##
@@ -1114,27 +1113,9 @@ public static String getFullStackTrace(Throwable
throwable) {
public static int[] getSchema(CacheObjectBinaryProcessorImpl cacheObjProc,
int typeId, int schemaId) {
Review Comment:
Can we move `PlatformUtils#getSchema` to `BinaryUtils` or `BinaryContext`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] IGNITE-25156 Make BinarySchemaRegistry package private [ignite]
nizhikov commented on code in PR #12007:
URL: https://github.com/apache/ignite/pull/12007#discussion_r2047192510
##
modules/core/src/main/java/org/apache/ignite/internal/processors/platform/utils/PlatformUtils.java:
##
@@ -1114,27 +1113,9 @@ public static String getFullStackTrace(Throwable
throwable) {
public static int[] getSchema(CacheObjectBinaryProcessorImpl cacheObjProc,
int typeId, int schemaId) {
Review Comment:
Can we move `PlatformUtils#getSchema` to `BinaryUtils`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
[PR] IGNITE-25156 Make BinarySchemaRegistry package private [ignite]
maksaska opened a new pull request, #12007: URL: https://github.com/apache/ignite/pull/12007 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### The Contribution Checklist - [ ] There is a single JIRA ticket related to the pull request. - [ ] The web-link to the pull request is attached to the JIRA ticket. - [ ] The JIRA ticket has the _Patch Available_ state. - [ ] The pull request body describes changes that have been made. The description explains _WHAT_ and _WHY_ was made instead of _HOW_. - [ ] The pull request title is treated as the final commit message. The following pattern must be used: `IGNITE- Change summary` where `` - number of JIRA issue. - [ ] A reviewer has been mentioned through the JIRA comments (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) - [ ] The pull request has been checked by the Teamcity Bot and the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html)) ### Notes - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute) - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules) - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines) - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot) If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com _#ignite_ channel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
