Re: [PR] IGNITE-28643 Fixed website documentation publishing job [ignite]
NSAmelchev merged PR #13102: URL: https://github.com/apache/ignite/pull/13102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28643 Fixed website documentation publishing job [ignite]
sonarqubecloud[bot] commented on PR #13102: URL: https://github.com/apache/ignite/pull/13102#issuecomment-4377849848 ## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=13102) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=13102&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=13102&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=13102&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=13102&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=13102&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=13102) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28643 Fixed website documentation publishing job [ignite]
NSAmelchev commented on code in PR #13102:
URL: https://github.com/apache/ignite/pull/13102#discussion_r3187145947
##
.github/workflows/publish-website-on-branch-update.yml:
##
@@ -44,15 +44,20 @@ jobs:
- name: Check out 'ignite' repository code
uses: actions/checkout@v3
- - name: Check that the version was released
-run: |
- mvn org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M3:enforce
-Drules=requireReleaseDeps,requireReleaseVersion -pl modules/core
-
- name: Get the version from POM file
run: |
version=$(mvn help:evaluate -Dexpression=project.version -q
-DforceStdout)
echo "IGNITE_VERSION=$version" >> $GITHUB_ENV
+ - name: Check that the version was released
+run: |
+
URL="https://repo1.maven.org/maven2/org/apache/ignite/ignite-core/${IGNITE_VERSION}/ignite-core-${IGNITE_VERSION}.pom";
Review Comment:
Fixed to
[https://repo.maven.apache.org](https://repo.maven.apache.org/maven2/org/apache/ignite/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] IGNITE-28643 Fixed website documentation publishing job [ignite]
zstan commented on code in PR #13102:
URL: https://github.com/apache/ignite/pull/13102#discussion_r3187092788
##
.github/workflows/publish-website-on-branch-update.yml:
##
@@ -44,15 +44,20 @@ jobs:
- name: Check out 'ignite' repository code
uses: actions/checkout@v3
- - name: Check that the version was released
-run: |
- mvn org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M3:enforce
-Drules=requireReleaseDeps,requireReleaseVersion -pl modules/core
-
- name: Get the version from POM file
run: |
version=$(mvn help:evaluate -Dexpression=project.version -q
-DforceStdout)
echo "IGNITE_VERSION=$version" >> $GITHUB_ENV
+ - name: Check that the version was released
+run: |
+
URL="https://repo1.maven.org/maven2/org/apache/ignite/ignite-core/${IGNITE_VERSION}/ignite-core-${IGNITE_VERSION}.pom";
Review Comment:
just for clarification, why _repo1_and not _repo_ ?
https://repo.maven.apache.org/maven2/org/apache/ignite/
##
.github/workflows/publish-website-on-branch-update.yml:
##
@@ -44,15 +44,20 @@ jobs:
- name: Check out 'ignite' repository code
uses: actions/checkout@v3
- - name: Check that the version was released
-run: |
- mvn org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M3:enforce
-Drules=requireReleaseDeps,requireReleaseVersion -pl modules/core
-
- name: Get the version from POM file
run: |
version=$(mvn help:evaluate -Dexpression=project.version -q
-DforceStdout)
echo "IGNITE_VERSION=$version" >> $GITHUB_ENV
+ - name: Check that the version was released
+run: |
+
URL="https://repo1.maven.org/maven2/org/apache/ignite/ignite-core/${IGNITE_VERSION}/ignite-core-${IGNITE_VERSION}.pom";
Review Comment:
just for clarification, why _repo1_ and not _repo_ ?
https://repo.maven.apache.org/maven2/org/apache/ignite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] IGNITE-28643 Fixed website documentation publishing job [ignite]
sonarqubecloud[bot] commented on PR #13102: URL: https://github.com/apache/ignite/pull/13102#issuecomment-4377600924 ## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=13102) **Quality Gate passed** Issues  [0 New issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=13102&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=13102&issueStatuses=ACCEPTED) Measures  [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=13102&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=13102&metric=new_coverage&view=list)  [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=13102&metric=new_duplicated_lines_density&view=list) [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=13102) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] IGNITE-28643 Fixed website documentation publishing job [ignite]
NSAmelchev opened a new pull request, #13102: URL: https://github.com/apache/ignite/pull/13102 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### The Contribution Checklist - [ ] There is a single JIRA ticket related to the pull request. - [ ] The web-link to the pull request is attached to the JIRA ticket. - [ ] The JIRA ticket has the _Patch Available_ state. - [ ] The pull request body describes changes that have been made. The description explains _WHAT_ and _WHY_ was made instead of _HOW_. - [ ] The pull request title is treated as the final commit message. The following pattern must be used: `IGNITE- Change summary` where `` - number of JIRA issue. - [ ] A reviewer has been mentioned through the JIRA comments (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) - [ ] The pull request has been checked by the Teamcity Bot and the `green visa` attached to the JIRA ticket (see tab `PR Check` at [TC.Bot - Instance 1](https://tcbot2.sbt-ignite-dev.ru/prs.html) or [TC.Bot - Instance 2](https://mtcga.gridgain.com/prs.html)) ### Notes - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute) - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules) - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines) - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot) If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com _#ignite_ channel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
