Re: [PR] IGNITE-28651 Document Calcite SQL memory quotas in Ignite 2.x documentation [ignite]
dspavlov merged PR #13113: URL: https://github.com/apache/ignite/pull/13113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28651 Document Calcite SQL memory quotas in Ignite 2.x documentation [ignite]
ignitetcbot commented on code in PR #13113: URL: https://github.com/apache/ignite/pull/13113#discussion_r3201719576 ## docs/_docs/SQL/sql-calcite.adoc: ## @@ -121,6 +121,62 @@ QUERY_ENGINE=CALCITE -- +== Memory Quotas [[memory-quotas]] + +The Calcite-based SQL engine can track and limit heap memory accounted by Calcite query execution operators. +This is useful for protecting a server node from a single large query or from many concurrent memory-heavy queries. + +Two quotas can be configured in `CalciteQueryEngineConfiguration`: + +* `globalMemoryQuota` - a per-node heap memory quota for all Calcite SQL queries running on the node. +* `queryMemoryQuota` - a per-node heap memory quota for each Calcite SQL query running on the node. + +Both quotas are disabled by default (`0`). +The quota values are specified in bytes. +If a quota is exceeded, the query fails with an `IgniteSQLException`. Review Comment: fixed ## docs/_docs/SQL/sql-calcite.adoc: ## @@ -121,6 +121,62 @@ QUERY_ENGINE=CALCITE -- +== Memory Quotas [[memory-quotas]] + +The Calcite-based SQL engine can track and limit heap memory accounted by Calcite query execution operators. +This is useful for protecting a server node from a single large query or from many concurrent memory-heavy queries. + +Two quotas can be configured in `CalciteQueryEngineConfiguration`: Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] IGNITE-28651 Document Calcite SQL memory quotas in Ignite 2.x documentation [ignite]
alex-plekhanov commented on code in PR #13113: URL: https://github.com/apache/ignite/pull/13113#discussion_r3201629260 ## docs/_docs/SQL/sql-calcite.adoc: ## @@ -121,6 +121,62 @@ QUERY_ENGINE=CALCITE -- +== Memory Quotas [[memory-quotas]] + +The Calcite-based SQL engine can track and limit heap memory accounted by Calcite query execution operators. +This is useful for protecting a server node from a single large query or from many concurrent memory-heavy queries. + +Two quotas can be configured in `CalciteQueryEngineConfiguration`: + +* `globalMemoryQuota` - a per-node heap memory quota for all Calcite SQL queries running on the node. +* `queryMemoryQuota` - a per-node heap memory quota for each Calcite SQL query running on the node. + +Both quotas are disabled by default (`0`). +The quota values are specified in bytes. +If a quota is exceeded, the query fails with an `IgniteSQLException`. Review Comment: `with and exception` (`IgniteSQLException` is a private API exception, we've discovered it recently) ## docs/_docs/SQL/sql-calcite.adoc: ## @@ -121,6 +121,62 @@ QUERY_ENGINE=CALCITE -- +== Memory Quotas [[memory-quotas]] + +The Calcite-based SQL engine can track and limit heap memory accounted by Calcite query execution operators. +This is useful for protecting a server node from a single large query or from many concurrent memory-heavy queries. + +Two quotas can be configured in `CalciteQueryEngineConfiguration`: Review Comment: Two types? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] IGNITE-28651 Document Calcite SQL memory quotas in Ignite 2.x documentation [ignite]
ignitetcbot opened a new pull request, #13113: URL: https://github.com/apache/ignite/pull/13113 Thank you for submitting the pull request to the Apache Ignite. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### The Contribution Checklist - [ ] There is a single JIRA ticket related to the pull request. - [ ] The web-link to the pull request is attached to the JIRA ticket. - [ ] The JIRA ticket has the _Patch Available_ state. - [ ] The pull request body describes changes that have been made. The description explains _WHAT_ and _WHY_ was made instead of _HOW_. - [ ] The pull request title is treated as the final commit message. The following pattern must be used: `IGNITE- Change summary` where `` - number of JIRA issue. - [ ] A reviewer has been mentioned through the JIRA comments (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) - [ ] The pull request has been checked by the Teamcity Bot and the `green visa` attached to the JIRA ticket (see tab `PR Check` at [TC.Bot - Instance 1](https://tcbot2.sbt-ignite-dev.ru/prs.html) or [TC.Bot - Instance 2](https://mtcga.gridgain.com/prs.html)) ### Notes - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute) - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules) - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines) - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot) If you need any help, please email [email protected] or ask anу advice on http://asf.slack.com _#ignite_ channel. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
