Re: [PR] IGNITE-25076 Fix possible NullPointerException when FailureProcessor dumping a thread dump [ignite-3]

[via GitHub]

sk0x50 merged PR #5594:
URL: https://github.com/apache/ignite-3/pull/5594


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-25076 Fix possible NullPointerException when FailureProcessor dumping a thread dump [ignite-3]

[via GitHub]

sk0x50 commented on code in PR #5594:
URL: https://github.com/apache/ignite-3/pull/5594#discussion_r2035144720


##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##
@@ -764,7 +764,7 @@ String dumpDebugInfo() {
 
 private static String dumpThreads() {
 ThreadMXBean bean = ManagementFactory.getThreadMXBean();
-ThreadInfo[] infos = bean.dumpAllThreads(true, true);
+ThreadInfo[] infos = 
bean.dumpAllThreads(bean.isObjectMonitorUsageSupported(), 
bean.isSynchronizerUsageSupported());

Review Comment:
   Nice catch! Will fix it!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] IGNITE-25076 Fix possible NullPointerException when FailureProcessor dumping a thread dump [ignite-3]

[via GitHub]

rpuch commented on code in PR #5594:
URL: https://github.com/apache/ignite-3/pull/5594#discussion_r2035141822


##
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionServiceImpl.java:
##
@@ -764,7 +764,7 @@ String dumpDebugInfo() {
 
 private static String dumpThreads() {
 ThreadMXBean bean = ManagementFactory.getThreadMXBean();
-ThreadInfo[] infos = bean.dumpAllThreads(true, true);
+ThreadInfo[] infos = 
bean.dumpAllThreads(bean.isObjectMonitorUsageSupported(), 
bean.isSynchronizerUsageSupported());

Review Comment:
   Let's add the same null check in the loop that follows



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org