Re: [PR] IGNITE-25089 Improve javadoc and xmldoc for ColumnType [ignite-3]

2025-04-11 Thread via GitHub


ptupitsyn merged PR #5606:
URL: https://github.com/apache/ignite-3/pull/5606


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] IGNITE-25089 Improve javadoc and xmldoc for ColumnType [ignite-3]

2025-04-11 Thread via GitHub


Copilot commented on code in PR #5606:
URL: https://github.com/apache/ignite-3/pull/5606#discussion_r2039043279


##
modules/platforms/dotnet/Apache.Ignite/Sql/ColumnType.cs:
##
@@ -29,58 +31,128 @@ namespace Apache.Ignite.Sql
 [SuppressMessage("Design", "CA1027:Mark enums with FlagsAttribute", 
Justification = "Not a flags enum.")]
 public enum ColumnType
 {
-/** Null. */
+/// 
+/// Null.
+/// 
 Null = 0,
 
-/** Boolean. */
+/// 
+/// Boolean.
+/// 
+/// SQL type: BOOLEAN, .NET type: .
+/// 
 Boolean = 1,
 
-/** 8-bit signed integer. */
+/// 
+/// 8-bit signed integer.
+/// 
+/// SQL type: TINYINT, .NET type: .
+/// 
 Int8 = 2,
 
-/** 16-bit signed integer. */
+/// 
+/// 16-bit signed integer.
+/// 
+/// SQL type: SMALLINT, .NET type: .
+/// 
 Int16 = 3,
 
-/** 32-bit signed integer. */
+/// 
+/// 32-bit signed integer.
+/// 
+/// SQL type: INTEGER, .NET type: .
+/// 
 Int32 = 4,
 
-/** 64-bit signed integer. */
+/// 
+/// 64-bit signed integer.
+/// 
+/// SQL type: BIGINT, .NET type: .
+/// 
 Int64 = 5,
 
-/** 32-bit single-precision floating-point number. */
+/// 
+/// 32-bit single-precision floating-point number.
+/// 
+/// SQL type: REAL, .NET type: .
+/// 
 Float = 6,
 
-/** 64-bit double-precision floating-point number. */
+/// 
+/// 64-bit single-precision floating-point number.

Review Comment:
   The description for the 'Double' enum incorrectly states 'single-precision'; 
it should be '64-bit double-precision floating-point number.'
   ```suggestion
   /// 64-bit double-precision floating-point number.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org