Re: [PR] IGNITE-25950 Code-generated serializer for GridCacheEntryInfo message [ignite]

2025-07-18 Thread via GitHub 


timoninmaxim merged PR #12198:
URL: https://github.com/apache/ignite/pull/12198


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] IGNITE-25950 Code-generated serializer for GridCacheEntryInfo message [ignite]

2025-07-18 Thread via GitHub 


sonarqubecloud[bot] commented on PR #12198:
URL: https://github.com/apache/ignite/pull/12198#issuecomment-3090549610

   ## [![Quality Gate 
Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png
 'Quality Gate 
Failed')](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12198) 
**Quality Gate failed**  
   Failed conditions  
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png
 '') [3 New Code 
Smells](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12198) 
(required ≤ 1)  
 
   [See analysis details on SonarQube 
Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=12198)
   
   ##   
   
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png
 '') Catch issues before they fail your Quality Gate with our IDE extension 
![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png
 '') [SonarQube for 
IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] IGNITE-25950 Code-generated serializer for GridCacheEntryInfo message [ignite]

2025-07-18 Thread via GitHub 


timoninmaxim commented on code in PR #12198:
URL: https://github.com/apache/ignite/pull/12198#discussion_r2215710847


##
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheEntryInfo.java:
##
@@ -98,10 +99,10 @@ public CacheObject value() {
 }
 
 /**
- * @param val Entry value.

Review Comment:
   Useless change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Re: [PR] IGNITE-25950 Code-generated serializer for GridCacheEntryInfo message [ignite]

2025-07-18 Thread via GitHub 


timoninmaxim commented on code in PR #12198:
URL: https://github.com/apache/ignite/pull/12198#discussion_r2215387124


##
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheEntryInfo.java:
##
@@ -17,16 +17,13 @@
 
 package org.apache.ignite.internal.processors.cache;
 
-import java.nio.ByteBuffer;
 import org.apache.ignite.IgniteCheckedException;
-import org.apache.ignite.internal.GridDirectTransient;

Review Comment:
   Let's make GridDirectTransient deprecated.



##
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCacheEntryInfo.java:
##
@@ -36,30 +33,34 @@ public class GridCacheEntryInfo implements Message {
 private static final int SIZE_OVERHEAD = 3 * 8 /* reference */ + 4 /* int 
*/ + 2 * 8 /* long */ + 32 /* version */;
 
 /** Cache key. */
+@Order(0)
 @GridToStringInclude
 private KeyCacheObject key;
 
 /** Cache ID. */
+@Order(1)
 private int cacheId;
 
 /** Cache value. */
-private CacheObject val;
+@Order(2)
+private CacheObject value;
 
 /** Time to live. */
+@Order(3)
 private long ttl;
 
 /** Expiration time. */
+@Order(4)
 private long expireTime;
 
 /** Entry version. */
-private GridCacheVersion ver;
+@Order(5)
+private GridCacheVersion version;

Review Comment:
   Let's try add method name to `@Order` for generation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]