On Fri, 20 Jan 2012 12:04:49 -0500, Jesse Rosenthal
wrote:
[ ... ]
> Thus: tach.el. Tach is a minor mode that adds mutt-like attachment
> handling to message mode. It's not notmuch specific, but I wrote it to
> use with notmuch, and I thought it might be of use to some on the
> list.
I like it
27;, '']
~~
So afew pass a query with 'tag:""' and it don't match any message. What
about putting a strip(';') before the split()?
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120120/27a65c9e/attachment.pgp>
Hi Xavier,
On Fri, 20 Jan 2012 23:43:01 +0100, Xavier Maillard
wrote:
> I like it.
Thanks for giving it a try.
> Simple but at first it is not easy to understand what to do with that
> window. Also, there is no way to toggle the window visibility. But for a
> first shot, it is a good shot :D
Later runs of "notmuch new" won't scan these files again and won't
print warnings.
Various programs (Dovecot, in my case) store indexes and caches and
such in the maildir. Without this, notmuch persistently complains
about such files.
---
Every time I run notmuch new I get a slew of these warning
On Thu, 19 Jan 2012 09:34:07 +, David Edmondson wrote:
> The `mm-inlinable-p' function works better if it has access to the
> data of the relevant part, so load that content before calling it.
>
> Don't load the content for parts that the user has indicated no desire
> to inline.
>
> This fi
Quoting Kazuo Teramoto (2012-01-20 22:55:08)
>On Fri, Jan 20, 2012 at 12:26:05PM +0100, Justus Winter wrote:
>> Quoting Patrick Totzke (2012-01-20 11:40:41)
>> >I suspect you don't split the config value and thus afew ended up
>> >with a false tag "new;". its just cosmetics but nevertheless..
>>
>
On Thu, 19 Jan 2012 17:29:19 -0500, Austin Clements wrote:
> This ignores the results of the two writes in sigint handlers even
> harder than before.
>
> While my libc lacks the declarations that trigger these warnings, this
> can be tested by adding the following to notmuch.h:
>
> __attribute__
On Thu, 19 Jan 2012 17:29:18 -0500, Austin Clements wrote:
> For showing a message in raw format, rather than silently succeeding
> when a read or a write fails (or, probably, looping if a read fails),
> try to print an error message and exit with a non-zero status.
>
> This silences one of the b
On Wed, 18 Jan 2012 15:28:26 -0500, Austin Clements wrote:
> Previously, top-level message headers were printed as Subject, From,
> To, Date, while embedded message headers were printed From, To,
> Subject, Date. This makes both cases use the former order and updates
> the tests accordingly.
>
>
On Fri, 20 Jan 2012 00:52:47 +0100, Thomas Jost
wrote:
>
> Here is how I did:
>
> (ldd notmuch | grep -q gmime-2.6) && test_subtest_known_broken
>
> ldd notmuch will show "/path/to/libgmime-2.4.so.*" or
> "libgmime-2.6.so.*" so we can easily check this in the test suite.
> It's a little hack
Hi Xavier,
On Fri, 20 Jan 2012 23:43:01 +0100, Xavier Maillard wrote:
> I like it.
Thanks for giving it a try.
> Simple but at first it is not easy to understand what to do with that
> window. Also, there is no way to toggle the window visibility. But for a
> first shot, it is a good shot :D
T
On Fri, 20 Jan 2012 10:39:24 +0100, Thomas Jost wrote:
> There are lots of API changes in gmime 2.6 crypto handling. By adding
> preprocessor directives, it is however possible to add gmime 2.6 compatibility
> while preserving compatibility with gmime 2.4 too.
>
> This is mostly based on id:"8762
On Fri, 20 Jan 2012 12:04:49 -0500, Jesse Rosenthal wrote:
[ ... ]
> Thus: tach.el. Tach is a minor mode that adds mutt-like attachment
> handling to message mode. It's not notmuch specific, but I wrote it to
> use with notmuch, and I thought it might be of use to some on the
> list.
I like it.
On Fri, 20 Jan 2012 10:22:09 -0700, Adam Wolfe Gordon
wrote:
> Erk, forgot to reply-all. Aaron might get this twice.
Pick this: notmuch@notmuchmail.org (and add to to/cc) next time you forgot
to press 'R' (that's what I do :)
>
> On Thu, Jan 19, 2012 at 22:53, Aaron Ecay wrote:
>
> > One p
Later runs of "notmuch new" won't scan these files again and won't
print warnings.
Various programs (Dovecot, in my case) store indexes and caches and
such in the maildir. Without this, notmuch persistently complains
about such files.
---
Every time I run notmuch new I get a slew of these warning
On Fri, Jan 20, 2012 at 12:26:05PM +0100, Justus Winter wrote:
> Quoting Patrick Totzke (2012-01-20 11:40:41)
> >I suspect you don't split the config value and thus afew ended up
> >with a false tag "new;". its just cosmetics but nevertheless..
>
> Hm, actually it does exactly that:
>
> def get_n
ustin Clements in
id:"20120117034714.GG16740 at mit.edu", so he deserves the credits :))
Regards,
--
Thomas/Schnouki
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120120/80917bba/attachment.pgp>
On Fri, 20 Jan 2012 00:52:14 +0100, Pieter Praet wrote:
> From: Dmitry Kurochkin
>
> This makes `show-trailing-whitespace' happy, i.e. it does not mark the
> whole search box line as trailing spaces.
>
> Since the dot is invisible, this change makes no visible difference
> for `notmuch-hello'.
On Thu, 19 Jan 2012 15:31:02 -0500, Jesse Rosenthal
wrote:
> Hi Tomi,
>
> On Thu, 19 Jan 2012 19:50:38 +0200, Tomi Ollila wrote:
> > Quick comments: "/tmp/notmuch_dtach.socket" is dangerous (and the _ssh).
> >
> > either
> > make directory /tmp/notmuch_`id -u`
> > and chmod it
Ha! As I was recently looking at the MML stuff, I spent some time
googling around looking for this ? I knew I had seen a ?mutt-like?
attachment interface for emacs mail writing, but I couldn?t seem to come
across it. I will definitely get it set up and play with it. I don?t
have cause to attach
On Fri, 20 Jan 2012 09:43:31 +, David Edmondson wrote:
> The buttons inserted for encrypted parts are slightly different now -
> previously the logic was that if a part was encrypted it would have
> the signature status inserted only if the encryption status was
> specified. Now the signature
---
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120120/13bbc2fc/attachment.pgp>
Quoth Mark Walters on Jan 20 at 12:10 am:
>
> Ok Having said this is trivial I have found a problem. What should
> notmuch do if you do something like
>
> notmuch show id:
> and that message is marked with a deleted tag? To be consistent with the
> other cases (where a deleted message is in a mat
On Wed, 18 Jan 2012 04:08:54 -0600, Pieter Praet wrote:
> On Mon, 16 Jan 2012 16:43:06 -0500, Aaron Ecay wrote:
> > On Mon, 16 Jan 2012 17:57:33 +0100, Pieter Praet
> > wrote:
> > [...] Maybe you could change the regex that
> > matches id:?s to require a little more structure ? an at-sign, perh
On Wed, 18 Jan 2012 14:35:01 -0500, Austin Clements wrote:
> Shouldn't we only be doing this for parts with inline (or not
> attachment) content-disposition? That's cheap to check. Or do we
> actually want things like image attachments to get inlined, despite
> their disposition?
This is a good
available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120120/0b975c05/attachment.pgp>
On Tue, 17 Jan 2012 16:29:23 -0600, Austin Clements wrote:
> Quoth Andrei Popescu on Jan 18 at 12:14 am:
> > On Lu, 16 ian 12, 21:34:31, Austin Clements wrote:
> > > Quoth Andrei Popescu on Jan 16 at 10:21 pm:
> > > > Where can I read more about this? (except the source :)
> > >
> > > Most of thi
for some users, as notmuch's
popularity continues to grow.
Best,
Jesse
-- next part --
A non-text attachment was scrubbed...
Name: tach.el
Type: application/emacs-lisp
Size: 9481 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120120/62056761/attachment-0001.bin>
On Thu, 19 Jan 2012 09:34:07 +, David Edmondson wrote:
> The `mm-inlinable-p' function works better if it has access to the
> data of the relevant part, so load that content before calling it.
>
> Don't load the content for parts that the user has indicated no desire
> to inline.
So I'm a li
But I'm assuming there is some
variable I need to set that I haven't...
jamie.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120120/6d8fea84/attachment.pgp>
LGTM
Quoth Mark Walters on Jan 20 at 9:44 am:
> Define a keymap for attachment buttons to allow multiple actions.
> Define 3 possible actions:
> save attachment: exactly as currently,
> view attachment: uses mailcap entry,
> view attachment with user chosen program
>
> Keymap on a bu
Quoth Thomas Jost on Jan 20 at 10:39 am:
> ---
> INSTALL | 12 ++--
> NEWS|9 +
> 2 files changed, 15 insertions(+), 6 deletions(-)
>
> diff --git a/INSTALL b/INSTALL
> index e51b397..bc98f1d 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -20,8 +20,8 @@ configure stage.
>
LGTM!
Quoth Thomas Jost on Jan 20 at 10:39 am:
> There are lots of API changes in gmime 2.6 crypto handling. By adding
> preprocessor directives, it is however possible to add gmime 2.6 compatibility
> while preserving compatibility with gmime 2.4 too.
>
> This is mostly based on id:"8762i8hrb9.f
Quoting Patrick Totzke (2012-01-20 11:40:41)
>Quoting Justus Winter (2011-12-21 08:53:23)
>>Hey Pazz,
>>
>>Quoting Patrick Totzke (2011-12-19 19:17:12)
>>>Also, should i not get some output when calling afew with -vv ?
>>
>>Yes you should ;). Here's an example run on my box:
>Alright, I do get logg
On Wed, 18 Jan 2012 04:08:54 -0600, Pieter Praet wrote:
> On Mon, 16 Jan 2012 16:43:06 -0500, Aaron Ecay wrote:
> > On Mon, 16 Jan 2012 17:57:33 +0100, Pieter Praet wrote:
> > [...] Maybe you could change the regex that
> > matches id:’s to require a little more structure – an at-sign, perhaps.
On Tue, 17 Jan 2012 16:29:23 -0600, Austin Clements wrote:
> Quoth Andrei Popescu on Jan 18 at 12:14 am:
> > On Lu, 16 ian 12, 21:34:31, Austin Clements wrote:
> > > Quoth Andrei Popescu on Jan 16 at 10:21 pm:
> > > > Where can I read more about this? (except the source :)
> > >
> > > Most of thi
Quoting Justus Winter (2011-12-21 08:53:23)
>Hey Pazz,
>
>Quoting Patrick Totzke (2011-12-19 19:17:12)
>>Also, should i not get some output when calling afew with -vv ?
>
>Yes you should ;). Here's an example run on my box:
Alright, I do get logging output with upstream master thanks.
FYI: I found
---
INSTALL | 12 ++--
NEWS|9 +
2 files changed, 15 insertions(+), 6 deletions(-)
diff --git a/INSTALL b/INSTALL
index e51b397..bc98f1d 100644
--- a/INSTALL
+++ b/INSTALL
@@ -20,8 +20,8 @@ configure stage.
Dependencies
-Notmuch depends on three libraries
There are lots of API changes in gmime 2.6 crypto handling. By adding
preprocessor directives, it is however possible to add gmime 2.6 compatibility
while preserving compatibility with gmime 2.4 too.
This is mostly based on id:"8762i8hrb9.fsf at bookbinder.fernseed.info".
This was tested against
JSON does not support hex literals (0x..) so numbers must be formatted as %d
instead of %x.
---
notmuch-show.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/notmuch-show.c b/notmuch-show.c
index d14dac9..91f566c 100644
--- a/notmuch-show.c
+++ b/notmuch-show.c
@@ -641,7
quot;) == 0)) {
> > if (params.cryptoctx == NULL) {
> > +#ifdef GMIME_ATLEAST_26
> > + /* TODO: GMimePasswordRequestFunc */
> > + if (NULL == (params.cryptoctx = g_mime_gpg_context_new(NULL,
> > "gpg")))
> > +#else
> > GMimeSession* session = g_object_new(g_mime_session_get_type(),
> > NULL);
> > if (NULL == (params.cryptoctx = g_mime_gpg_context_new(session,
> > "gpg")))
> > +#endif
> > fprintf (stderr, "Failed to construct gpg context.\n");
> > else
> >
> > g_mime_gpg_context_set_always_trust((GMimeGpgContext*)params.cryptoctx,
> > FALSE);
> > +#ifndef GMIME_ATLEAST_26
> > g_object_unref (session);
> > session = NULL;
> > +#endif
> > }
> > if (STRNCMP_LITERAL (argv[i], "--decrypt") == 0)
> > params.decrypt = 1;
> > diff --git a/show-message.c b/show-message.c
> > index 8768889..83ecf81 100644
> > --- a/show-message.c
> > +++ b/show-message.c
> > @@ -48,7 +48,11 @@ show_message_part (mime_node_t *node,
> > format->part_encstatus (node->decrypt_success);
> >
> > if (node->verify_attempted && format->part_sigstatus)
> > +#ifdef GMIME_ATLEAST_26
> > + format->part_sigstatus (node->sig_list);
> > +#else
> > format->part_sigstatus (node->sig_validity);
> > +#endif
> >
> > format->part_content (part);
> >
> > diff --git a/test/crypto b/test/crypto
> > index 0af4aa8..3779abc 100755
> > --- a/test/crypto
> > +++ b/test/crypto
> > @@ -104,6 +104,8 @@ test_expect_equal \
> > "$expected"
> >
> > test_begin_subtest "signature verification with signer key unavailable"
> > +# this is broken with current versions of gmime-2.6
> > +(ldd $(which notmuch) | grep -q gmime-2.6) && test_subtest_known_broken
>
> Just to be nitpicky, you should either escape the . in the regexp or
> pass -F to grep. Otherwise I think this hack is fine (though it might
> have to get a little fancier once GMime fixes this bug).
Added -F :)
I guess we could also use pkg-config to test if gmime 2.6 is present. It
would also be simpler to test the version number once gmime fixes this
bug:
pkg-config --atleast-version=2.6.x gmime-2.6 || test_subtest_known_broken
But this would mean assuming that notmuch is built against a system-wide
gmime. Or it would require setting PKG_CONFIG_PATH before tests...
Complicated.
So IMHO once gmime fixes this bug we should just remove the
test_subtest_known_broken and maybe add something like this in
notmuch-client.h:
#ifdef GMIME_MAJOR_VERSION
#define GMIME_ATLEAST_26
#if !GMIME_CHECK_VERSION(2, 6, x)
#warning "Building against an old and buggy version of gmime. Please update
to 2.6.x."
#endif
#endif
>
> > # move the gnupghome temporarily out of the way
> > mv "${GNUPGHOME}"{,.bak}
> > output=$(notmuch show --format=json --verify subject:"test signed message
> > 001" \
--
Thomas/Schnouki
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120120/ae25838f/attachment.pgp>
On Fri, 20 Jan 2012 00:50:49 +0100, Pieter Praet wrote:
> On Fri, 20 Jan 2012 02:37:30 +0400, Dmitry Kurochkin gmail.com> wrote:
> > On Thu, 19 Jan 2012 22:31:14 +0100, Pieter Praet
> > wrote:
> > > Not meant to be applied!
> > >
> > > Should be merged into
> > > id:"1326815734-20421-1-git-s
Erk, forgot to reply-all. Aaron might get this twice.
On Thu, Jan 19, 2012 at 22:53, Aaron Ecay wrote:
> (let ((message-citation-line-format
> (remove ?\n message-citation-line-format)))
> ...)
>
> (Or, if you think someone might have a newline other than at the end of
> the string, you c
Define a keymap for attachment buttons to allow multiple actions.
Define 3 possible actions:
save attachment: exactly as currently,
view attachment: uses mailcap entry,
view attachment with user chosen program
Keymap on a button is: s for save, v for view and o for view with
other prog
Add a regexp, `notmuch-show-part-headers-hidden' and if the
content-type of a part matches, don't show the part header.
---
emacs/notmuch-show.el | 41 +++--
1 files changed, 27 insertions(+), 14 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch
Instead, allow the caller to specify some parameters for the
button. Rework `notmuch-show-insert-part-multipart/signed' and
`notmuch-show-insert-part-multipart/encrypted' accordingly, moving
most of the code into a common
`notmuch-show-insert-part-multipart/signed-or-encrypted' to reduce
duplicatio
---
emacs/notmuch-show.el | 26 --
1 files changed, 12 insertions(+), 14 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 03c1f6b..f62f8ac 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -286,20 +286,18 @@ message at DEPTH i
On Thu, 19 Jan 2012 23:30:23 -0500, Austin Clements wrote:
> One indentation nit and then this LGTM.
>
> > + (lexical-let ((message-id message-id)
> > + (nth nth)
> > + (filename filename)
> > + (content-type content-type))
> > + (flet
Erk, forgot to reply-all. Aaron might get this twice.
On Thu, Jan 19, 2012 at 22:53, Aaron Ecay wrote:
> (let ((message-citation-line-format
> (remove ?\n message-citation-line-format)))
> ...)
>
> (Or, if you think someone might have a newline other than at the end of
> the string, you c
Ha! As I was recently looking at the MML stuff, I spent some time
googling around looking for this – I knew I had seen a “mutt-like”
attachment interface for emacs mail writing, but I couldn’t seem to come
across it. I will definitely get it set up and play with it. I don’t
have cause to attach
On Fri, 20 Jan 2012 13:33:58 +0100, Thomas Jost
wrote:
> The most common gmime error codes are 1 (expired signature), 2 (no
> public key), 4 (expired key) and 8 (revoked key). The other possible
> value is 16 (unsupported algorithm) but obviously it is much more rare.
> If this happens, the curr
Quoth Mark Walters on Jan 20 at 12:10 am:
>
> Ok Having said this is trivial I have found a problem. What should
> notmuch do if you do something like
>
> notmuch show id:
> and that message is marked with a deleted tag? To be consistent with the
> other cases (where a deleted message is in a mat
.
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120120/fa81dd67/attachment.pgp>
Dear All,
I sent this to the list a couple of years back, but now that things are
moving again, and there are new eyes on the list, I thought I'd send it
again. I believe I'm the only person to use this (and might well
continue to be so) but I've been using it for a couple of years without
any pro
LGTM
Quoth Mark Walters on Jan 20 at 9:44 am:
> Define a keymap for attachment buttons to allow multiple actions.
> Define 3 possible actions:
> save attachment: exactly as currently,
> view attachment: uses mailcap entry,
> view attachment with user chosen program
>
> Keymap on a bu
Quoth Thomas Jost on Jan 20 at 10:39 am:
> ---
> INSTALL | 12 ++--
> NEWS|9 +
> 2 files changed, 15 insertions(+), 6 deletions(-)
>
> diff --git a/INSTALL b/INSTALL
> index e51b397..bc98f1d 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -20,8 +20,8 @@ configure stage.
>
LGTM!
Quoth Thomas Jost on Jan 20 at 10:39 am:
> There are lots of API changes in gmime 2.6 crypto handling. By adding
> preprocessor directives, it is however possible to add gmime 2.6 compatibility
> while preserving compatibility with gmime 2.4 too.
>
> This is mostly based on id:"8762i8hrb9..
On Thu, 19 Jan 2012 13:43:09 -0500, Aaron Ecay wrote:
> Emacs message-mode uses certain text strings to indicate how to attach
> files to outgoing mail. If these are present in the text of an email,
> and a user is tricked into replying to the message, the user?s files
> could be exposed.
> ---
On Fri, 20 Jan 2012 10:39:23 +0100, Thomas Jost
wrote:
> JSON does not support hex literals (0x..) so numbers must be formatted as %d
> instead of %x.
> ---
> notmuch-show.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Probably I'm just being lazy here, but can you explain why
ave a comment
explaining why `mml-quote-region' is required.
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120120/d71be9b8/attachment.pgp>
On Wed, 18 Jan 2012 15:56:45 -0500, Austin Clements wrote:
> Since "auto_exclude_tags" is long and its description is multi-line,
> start the description on the next line and indent it consistently.
> ---
pushed
d
On Thu, 19 Jan 2012 09:34:07 +, David Edmondson wrote:
> The `mm-inlinable-p' function works better if it has access to the
> data of the relevant part, so load that content before calling it.
>
> Don't load the content for parts that the user has indicated no desire
> to inline.
>
> This fi
On Thu, 19 Jan 2012 17:29:19 -0500, Austin Clements wrote:
> This ignores the results of the two writes in sigint handlers even
> harder than before.
>
> While my libc lacks the declarations that trigger these warnings, this
> can be tested by adding the following to notmuch.h:
>
> __attribute__
On Thu, 19 Jan 2012 17:29:18 -0500, Austin Clements wrote:
> For showing a message in raw format, rather than silently succeeding
> when a read or a write fails (or, probably, looping if a read fails),
> try to print an error message and exit with a non-zero status.
>
> This silences one of the b
On Wed, 18 Jan 2012 15:28:26 -0500, Austin Clements wrote:
> Previously, top-level message headers were printed as Subject, From,
> To, Date, while embedded message headers were printed From, To,
> Subject, Date. This makes both cases use the former order and updates
> the tests accordingly.
>
>
On Fri, 20 Jan 2012 00:52:47 +0100, Thomas Jost wrote:
>
> Here is how I did:
>
> (ldd notmuch | grep -q gmime-2.6) && test_subtest_known_broken
>
> ldd notmuch will show "/path/to/libgmime-2.4.so.*" or
> "libgmime-2.6.so.*" so we can easily check this in the test suite.
> It's a little hacky
On Fri, 20 Jan 2012 13:33:58 +0100, Thomas Jost wrote:
> The most common gmime error codes are 1 (expired signature), 2 (no
> public key), 4 (expired key) and 8 (revoked key). The other possible
> value is 16 (unsupported algorithm) but obviously it is much more rare.
> If this happens, the curre
On Fri, 20 Jan 2012 07:55:03 -0400, David Bremner wrote:
> On Fri, 20 Jan 2012 10:39:23 +0100, Thomas Jost wrote:
> > JSON does not support hex literals (0x..) so numbers must be formatted as %d
> > instead of %x.
> > ---
> > notmuch-show.c |2 +-
> > 1 files changed, 1 insertions(+), 1 dele
On Thu, 19 Jan 2012 13:43:09 -0500, Aaron Ecay wrote:
> Emacs message-mode uses certain text strings to indicate how to attach
> files to outgoing mail. If these are present in the text of an email,
> and a user is tricked into replying to the message, the user’s files
> could be exposed.
> ---
On Fri, 20 Jan 2012 10:39:23 +0100, Thomas Jost wrote:
> JSON does not support hex literals (0x..) so numbers must be formatted as %d
> instead of %x.
> ---
> notmuch-show.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Probably I'm just being lazy here, but can you explain why
Quoting Patrick Totzke (2012-01-20 11:40:41)
>Quoting Justus Winter (2011-12-21 08:53:23)
>>Hey Pazz,
>>
>>Quoting Patrick Totzke (2011-12-19 19:17:12)
>>>Also, should i not get some output when calling afew with -vv ?
>>
>>Yes you should ;). Here's an example run on my box:
>Alright, I do get logg
On Fri, 20 Jan 2012 00:52:14 +0100, Pieter Praet wrote:
> From: Dmitry Kurochkin
>
> This makes `show-trailing-whitespace' happy, i.e. it does not mark the
> whole search box line as trailing spaces.
>
> Since the dot is invisible, this change makes no visible difference
> for `notmuch-hello'.
On Wed, 18 Jan 2012 15:56:45 -0500, Austin Clements wrote:
> Since "auto_exclude_tags" is long and its description is multi-line,
> start the description on the next line and indent it consistently.
> ---
pushed
d
___
notmuch mailing list
notmuch@notmu
On Thu, 19 Jan 2012 15:31:02 -0500, Jesse Rosenthal wrote:
> Hi Tomi,
>
> On Thu, 19 Jan 2012 19:50:38 +0200, Tomi Ollila wrote:
> > Quick comments: "/tmp/notmuch_dtach.socket" is dangerous (and the _ssh).
> >
> > either
> > make directory /tmp/notmuch_`id -u`
> > and chmod it t
Quoting Justus Winter (2011-12-21 08:53:23)
>Hey Pazz,
>
>Quoting Patrick Totzke (2011-12-19 19:17:12)
>>Also, should i not get some output when calling afew with -vv ?
>
>Yes you should ;). Here's an example run on my box:
Alright, I do get logging output with upstream master thanks.
FYI: I found
On Thu, 19 Jan 2012 22:31:14 +0100, Pieter Praet wrote:
> Not meant to be applied!
>
> Should be merged into
> id:"1326815734-20421-1-git-send-email-dmitry.kurochkin at gmail.com"
>
Oops. I managed to miss the failing tests. I would send a new patch
version.
Regards,
Dmitry
> ---
> tes
Instead, allow the caller to specify some parameters for the
button. Rework `notmuch-show-insert-part-multipart/signed' and
`notmuch-show-insert-part-multipart/encrypted' accordingly, moving
most of the code into a common
`notmuch-show-insert-part-multipart/signed-or-encrypted' to reduce
duplicatio
---
emacs/notmuch-show.el | 26 --
1 files changed, 12 insertions(+), 14 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
index 03c1f6b..f62f8ac 100644
--- a/emacs/notmuch-show.el
+++ b/emacs/notmuch-show.el
@@ -286,20 +286,18 @@ message at DEPTH i
On Thu, 19 Jan 2012 13:43:09 -0500, Aaron Ecay wrote:
> - (message-goto-body))
> + (message-goto-body)
> + (mml-quote-region (point) (mark)))
Obviously good. It would be nice to have a comment about why it's `mark'
and not `point-max'. In fact, it would be good to have a comment
explaining why
Add a regexp, `notmuch-show-part-headers-hidden' and if the
content-type of a part matches, don't show the part header.
---
emacs/notmuch-show.el | 41 +++--
1 files changed, 27 insertions(+), 14 deletions(-)
diff --git a/emacs/notmuch-show.el b/emacs/notmuch
On Fri, 20 Jan 2012 00:53:39 -0500, Aaron Ecay wrote:
> I’m personally of the opinion that notmuch should just say “the mail
> composition facility is provided by message mode (here is the
> documentation on customizing it)”.
In general, +1.
> One possible step that might ease the transition pai
Define a keymap for attachment buttons to allow multiple actions.
Define 3 possible actions:
save attachment: exactly as currently,
view attachment: uses mailcap entry,
view attachment with user chosen program
Keymap on a button is: s for save, v for view and o for view with
other prog
On Thu, 19 Jan 2012 23:30:23 -0500, Austin Clements wrote:
> One indentation nit and then this LGTM.
>
> > + (lexical-let ((message-id message-id)
> > + (nth nth)
> > + (filename filename)
> > + (content-type content-type))
> > + (flet
---
INSTALL | 12 ++--
NEWS|9 +
2 files changed, 15 insertions(+), 6 deletions(-)
diff --git a/INSTALL b/INSTALL
index e51b397..bc98f1d 100644
--- a/INSTALL
+++ b/INSTALL
@@ -20,8 +20,8 @@ configure stage.
Dependencies
-Notmuch depends on three librarie
There are lots of API changes in gmime 2.6 crypto handling. By adding
preprocessor directives, it is however possible to add gmime 2.6 compatibility
while preserving compatibility with gmime 2.4 too.
This is mostly based on id:"8762i8hrb9@bookbinder.fernseed.info".
This was tested against bot
JSON does not support hex literals (0x..) so numbers must be formatted as %d
instead of %x.
---
notmuch-show.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/notmuch-show.c b/notmuch-show.c
index d14dac9..91f566c 100644
--- a/notmuch-show.c
+++ b/notmuch-show.c
@@ -641,7
On Thu, 19 Jan 2012 23:10:44 -0500, Austin Clements wrote:
> Nearly there. A few more small comments.
Thanks again :) Will post new version soon, including a new patch to
update NEWS and INSTALL.
> Quoth Thomas Jost on Jan 20 at 1:06 am:
> > There are lots of API changes in gmime 2.6 crypto ha
On Fri, 20 Jan 2012 01:24:02 +0100, Pieter Praet wrote:
> [...]
> Most likely because "$test_subtest_missing_external_prereqs_" is only
> reset at the beginning of every test series, so if an Emacs-dependent
> subtest is skipped, all subsequent skipped subtests will report that
> dependency as wel
On Wed, 18 Jan 2012 15:53:59 +0200, Tomi Ollila wrote:
> On Wed, 18 Jan 2012 13:19:41 +0100, Pieter Praet wrote:
> > When tests are skipped due to missing prereqs, those prereqs are only
> > displayed when running with the `--verbose' option. This is essential
> > information when troubleshootin
There are lots of API changes in gmime 2.6 crypto handling. By adding
preprocessor directives, it is however possible to add gmime 2.6 compatibility
while preserving compatibility with gmime 2.4 too.
This is mostly based on id:"8762i8hrb9.fsf at bookbinder.fernseed.info".
This was tested against
JSON does not support hex literals (0x..) so numbers must be formatted as %d
instead of %x.
---
notmuch-show.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/notmuch-show.c b/notmuch-show.c
index d14dac9..91f566c 100644
--- a/notmuch-show.c
+++ b/notmuch-show.c
@@ -641,7
Hi list,
Here's another update of the patches to add gmime 2.6 compatibilty
while still preserving compatibility with gmime 2.4.
Any comments or review will be much appreciated.
The changes compared to the previous version ([1] and [2]) are pretty
minor:
- space and indentation fixes
- correctly
On Thu, 19 Jan 2012 17:59:10 -0500, Austin Clements wrote:
> LGTM, but should definitely come with a test.
>
[...]
> Also, this won't commute with Pieter's patch
> (id:"1327000744-25463-2-git-send-email-pieter at praet.org"), so one or
> the other will have to get updated.
>
No problem, I'll
On Thu, 19 Jan 2012 21:46:46 -0700, Adam Wolfe Gordon
wrote:
> On Thu, Jan 19, 2012 at 11:45, Aaron Ecay wrote:
> > Shouldn?t this just use message-insert-formatted-citation-line?
>
> Yes, good idea. I just tried this and it almost works. The only
> issue is that the default message-mode-cita
rrect for signed parts, but will incorrectly trigger
> > > for an encrypted part with no signatures. For 2.6, I think this error
> > > checking may have to move into the branches of the if encrypted/signed
> > > since for encrypted parts you have to check if
> > > g_mime_multipart_encrypted_decrypt returned NULL.
> >
> > That sound right. The weird part is that it did not cause anything to
> > fail in the test suite...
>
> It would be worth adding a test with an encrypted but unsigned part.
> I don't know enough GPG myself to do that.
It looks like there's already one: "emacs delivery of encrypted message
with attachment" + following decryptions.
Regards,
--
Thomas/Schnouki
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120120/1544b0d5/attachment.pgp>
From: Dmitry Kurochkin
This makes `show-trailing-whitespace' happy, i.e. it does not mark the
whole search box line as trailing spaces.
Since the dot is invisible, this change makes no visible difference
for `notmuch-hello'.
Edited-by: Pieter Praet to fix the tests.
---
emacs/notmuch-hello.el
On Fri, 20 Jan 2012 02:37:30 +0400, Dmitry Kurochkin wrote:
> On Thu, 19 Jan 2012 22:31:14 +0100, Pieter Praet wrote:
> > Not meant to be applied!
> >
> > Should be merged into
> > id:"1326815734-20421-1-git-send-email-dmitry.kurochkin at gmail.com"
> >
>
> Oops. I managed to miss the faili
e/gmime/.libs" ./configure
--prefix=/usr --sysconfdir=/etc
make
ldd ./notmuch
Regards,
--
Thomas/Schnouki
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120120/ccb50063/attachment-0001.pgp>
> > that this might be useful when GMIME > 2.6 is available...
>
> Hopefully before GMIME 2.8 comes out, we'll be able to remove all of
> the GMIME 2.4 compatibility. But GMIME_ATLEAST_26 would be fine, too.
Heh, maybe things will change again in 2.8 and "ATLEAST_26&quo
te);
> > + if (name && (trust == GMIME_CERTIFICATE_TRUST_FULLY || trust ==
> > GMIME_CERTIFICATE_TRUST_ULTIMATE))
> > + printf (", \"userid\": %s", json_quote_str (ctx_quote,
> > name));
> > + }
> > + } else if (certificate) {
> > + const char *key_id = g_mime_certificate_get_key_id (certificate);
> > + if (key_id)
> > + printf (", \"keyid\": %s", json_quote_str (ctx_quote, key_id));
> > + }
> > +
> > + GMimeSignatureError errors = g_mime_signature_get_errors (signature);
> > + if (errors != GMIME_SIGNATURE_ERROR_NONE) {
> > + printf (", \"errors\": %d", errors);
> > + }
> > +
> > + printf ("}");
> > + }
> > +
> > +printf ("]");
> > +
> > +talloc_free (ctx_quote);
> > +}
> > +#else
> > static void
> > format_part_sigstatus_json (const GMimeSignatureValidity* validity)
> > {
> > @@ -652,6 +739,7 @@ format_part_sigstatus_json (const
> > GMimeSignatureValidity* validity)
> >
> > talloc_free (ctx_quote);
> > }
> > +#endif
> >
> > static void
> > format_part_content_json (GMimeObject *part)
> > @@ -990,13 +1078,20 @@ notmuch_show_command (void *ctx, unused (int argc),
> > unused (char *argv[]))
> > } else if ((STRNCMP_LITERAL (argv[i], "--verify") == 0) ||
> >(STRNCMP_LITERAL (argv[i], "--decrypt") == 0)) {
> > if (params.cryptoctx == NULL) {
> > +#ifdef GMIME_26
> > + /* TODO: GMimePasswordRequestFunc */
> > + if (NULL == (params.cryptoctx = g_mime_gpg_context_new(NULL,
> > "gpg")))
> > +#else
> > GMimeSession* session = g_object_new(g_mime_session_get_type(),
> > NULL);
> > if (NULL == (params.cryptoctx = g_mime_gpg_context_new(session,
> > "gpg")))
> > +#endif
> > fprintf (stderr, "Failed to construct gpg context.\n");
> > else
> >
> > g_mime_gpg_context_set_always_trust((GMimeGpgContext*)params.cryptoctx,
> > FALSE);
> > +#ifndef GMIME_26
> > g_object_unref (session);
> > session = NULL;
> > +#endif
> > }
> > if (STRNCMP_LITERAL (argv[i], "--decrypt") == 0)
> > params.decrypt = 1;
> > diff --git a/show-message.c b/show-message.c
> > index 8768889..65269fd 100644
> > --- a/show-message.c
> > +++ b/show-message.c
> > @@ -48,7 +48,11 @@ show_message_part (mime_node_t *node,
> > format->part_encstatus (node->decrypt_success);
> >
> > if (node->verify_attempted && format->part_sigstatus)
> > +#ifdef GMIME_26
> > + format->part_sigstatus (node->sig_list);
> > +#else
> > format->part_sigstatus (node->sig_validity);
> > +#endif
> >
> > format->part_content (part);
> >
--
Thomas/Schnouki
-- next part --
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL:
<http://notmuchmail.org/pipermail/notmuch/attachments/20120120/35372ddb/attachment.pgp>
1 - 100 of 103 matches
Mail list logo